From a02e5331f6064a7b9dd11f1091ab9fcb1bbdadcc Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Thu, 24 Feb 2011 17:03:28 -0800 Subject: [PATCH] ofproto: Log warning if controller requests an invalid table. This might have saved us some time debugging. --- ofproto/ofproto.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 61d08ea4..2efb03af 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -3543,7 +3543,16 @@ put_ofp_flow_stats(struct ofconn *ofconn, struct rule *rule, static bool is_valid_table(uint8_t table_id) { - return table_id == 0 || table_id == 0xff; + if (table_id == 0 || table_id == 0xff) { + return true; + } else { + /* It would probably be better to reply with an error but there doesn't + * seem to be any appropriate value, so that might just be + * confusing. */ + VLOG_WARN_RL(&rl, "controller asked for invalid table %"PRIu8, + table_id); + return false; + } } static int -- 2.30.2