From 975243c9fb21ec51e9cc59db68626a800be78abd Mon Sep 17 00:00:00 2001
From: Eric Blake <ebb9@byu.net>
Date: Thu, 29 Oct 2009 07:29:26 -0600
Subject: [PATCH] maint: detect usage(1) and other suspicious exits

* top/maint.mk (sc_prohibit_magic_number_exit): New rule.

Signed-off-by: Eric Blake <ebb9@byu.net>
---
 ChangeLog    | 5 +++++
 top/maint.mk | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index b2073ee7b1..b0c83b8a8b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-10-29  Eric Blake  <ebb9@byu.net>
+
+	maint: detect usage(1) and other suspicious exits
+	* top/maint.mk (sc_prohibit_magic_number_exit): New rule.
+
 2009-10-29  Jim Meyering  <meyering@redhat.com>
 
 	timespec: long-to-int truncation could make timespec_cmp malfunction
diff --git a/top/maint.mk b/top/maint.mk
index 68bd8f9153..996344a93d 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -156,6 +156,12 @@ sc_prohibit_strcmp:
 	  { echo '$(ME): use STREQ in place of the above uses of str''cmp' \
 		1>&2; exit 1; } || :
 
+# Pass EXIT_*, not number, to usage, exit, and error (when exiting)
+sc_prohibit_magic_number_exit:
+	@re='\<(usage|exit) ?\([0-9]|\<error ?\([1-9][0-9]*,'		\
+	msg='use EXIT_* values rather than magic number'		\
+	  $(_prohibit_regexp)
+
 # Using EXIT_SUCCESS as the first argument to error is misleading,
 # since when that parameter is 0, error does not exit.  Use `0' instead.
 sc_error_exit_success:
-- 
2.30.2