From 9601fa824d2c3968fda75204488e347d66d62d1f Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Tue, 23 Aug 2011 11:09:46 -0700 Subject: [PATCH] ovs.stream: Fix logic bug in Stream.connect(). The loop here is supposed to run at least once, and to continue looping as long as the loop body changes the current state, but this bug caused it to continue looping until the connection completed in success or failure. It probably didn't cause many problems in practice because only Unix domain socket connections are currently supported, and those connections normally complete immediately. Reported-by: Reid Price --- python/ovs/stream.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/ovs/stream.py b/python/ovs/stream.py index 21923798..c1ce422f 100644 --- a/python/ovs/stream.py +++ b/python/ovs/stream.py @@ -136,6 +136,7 @@ class Stream(object): returns errno.EAGAIN.""" last_state = -1 # Always differs from initial self.state while self.state != last_state: + last_state = self.state if self.state == Stream.__S_CONNECTING: self.__scs_connecting() elif self.state == Stream.__S_CONNECTED: -- 2.30.2