From 8cea3c07718d55c6eea288be87b3ea9e4d3b88cd Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Fri, 5 Aug 2011 14:14:18 -0700 Subject: [PATCH] bridge: Add port to datapath before trying to retrieve device stats. Virtual ports such as GRE tunnels don't exist until after the port is added to the datapath, so without this change adding such a port yields a warning like the following: netdev|WARN|failed to retrieve MTU for network device gre0: No such device --- vswitchd/bridge.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 6491590a..bd369eb7 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -871,12 +871,6 @@ bridge_add_ofproto_ports(struct bridge *br) iface->name, strerror(error)); } - /* Populate stats columns in new Interface rows. */ - if (iface->netdev && !iface->cfg->mtu) { - iface_refresh_stats(iface); - iface_refresh_status(iface); - } - /* Add the port, if necessary. */ if (iface->netdev && iface->ofp_port < 0) { uint16_t ofp_port; @@ -892,6 +886,12 @@ bridge_add_ofproto_ports(struct bridge *br) } } + /* Populate stats columns in new Interface rows. */ + if (iface->netdev && !iface->cfg->mtu) { + iface_refresh_stats(iface); + iface_refresh_status(iface); + } + /* Delete the iface if */ if (iface->netdev && iface->ofp_port >= 0) { VLOG_DBG("bridge %s: interface %s is on port %d", -- 2.30.2