From 8bddb894d90d84b642b9fd4fa83abf2af0074fba Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Tue, 28 Feb 2012 12:53:13 -0800 Subject: [PATCH] bridge: Drop log message when a QoS record lacks a default queue. Apparently we're planning to use this configuration regularly at Nicira. Bug #7413. Requested-by: Bryan Fulton Signed-off-by: Ben Pfaff --- vswitchd/bridge.c | 5 ----- vswitchd/vswitch.xml | 8 +++++--- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 5b0f66fe..6293dad5 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -3196,11 +3196,6 @@ iface_configure_qos(struct iface *iface, const struct ovsrec_qos *qos) shash_destroy(&details); } if (!queue_zero) { - static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1); - VLOG_WARN_RL(&rl, "interface %s: QoS configured without a default " - "queue (queue 0). Using default configuration.", - iface->name); - shash_init(&details); netdev_set_queue(iface->netdev, 0, &details); shash_destroy(&details); diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index cd50f556..06edb767 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -2061,9 +2061,11 @@

Queue 0 is the ``default queue.'' It is used by OpenFlow output - actions when no specific queue has been set. Ordinarily should include a configuration for queue 0. When no - configuration for queue 0 is present, a default configuration is used. + actions when no specific queue has been set. When no configuration for + queue 0 is present, it is automatically configured as if a record with empty + and columns had been + specified. (Before version 1.6, Open vSwitch would leave queue 0 unconfigured in this case. With some queuing disciplines, this dropped all packets destined for the default queue.) -- 2.30.2