From 7a6f6f0ac17ae6622b3da698bcffdce7d5510b3c Mon Sep 17 00:00:00 2001
From: Ben Pfaff <blp@cs.stanford.edu>
Date: Fri, 2 Jan 2026 10:27:36 -0800
Subject: [PATCH] cleanup

---
 rust/pspp/src/spv/read/legacy_xml.rs | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/rust/pspp/src/spv/read/legacy_xml.rs b/rust/pspp/src/spv/read/legacy_xml.rs
index c5bc81fa8b..5a56934d88 100644
--- a/rust/pspp/src/spv/read/legacy_xml.rs
+++ b/rust/pspp/src/spv/read/legacy_xml.rs
@@ -653,11 +653,12 @@ impl Visualization {
             warn(LegacyXmlWarning::MissingData);
         }
 
-        for child in &graph.facet_layout.children {
-            let FacetLayoutChild::SetCellProperties(scp) = child else {
-                continue;
-            };
-
+        for scp in graph
+            .facet_layout
+            .children
+            .iter()
+            .filter_map(|child| child.set_cell_properties())
+        {
             #[derive(Copy, Clone, Debug, PartialEq)]
             enum TargetType {
                 Labeling,
@@ -1826,6 +1827,12 @@ enum FacetLayoutChild {
 }
 
 impl FacetLayoutChild {
+    fn set_cell_properties(&self) -> Option<&SetCellProperties> {
+        match self {
+            Self::SetCellProperties(scp) => Some(scp),
+            _ => None,
+        }
+    }
     fn facet_level(&self) -> Option<&FacetLevel> {
         match self {
             Self::FacetLevel(facet_level) => Some(facet_level),
-- 
2.30.2