From 7509e3c4af13db1b48b779c7eac6342d5b778374 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 15 May 2011 09:37:21 -0700 Subject: [PATCH] intprops-tests: new module * modules/intprops-tests, tests/test-intprops.c: New files. --- ChangeLog | 3 + modules/intprops-tests | 13 +++ tests/test-intprops.c | 253 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 269 insertions(+) create mode 100644 modules/intprops-tests create mode 100644 tests/test-intprops.c diff --git a/ChangeLog b/ChangeLog index ef91dd2db6..c2a67dadc0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2011-05-13 Paul Eggert + intprops-tests: new module + * modules/intprops-tests, tests/test-intprops.c: New files. + intprops: add safe, portable integer overflow checking * lib/intprops.h (_GL_INT_CONVERT, _GL_INT_TWOS_COMPLEMENT): (_GL_INT_SIGNED, _GL_INT_MINIMUM, _GL_INT_MAXIMUM): diff --git a/modules/intprops-tests b/modules/intprops-tests new file mode 100644 index 0000000000..4aa04d9697 --- /dev/null +++ b/modules/intprops-tests @@ -0,0 +1,13 @@ +Files: +tests/test-intprops.c + +Depends-on: +inttypes +stdbool +verify + +configure.ac: + +Makefile.am: +TESTS += test-intprops +check_PROGRAMS += test-intprops diff --git a/tests/test-intprops.c b/tests/test-intprops.c new file mode 100644 index 0000000000..aae261432a --- /dev/null +++ b/tests/test-intprops.c @@ -0,0 +1,253 @@ +/* Test intprops.h. + Copyright (C) 2011 Free Software Foundation, Inc. + + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +/* Written by Paul Eggert. */ + +#include + +#include "intprops.h" +#include "verify.h" + +#include +#include + +/* TYPE_IS_INTEGER. */ +verify (TYPE_IS_INTEGER (bool)); +verify (TYPE_IS_INTEGER (char)); +verify (TYPE_IS_INTEGER (signed char)); +verify (TYPE_IS_INTEGER (unsigned char)); +verify (TYPE_IS_INTEGER (short int)); +verify (TYPE_IS_INTEGER (unsigned short int)); +verify (TYPE_IS_INTEGER (int)); +verify (TYPE_IS_INTEGER (unsigned int)); +verify (TYPE_IS_INTEGER (long int)); +verify (TYPE_IS_INTEGER (unsigned long int)); +verify (TYPE_IS_INTEGER (intmax_t)); +verify (TYPE_IS_INTEGER (uintmax_t)); +verify (! TYPE_IS_INTEGER (float)); +verify (! TYPE_IS_INTEGER (double)); +verify (! TYPE_IS_INTEGER (long double)); + +/* Integer representation. */ +verify (INT_MIN + INT_MAX < 0 + ? (TYPE_TWOS_COMPLEMENT (int) + && ! TYPE_ONES_COMPLEMENT (int) && ! TYPE_SIGNED_MAGNITUDE (int)) + : (! TYPE_TWOS_COMPLEMENT (int) + && (TYPE_ONES_COMPLEMENT (int) || TYPE_SIGNED_MAGNITUDE (int)))); + +/* TYPE_SIGNED. */ +/* verify (! TYPE_SIGNED (bool)); */ /* not guaranteed by gnulib substitute */ +verify (TYPE_SIGNED (signed char)); +verify (! TYPE_SIGNED (unsigned char)); +verify (TYPE_SIGNED (short int)); +verify (! TYPE_SIGNED (unsigned short int)); +verify (TYPE_SIGNED (int)); +verify (! TYPE_SIGNED (unsigned int)); +verify (TYPE_SIGNED (long int)); +verify (! TYPE_SIGNED (unsigned long int)); +verify (TYPE_SIGNED (intmax_t)); +verify (! TYPE_SIGNED (uintmax_t)); +verify (TYPE_SIGNED (float)); +verify (TYPE_SIGNED (double)); +verify (TYPE_SIGNED (long double)); + +/* TYPE_MINIMUM, TYPE_MAXIMUM. */ +verify (TYPE_MINIMUM (char) == CHAR_MIN); +verify (TYPE_MAXIMUM (char) == CHAR_MAX); +verify (TYPE_MINIMUM (unsigned char) == 0); +verify (TYPE_MAXIMUM (unsigned char) == UCHAR_MAX); +verify (TYPE_MINIMUM (signed char) == SCHAR_MIN); +verify (TYPE_MAXIMUM (signed char) == SCHAR_MAX); +verify (TYPE_MINIMUM (short int) == SHRT_MIN); +verify (TYPE_MAXIMUM (short int) == SHRT_MAX); +verify (TYPE_MINIMUM (unsigned short int) == 0); +verify (TYPE_MAXIMUM (unsigned short int) == USHRT_MAX); +verify (TYPE_MINIMUM (int) == INT_MIN); +verify (TYPE_MAXIMUM (int) == INT_MAX); +verify (TYPE_MINIMUM (unsigned int) == 0); +verify (TYPE_MAXIMUM (unsigned int) == UINT_MAX); +verify (TYPE_MINIMUM (long int) == LONG_MIN); +verify (TYPE_MAXIMUM (long int) == LONG_MAX); +verify (TYPE_MINIMUM (unsigned long int) == 0); +verify (TYPE_MAXIMUM (unsigned long int) == ULONG_MAX); +verify (TYPE_MINIMUM (intmax_t) == INTMAX_MIN); +verify (TYPE_MAXIMUM (intmax_t) == INTMAX_MAX); +verify (TYPE_MINIMUM (uintmax_t) == 0); +verify (TYPE_MAXIMUM (uintmax_t) == UINTMAX_MAX); + +/* INT_BITS_STRLEN_BOUND. */ +verify (INT_BITS_STRLEN_BOUND (1) == 1); +verify (INT_BITS_STRLEN_BOUND (2620) == 789); + +/* INT_STRLEN_BOUND, INT_BUFSIZE_BOUND. */ +#ifdef INT32_MAX /* POSIX guarantees int32_t; this ports to non-POSIX hosts */ +verify (INT_STRLEN_BOUND (int32_t) == sizeof ("-2147483648") - 1); +verify (INT_BUFSIZE_BOUND (int32_t) == sizeof ("-2147483648")); +#endif +#ifdef INT64_MAX +verify (INT_STRLEN_BOUND (int64_t) == sizeof ("-9223372036854775808") - 1); +verify (INT_BUFSIZE_BOUND (int64_t) == sizeof ("-9223372036854775808")); +#endif + +/* All the INT__RANGE_OVERFLOW tests are equally valid as + INT__OVERFLOW tests, so define a single macro to do both. */ +#define check_binop(op, a, b, min, max, overflow) \ + (INT_##op##_RANGE_OVERFLOW (a, b, min, max) == (overflow) \ + && INT_##op##_OVERFLOW (a, b) == (overflow)) +#define check_unop(op, a, min, max, overflow) \ + (INT_##op##_RANGE_OVERFLOW (a, min, max) == (overflow) \ + && INT_##op##_OVERFLOW (a) == (overflow)) + +/* INT__RANGE_OVERFLOW, INT__OVERFLOW. */ +verify (INT_ADD_RANGE_OVERFLOW (INT_MAX, 1, INT_MIN, INT_MAX)); +verify (INT_ADD_OVERFLOW (INT_MAX, 1)); +verify (check_binop (ADD, INT_MAX, 1, INT_MIN, INT_MAX, true)); +verify (check_binop (ADD, INT_MAX, -1, INT_MIN, INT_MAX, false)); +verify (check_binop (ADD, INT_MIN, 1, INT_MIN, INT_MAX, false)); +verify (check_binop (ADD, INT_MIN, -1, INT_MIN, INT_MAX, true)); +verify (check_binop (ADD, UINT_MAX, 1u, 0u, UINT_MAX, true)); +verify (check_binop (ADD, 0u, 1u, 0u, UINT_MAX, false)); + +verify (check_binop (SUBTRACT, INT_MAX, 1, INT_MIN, INT_MAX, false)); +verify (check_binop (SUBTRACT, INT_MAX, -1, INT_MIN, INT_MAX, true)); +verify (check_binop (SUBTRACT, INT_MIN, 1, INT_MIN, INT_MAX, true)); +verify (check_binop (SUBTRACT, INT_MIN, -1, INT_MIN, INT_MAX, false)); +verify (check_binop (SUBTRACT, UINT_MAX, 1u, 0u, UINT_MAX, false)); +verify (check_binop (SUBTRACT, 0u, 1u, 0u, UINT_MAX, true)); + +verify (check_unop (NEGATE, INT_MIN, INT_MIN, INT_MAX, + TYPE_TWOS_COMPLEMENT (int))); +verify (check_unop (NEGATE, 0, INT_MIN, INT_MAX, false)); +verify (check_unop (NEGATE, INT_MAX, INT_MIN, INT_MAX, false)); +verify (check_unop (NEGATE, 0u, 0u, UINT_MAX, false)); +verify (check_unop (NEGATE, 1u, 0u, UINT_MAX, true)); +verify (check_unop (NEGATE, UINT_MAX, 0u, UINT_MAX, true)); + +verify (check_binop (MULTIPLY, INT_MAX, INT_MAX, INT_MIN, INT_MAX, true)); +verify (check_binop (MULTIPLY, INT_MAX, INT_MIN, INT_MIN, INT_MAX, true)); +verify (check_binop (MULTIPLY, INT_MIN, INT_MAX, INT_MIN, INT_MAX, true)); +verify (check_binop (MULTIPLY, INT_MIN, INT_MIN, INT_MIN, INT_MAX, true)); +verify (check_binop (MULTIPLY, -1, INT_MIN, INT_MIN, INT_MAX, + INT_NEGATE_OVERFLOW (INT_MIN))); +verify (check_binop (MULTIPLY, LONG_MIN / INT_MAX, (long int) INT_MAX, + LONG_MIN, LONG_MIN, false)); + +verify (check_binop (DIVIDE, INT_MIN, -1, INT_MIN, INT_MAX, + INT_NEGATE_OVERFLOW (INT_MIN))); +verify (check_binop (DIVIDE, INT_MAX, 1, INT_MIN, INT_MAX, false)); +verify (check_binop (DIVIDE, (unsigned int) INT_MIN, + -1u, 0u, UINT_MAX, false)); + +verify (check_binop (REMAINDER, INT_MIN, -1, INT_MIN, INT_MAX, + INT_NEGATE_OVERFLOW (INT_MIN))); +verify (check_binop (REMAINDER, INT_MAX, 1, INT_MIN, INT_MAX, false)); +verify (check_binop (REMAINDER, (unsigned int) INT_MIN, + -1u, 0u, UINT_MAX, false)); + +verify (check_binop (LEFT_SHIFT, UINT_MAX, 1, 0u, UINT_MAX, true)); +verify (check_binop (LEFT_SHIFT, UINT_MAX / 2 + 1, 1, 0u, UINT_MAX, true)); +verify (check_binop (LEFT_SHIFT, UINT_MAX / 2, 1, 0u, UINT_MAX, false)); + +/* INT__OVERFLOW with mixed types. */ +#define check_sum(a, b, overflow) \ + verify (INT_ADD_OVERFLOW (a, b) == (overflow)); \ + verify (INT_ADD_OVERFLOW (b, a) == (overflow)) +check_sum (-1, LONG_MIN, true); +check_sum (-1, UINT_MAX, false); +check_sum (-1L, INT_MIN, INT_MIN == LONG_MIN); +check_sum (0u, -1, true); +check_sum (0u, 0, false); +check_sum (0u, 1, false); +check_sum (1, LONG_MAX, true); +check_sum (1, UINT_MAX, true); +check_sum (1L, INT_MAX, INT_MAX == LONG_MAX); +check_sum (1u, INT_MAX, INT_MAX == UINT_MAX); +check_sum (1u, INT_MIN, true); + +verify (! INT_SUBTRACT_OVERFLOW (INT_MAX, 1u)); +verify (! INT_SUBTRACT_OVERFLOW (UINT_MAX, 1)); +verify (! INT_SUBTRACT_OVERFLOW (0u, -1)); +verify (INT_SUBTRACT_OVERFLOW (UINT_MAX, -1)); +verify (INT_SUBTRACT_OVERFLOW (INT_MIN, 1u)); +verify (INT_SUBTRACT_OVERFLOW (-1, 0u)); + +#define check_product(a, b, overflow) \ + verify (INT_MULTIPLY_OVERFLOW (a, b) == (overflow)); \ + verify (INT_MULTIPLY_OVERFLOW (b, a) == (overflow)) + +check_product (-1, 1u, true); +check_product (-1, INT_MIN, INT_NEGATE_OVERFLOW (INT_MIN)); +check_product (-1, UINT_MAX, true); +check_product (-12345, LONG_MAX / -12345 - 1, true); +check_product (-12345, LONG_MAX / -12345, false); +check_product (0, -1, false); +check_product (0, 0, false); +check_product (0, 0u, false); +check_product (0, 1, false); +check_product (0, INT_MAX, false); +check_product (0, INT_MIN, false); +check_product (0, UINT_MAX, false); +check_product (0u, -1, false); +check_product (0u, 0, false); +check_product (0u, 0u, false); +check_product (0u, 1, false); +check_product (0u, INT_MAX, false); +check_product (0u, INT_MIN, false); +check_product (0u, UINT_MAX, false); +check_product (1, INT_MAX, false); +check_product (1, INT_MIN, false); +check_product (1, UINT_MAX, false); +check_product (1u, INT_MIN, true); +check_product (1u, INT_MAX, UINT_MAX < INT_MAX); +check_product (INT_MAX, UINT_MAX, true); +check_product (INT_MAX, ULONG_MAX, true); +check_product (INT_MIN, LONG_MAX / INT_MIN - 1, true); +check_product (INT_MIN, LONG_MAX / INT_MIN, false); +check_product (INT_MIN, UINT_MAX, true); +check_product (INT_MIN, ULONG_MAX, true); + +verify (INT_DIVIDE_OVERFLOW (INT_MIN, -1L) + == (TYPE_TWOS_COMPLEMENT (long int) && INT_MIN == LONG_MIN)); +verify (! INT_DIVIDE_OVERFLOW (INT_MIN, UINT_MAX)); +verify (! INT_DIVIDE_OVERFLOW (INTMAX_MIN, UINTMAX_MAX)); +verify (! INT_DIVIDE_OVERFLOW (INTMAX_MIN, UINT_MAX)); +verify (INT_DIVIDE_OVERFLOW (-11, 10u)); +verify (INT_DIVIDE_OVERFLOW (-10, 10u)); +verify (! INT_DIVIDE_OVERFLOW (-9, 10u)); +verify (INT_DIVIDE_OVERFLOW (11u, -10)); +verify (INT_DIVIDE_OVERFLOW (10u, -10)); +verify (! INT_DIVIDE_OVERFLOW (9u, -10)); + +verify (INT_REMAINDER_OVERFLOW (INT_MIN, -1L) + == (TYPE_TWOS_COMPLEMENT (long int) && INT_MIN == LONG_MIN)); +verify (INT_REMAINDER_OVERFLOW (-1, UINT_MAX)); +verify (INT_REMAINDER_OVERFLOW ((intmax_t) -1, UINTMAX_MAX)); +verify (INT_REMAINDER_OVERFLOW (INTMAX_MIN, UINT_MAX) + == (INTMAX_MAX < UINT_MAX + && - (unsigned int) INTMAX_MIN % UINT_MAX != 0)); +verify (INT_REMAINDER_OVERFLOW (INT_MIN, ULONG_MAX) + == (INT_MIN % ULONG_MAX != 1)); +verify (! INT_REMAINDER_OVERFLOW (1u, -1)); +verify (! INT_REMAINDER_OVERFLOW (37*39u, -39)); +verify (INT_REMAINDER_OVERFLOW (37*39u + 1, -39)); +verify (INT_REMAINDER_OVERFLOW (37*39u - 1, -39)); +verify (! INT_REMAINDER_OVERFLOW (LONG_MAX, -INT_MAX)); + +int +main (void) +{ + return 0; +} -- 2.30.2