From 61a6dfff9145af1bef0fc4daa161410ee3fb6fe1 Mon Sep 17 00:00:00 2001 From: John Darrington Date: Tue, 5 Nov 2019 16:49:35 +0100 Subject: [PATCH] Fixed incorrect syntax generated by the Select Random Cases dialog. Reported by: Eric E Graig --- NEWS | 3 +++ src/ui/gui/psppire-dialog-action-select.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 2c07d2a416..2048f8c434 100644 --- a/NEWS +++ b/NEWS @@ -6,6 +6,9 @@ Please send PSPP bug reports to bug-gnu-pspp@gnu.org. Changes from 1.2.0 to 1.3.0: + * A bug where the Data|Select Cases|Random Sample menu would generate + invalid syntax has been fixed. + * FREQUENCIES will emit a warning if one or more weight values are missing. * Plain text output is no longer divided into pages, since it is now diff --git a/src/ui/gui/psppire-dialog-action-select.c b/src/ui/gui/psppire-dialog-action-select.c index e5d777dada..ee45db152e 100644 --- a/src/ui/gui/psppire-dialog-action-select.c +++ b/src/ui/gui/psppire-dialog-action-select.c @@ -414,7 +414,7 @@ generate_syntax_filter (const PsppireDialogAction *a) ranvar); ds_put_c_format (&dss, - "SORT BY %s, %s.\n", + "SORT CASES BY %s, %s.\n", filter, ranvar); ds_put_cstr (&dss, "EXECUTE.\n"); @@ -434,7 +434,7 @@ generate_syntax_filter (const PsppireDialogAction *a) ds_put_c_format (&dss, - "SORT BY %s.\n", + "SORT CASES BY %s.\n", key); ds_put_c_format (&dss, -- 2.30.2