From 60c5990dc466c0b9fc5a10bc133d6970c5bd9152 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 4 Oct 2004 04:24:47 +0000 Subject: [PATCH] (mode_compile): Don't decrement a pointer that points to the start of a string, as the C Standard says the resulting behavior is undefined. --- lib/modechange.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/modechange.c b/lib/modechange.c index b4df3388ce..991235b09c 100644 --- a/lib/modechange.c +++ b/lib/modechange.c @@ -211,10 +211,9 @@ mode_compile (const char *mode_string, unsigned int masked_ops) umask_value = umask (0); umask (umask_value); /* Restore the old value. */ - --mode_string; /* One loop iteration for each "ugoa...=+-rwxXstugo...[=+-rwxXstugo...]". */ - do + for (;; mode_string++) { /* Which bits in the mode are operated on. */ mode_t affected_bits = 0; @@ -226,7 +225,7 @@ mode_compile (const char *mode_string, unsigned int masked_ops) bool who_specified_p; /* Turn on all the bits in `affected_bits' for each group given. */ - for (++mode_string;; ++mode_string) + for (;; mode_string++) switch (*mode_string) { case 'u': @@ -349,7 +348,11 @@ mode_compile (const char *mode_string, unsigned int masked_ops) } no_more_values:; } - } while (*mode_string == ','); + + if (*mode_string != ',') + break; + } + if (*mode_string == 0) return head; invalid: -- 2.30.2