From 530a1d915be60e1b48f91af951f34aee53013b09 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Mon, 16 Apr 2012 14:07:56 -0700 Subject: [PATCH] ofproto-dpif: Drop unneeded _SAFE from iteration in handle_flow_miss(). The loop never frees the packet that it operates on, so _SAFE is not needed. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index a42d09eb..f9936e4c 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -2562,8 +2562,8 @@ handle_flow_miss(struct ofproto_dpif *ofproto, struct flow_miss *miss, struct flow_miss_op *ops, size_t *n_ops) { const struct flow *flow = &miss->flow; - struct ofpbuf *packet, *next_packet; struct subfacet *subfacet; + struct ofpbuf *packet; struct facet *facet; facet = facet_lookup_valid(ofproto, flow); @@ -2599,7 +2599,7 @@ handle_flow_miss(struct ofproto_dpif *ofproto, struct flow_miss *miss, miss->key_fitness, miss->key, miss->key_len, miss->initial_tci); - LIST_FOR_EACH_SAFE (packet, next_packet, list_node, &miss->packets) { + LIST_FOR_EACH (packet, list_node, &miss->packets) { struct dpif_flow_stats stats; struct flow_miss_op *op; struct dpif_execute *execute; -- 2.30.2