From 4faaba2b90979e1106b8c9b0430481f2cc62364d Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Mon, 27 Dec 2010 15:21:29 -0800 Subject: [PATCH] datapath: Fix type of actions_len_left in modify_vlan_tci(). The sparse checker reported that the type of the pointer passed to nla_next(), as &actions_len_left, was incorrect: whereas the parameter has type "int *", &actions_len_left is an "unsigned int *". This fixes the problem. It is not a bug fix since the code is equally correct (or incorrect) either way, but it gets the types right anyhow. I don't know why GCC was not reporting this as an error. Signed-off-by: Ben Pfaff Acked-by: Jesse Gross --- datapath/actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/actions.c b/datapath/actions.c index 32053f01..639b8707 100644 --- a/datapath/actions.c +++ b/datapath/actions.c @@ -137,7 +137,7 @@ static struct sk_buff *modify_vlan_tci(struct datapath *dp, struct sk_buff *skb, * groups configured). */ if (skb_is_gso(skb)) { const struct nlattr *actions_left; - u32 actions_len_left; + int actions_len_left; struct sk_buff *segs; segs = skb_gso_segment(skb, 0); -- 2.30.2