From 4d5df6bcfe9611ed7bed2585e1c2a4a48ece44fb Mon Sep 17 00:00:00 2001 From: John Darrington Date: Sun, 14 Jun 2020 17:42:45 +0200 Subject: [PATCH] file-handle-def.h (fh_ref): Add WARN_UNUSED_RESULT qualifier --- src/data/file-handle-def.c | 2 +- src/data/file-handle-def.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/data/file-handle-def.c b/src/data/file-handle-def.c index 4546a9ca0c..1296a5b171 100644 --- a/src/data/file-handle-def.c +++ b/src/data/file-handle-def.c @@ -409,7 +409,7 @@ fh_set_default_handle (struct file_handle *new_default_handle) fh_unref (default_handle); default_handle = new_default_handle; if (default_handle != NULL) - fh_ref (default_handle); + default_handle = fh_ref (default_handle); } /* Information about a file handle's readers or writers. */ diff --git a/src/data/file-handle-def.h b/src/data/file-handle-def.h index af40c7ab37..2f944ed1c2 100644 --- a/src/data/file-handle-def.h +++ b/src/data/file-handle-def.h @@ -17,6 +17,7 @@ #ifndef FILE_HANDLE_DEF_H #define FILE_HANDLE_DEF_H +#include "libpspp/compiler.h" #include #include @@ -81,7 +82,7 @@ struct file_handle *fh_create_dataset (struct dataset *); const struct fh_properties *fh_default_properties (void); /* Reference management. */ -struct file_handle *fh_ref (struct file_handle *); +struct file_handle *fh_ref (struct file_handle *) WARN_UNUSED_RESULT; void fh_unref (struct file_handle *); void fh_unname (struct file_handle *); -- 2.30.2