From 316dec68688aeccc1bbb90e555d9c0ca259d9fc7 Mon Sep 17 00:00:00 2001
From: Ben Pfaff <blp@nicira.com>
Date: Fri, 1 Jul 2011 10:13:35 -0700
Subject: [PATCH] bridge: Fix null pointer dereference.
If the netdev_open() fails then iface->netdev will be NULL and
iface_refresh_stats() will cause a null pointer dereference in
netdev_get_stats().
Fixes a problem introduced by commit 1101a0b47 "bridge: Populate interface
status/statistics as soon as a port is added."
Reported-by: Aaron Rosen <arosen@clemson.edu>
---
vswitchd/bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 93544032..446f4fc0 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -869,7 +869,7 @@ bridge_add_ofproto_ports(struct bridge *br)
}
/* Populate stats columns in new Interface rows. */
- if (!iface->cfg->mtu) {
+ if (iface->netdev && !iface->cfg->mtu) {
iface_refresh_stats(iface);
iface_refresh_status(iface);
}
--
2.30.2