From 2720633be76a46488e05bb9a0d45f24a89375065 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Sat, 26 Dec 2020 20:24:53 -0800 Subject: [PATCH] message-item: Fix reference counting in message_item_to_text_item(). This function should take ownership of the message_item passed in, but it leaked a reference to it. --- src/output/message-item.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/output/message-item.c b/src/output/message-item.c index c60d166779..ddfcc3f42e 100644 --- a/src/output/message-item.c +++ b/src/output/message-item.c @@ -48,8 +48,10 @@ message_item_get_msg (const struct message_item *item) struct text_item * message_item_to_text_item (struct message_item *message_item) { - return text_item_create_nocopy ( + struct text_item *text_item = text_item_create_nocopy ( TEXT_ITEM_LOG, msg_to_string (message_item_get_msg (message_item))); + message_item_unref (message_item); + return text_item; } static void -- 2.30.2