From 2175540274b68b10a9368e2c751f79e6d387baed Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Wed, 10 Feb 2010 16:53:40 -0800 Subject: [PATCH] datapath: When adding a port, return the new port number to userspace. 'port' is a kernel-space copy of the odp_port and modifying it is useless. 'portp' is the userspace copy; modifying it is useful. None of our current userspace users care about the port number and so we never noticed. Found by sparse (http://sparse.wiki.kernel.org/). --- datapath/datapath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index ba363fb7..94f31969 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -422,7 +422,7 @@ got_port_no: dp_sysfs_add_if(dp->ports[port_no]); - err = __put_user(port_no, &port.port); + err = __put_user(port_no, &portp->port); out_put: dev_put(dev); -- 2.30.2