From 20921a454b4e10f27ca4ccfef811f5b482911b49 Mon Sep 17 00:00:00 2001 From: John Darrington Date: Fri, 12 Aug 2016 06:53:35 +0200 Subject: [PATCH] Fix potential null pointer dereference Found by cppcheck --- src/ui/gui/psppire-dict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ui/gui/psppire-dict.c b/src/ui/gui/psppire-dict.c index b88bbe7766..0ee608cade 100644 --- a/src/ui/gui/psppire-dict.c +++ b/src/ui/gui/psppire-dict.c @@ -680,11 +680,11 @@ tree_model_iter_next (GtkTreeModel *model, GtkTreeIter *iter) struct variable *var; gint idx; - g_return_val_if_fail (iter->stamp == dict->stamp, FALSE); - if ( iter == NULL || iter->user_data == NULL) return FALSE; + g_return_val_if_fail (iter->stamp == dict->stamp, FALSE); + var = iter->user_data; idx = var_get_dict_index (var); -- 2.30.2