From 1a528fdab462b59506d56b3d20c5c96455f5e561 Mon Sep 17 00:00:00 2001 From: John Darrington Date: Sat, 29 Aug 2015 14:42:29 +0200 Subject: [PATCH] Don't bother freeing import dialog memory. Thus avoid crashes. A number of users have complained that the import dialog assistant crashes on exit. This seems to be because some callback is accessing the data after it has been freed. This change "fixes" that by simply not ever freeing the data. This will cause a memory leak. However during my investigations, I have found that this dialog leaks so much anyway that these few bytes are hardly significant. A proper fix will hopefully be forthcoming. Affects bug #45805 --- src/ui/gui/text-data-import-dialog.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/ui/gui/text-data-import-dialog.c b/src/ui/gui/text-data-import-dialog.c index 1527028c28..34127492fa 100644 --- a/src/ui/gui/text-data-import-dialog.c +++ b/src/ui/gui/text-data-import-dialog.c @@ -138,10 +138,6 @@ text_data_import_assistant (PsppireDataWindow *dw) destroy_formats_page (ia); destroy_separators_page (ia); } - - destroy_assistant (ia); - destroy_file (ia); - free (ia); } /* Emits PSPP syntax to S that applies the dictionary attributes -- 2.30.2