From 1611cf3f5abbff87b4443d2807b369fdd327eb49 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Wed, 23 Feb 2011 13:05:25 -0800 Subject: [PATCH] ovs-vsctl: Clarify that uuid_from_string() shouldn't fail in post_create(). Coverity #10701. --- utilities/ovs-vsctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index 3a14f713..4435f41d 100644 --- a/utilities/ovs-vsctl.c +++ b/utilities/ovs-vsctl.c @@ -3127,7 +3127,9 @@ post_create(struct vsctl_context *ctx) const struct uuid *real; struct uuid dummy; - uuid_from_string(&dummy, ds_cstr(&ctx->output)); + if (!uuid_from_string(&dummy, ds_cstr(&ctx->output))) { + NOT_REACHED(); + } real = ovsdb_idl_txn_get_insert_uuid(ctx->txn, &dummy); if (real) { ds_clear(&ctx->output); -- 2.30.2