From 13b89dbfbb8d158de86f9bef5e45889ce47f0fd5 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Sat, 18 Jun 2011 18:32:53 +0200 Subject: [PATCH] getloadavg: Don't clobber LIBS. Regression from previous commit. * m4/getloadavg.m4 (gl_PREREQ_GETLOADAVG): Move tests that use AC_CHECK_LIB from here... (gl_GETLOADAVG): ... to here, inside the experiment with LIBS. (gl_GETLOADAVG, gl_PREREQ_GETLOADAVG): Rename gl_have_func to gl_func_getloadavg_done. Reported by Tom G. Christensen . --- ChangeLog | 10 ++++++++ m4/getloadavg.m4 | 64 ++++++++++++++++++++++++------------------------ 2 files changed, 42 insertions(+), 32 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6e4a01655e..42588b4f71 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2011-06-18 Bruno Haible + + getloadavg: Don't clobber LIBS. Regression from previous commit. + * m4/getloadavg.m4 (gl_PREREQ_GETLOADAVG): Move tests that use + AC_CHECK_LIB from here... + (gl_GETLOADAVG): ... to here, inside the experiment with LIBS. + (gl_GETLOADAVG, gl_PREREQ_GETLOADAVG): Rename gl_have_func to + gl_func_getloadavg_done. + Reported by Tom G. Christensen . + 2011-06-18 Bruno Haible clean-temp: Improve documentation. diff --git a/m4/getloadavg.m4 b/m4/getloadavg.m4 index 967dfd797f..b75e05fa05 100644 --- a/m4/getloadavg.m4 +++ b/m4/getloadavg.m4 @@ -26,34 +26,51 @@ gl_save_LIBS=$LIBS # NetBSD >= 0.9, OpenBSD >= 2.0, Solaris >= 7. HAVE_GETLOADAVG=1 AC_CHECK_FUNC([getloadavg], [], - [gl_have_func=no + [gl_func_getloadavg_done=no # Some systems with -lutil have (and need) -lkvm as well, some do not. # On Solaris, -lkvm requires nlist from -lelf, so check that first # to get the right answer into the cache. # For kstat on solaris, we need to test for libelf and libkvm to force the # definition of SVR4 below. - if test $gl_have_func = no; then + if test $gl_func_getloadavg_done = no; then AC_CHECK_LIB([elf], [elf_begin], [LIBS="-lelf $LIBS"]) AC_CHECK_LIB([kvm], [kvm_open], [LIBS="-lkvm $LIBS"]) # Check for the 4.4BSD definition of getloadavg. AC_CHECK_LIB([util], [getloadavg], - [LIBS="-lutil $LIBS" gl_have_func=yes]) + [LIBS="-lutil $LIBS" gl_func_getloadavg_done=yes]) fi - if test $gl_have_func = no; then + if test $gl_func_getloadavg_done = no; then # There is a commonly available library for RS/6000 AIX. # Since it is not a standard part of AIX, it might be installed locally. gl_getloadavg_LIBS=$LIBS LIBS="-L/usr/local/lib $LIBS" AC_CHECK_LIB([getloadavg], [getloadavg], - [LIBS="-lgetloadavg $LIBS" gl_have_func=yes], + [LIBS="-lgetloadavg $LIBS" gl_func_getloadavg_done=yes], [LIBS=$gl_getloadavg_LIBS]) fi # Set up the replacement function if necessary. - if test $gl_have_func = no; then + if test $gl_func_getloadavg_done = no; then HAVE_GETLOADAVG=0 + + # Solaris has libkstat which does not require root. + AC_CHECK_LIB([kstat], [kstat_open]) + test $ac_cv_lib_kstat_kstat_open = yes && gl_func_getloadavg_done=yes + + # AIX has libperfstat which does not require root + if test $gl_func_getloadavg_done = no; then + AC_CHECK_LIB([perfstat], [perfstat_cpu_total]) + test $ac_cv_lib_perfstat_perfstat_cpu_total = yes && gl_func_getloadavg_done=yes + fi + + if test $gl_func_getloadavg_done = no; then + AC_CHECK_HEADER([sys/dg_sys_info.h], + [gl_func_getloadavg_done=yes + AC_DEFINE([DGUX], [1], [Define to 1 for DGUX with .]) + AC_CHECK_LIB([dgc], [dg_sys_info])]) + fi fi]) if test "x$gl_save_LIBS" = x; then @@ -88,52 +105,35 @@ AC_DEFUN([gl_PREREQ_GETLOADAVG], [ # Figure out what our getloadavg.c needs. -# Solaris has libkstat which does not require root. -AC_CHECK_LIB([kstat], [kstat_open]) -test $ac_cv_lib_kstat_kstat_open = yes && gl_have_func=yes - # On HPUX9, an unprivileged user can get load averages this way. -if test $gl_have_func = no; then - AC_CHECK_FUNCS([pstat_getdynamic], [gl_have_func=yes]) -fi - -# AIX has libperfstat which does not require root -if test $gl_have_func = no; then - AC_CHECK_LIB([perfstat], [perfstat_cpu_total]) - test $ac_cv_lib_perfstat_perfstat_cpu_total = yes && gl_have_func=yes -fi - -if test $gl_have_func = no; then - AC_CHECK_HEADER([sys/dg_sys_info.h], - [gl_have_func=yes - AC_DEFINE([DGUX], [1], [Define to 1 for DGUX with .]) - AC_CHECK_LIB([dgc], [dg_sys_info])]) +if test $gl_func_getloadavg_done = no; then + AC_CHECK_FUNCS([pstat_getdynamic], [gl_func_getloadavg_done=yes]) fi # We cannot check for , because Solaris 2 does not use dwarf (it # uses stabs), but it is still SVR4. We cannot check for because # Irix 4.0.5F has the header but not the library. -if test $gl_have_func = no && test "$ac_cv_lib_elf_elf_begin" = yes \ +if test $gl_func_getloadavg_done = no && test "$ac_cv_lib_elf_elf_begin" = yes \ && test "$ac_cv_lib_kvm_kvm_open" = yes; then - gl_have_func=yes + gl_func_getloadavg_done=yes AC_DEFINE([SVR4], [1], [Define to 1 on System V Release 4.]) fi -if test $gl_have_func = no; then +if test $gl_func_getloadavg_done = no; then AC_CHECK_HEADER([inq_stats/cpustats.h], - [gl_have_func=yes + [gl_func_getloadavg_done=yes AC_DEFINE([UMAX], [1], [Define to 1 for Encore UMAX.]) AC_DEFINE([UMAX4_3], [1], [Define to 1 for Encore UMAX 4.3 that has instead of .])]) fi -if test $gl_have_func = no; then +if test $gl_func_getloadavg_done = no; then AC_CHECK_HEADER([sys/cpustats.h], - [gl_have_func=yes; AC_DEFINE([UMAX])]) + [gl_func_getloadavg_done=yes; AC_DEFINE([UMAX])]) fi -if test $gl_have_func = no; then +if test $gl_func_getloadavg_done = no; then AC_CHECK_HEADERS([mach/mach.h]) fi -- 2.30.2