Ben Pfaff [Sun, 17 Jan 2016 00:41:59 +0000 (16:41 -0800)]
Add documentation for SPV file format.
Ben Pfaff [Fri, 15 Jan 2016 15:49:33 +0000 (07:49 -0800)]
measure: Improve wording of error message.
Suggested by Elias Estatistics <estatisticseu@gmail.com>.
Ben Pfaff [Fri, 15 Jan 2016 15:47:45 +0000 (07:47 -0800)]
psppire-button-editable: Don't mark spec parameter text as translatable.
The P_ prefix seems to be used by other GTK+ code, so use it here too.
Reported by Elias Estatistics <estatisticseu@gmail.com>.
Ben Pfaff [Fri, 15 Jan 2016 14:35:00 +0000 (06:35 -0800)]
SAVE TRANSLATE: Improve error message.
Before this commit, "SAVE TRANSLATE OUTFILE='...'" gave a confusing error
message. After this commit, it clearly reports the missing slash before
OUTFILE.
Ben Pfaff [Fri, 15 Jan 2016 14:26:28 +0000 (06:26 -0800)]
LIST: Improve wording of error messages.
Suggested by Elias Estatistics <estatisticseu@gmail.com>.
John Darrington [Wed, 13 Jan 2016 08:31:42 +0000 (09:31 +0100)]
EXAMINE: Extend test for empty dataset and fix bug.
Closes bug #46866
John Darrington [Tue, 12 Jan 2016 11:22:37 +0000 (12:22 +0100)]
ONEWAY: fix crash in contrasts when dataset is empty
John Darrington [Mon, 11 Jan 2016 08:31:18 +0000 (09:31 +0100)]
Fixed some bugs related to empty parentheses
John Darrington [Mon, 11 Jan 2016 08:43:09 +0000 (09:43 +0100)]
Add some tests for empty parens
Ben Pfaff [Thu, 7 Jan 2016 16:44:13 +0000 (08:44 -0800)]
FACTOR: Avoid assertion failures on syntax errors expecting numbers.
Reported by Elias Estatistics.
Ben Pfaff [Wed, 6 Jan 2016 01:53:29 +0000 (17:53 -0800)]
psppire-var-view: Fix constness error.
Ben Pfaff [Wed, 6 Jan 2016 01:52:21 +0000 (17:52 -0800)]
Makefiles: Add $(AM_V_GEN) and $(AM_V_at) to a few more rules.
This makes the abbreviated "make" output more effective.
Ben Pfaff [Wed, 6 Jan 2016 01:47:35 +0000 (17:47 -0800)]
APPLY DICTIONARY: Fix segmentation fault when setting value labels.
Reported by Frans Houweling.
Ben Pfaff [Wed, 6 Jan 2016 01:45:37 +0000 (17:45 -0800)]
segment: Fix buffer overrun error in segmenter_detect_command_name__().
Found by valgrind.
John Darrington [Tue, 5 Jan 2016 07:19:12 +0000 (08:19 +0100)]
Scatter plot dialog: Correct order of variables in syntax generator
John Darrington [Tue, 5 Jan 2016 07:01:38 +0000 (08:01 +0100)]
.ui files: Bump version of required Gtk to 3.4.2
This is the same version currently required in configure.ac
John Darrington [Mon, 4 Jan 2016 19:43:35 +0000 (20:43 +0100)]
Logistic Regression Dialog: Add missing property
John Darrington [Mon, 4 Jan 2016 19:30:45 +0000 (20:30 +0100)]
Fix bad syntax generation introduced by previous commit.
Commit
cdfb21de2cbbf921b4e1fe0662439da1c460eabc replaced syntax_gen_pspp
with g_string_append_printf which was wrong, because the latter is
sensitive to the user's locale, which is not desired for syntax generation.
John Darrington [Mon, 4 Jan 2016 18:32:34 +0000 (19:32 +0100)]
Logistical Regression Dialog: Automatically mark appropriate variables as categorical
In the syntax generator ordinal, nominal or string variables are now marked as /CATEGORICAL
Closes bug #46749
John Darrington [Mon, 4 Jan 2016 16:15:42 +0000 (17:15 +0100)]
Logistic Regression Dialog: Reimplement syntax generator using GString
John Darrington [Mon, 4 Jan 2016 13:05:14 +0000 (14:05 +0100)]
"margin-left" -> "margin-start" && "margin-right" -> "margin-end"
These are the preferred property names on recent Gtk releases.
Ben Pfaff [Mon, 4 Jan 2016 04:12:29 +0000 (20:12 -0800)]
REGRESSION: Correctly handle data in temporary file for SAVE subcommand.
The format of the data in the temporary file used by the SAVE subcommand is
basically unrelated to the format of the data in the active file, but the
code that created and wrote cases to it created them as clones of cases
in the active file. This is simply incorrect behavior and causes nasty
failures when the active file has an inconvenient number of variables or
contains long string variables.
This commit fixes the problem by correctly creating the cases for the
temporary file using that file's own caseproto.
In addition, the assignment of caseproto indexes to variables in the
temporary file was broken for /SAVE=PRED, because it would skip index 0.
This commit also fixes that problem.
Bug #44877.
Reported by Scott.
John Darrington [Sun, 3 Jan 2016 10:00:50 +0000 (11:00 +0100)]
Syntax menu definition: Rename "menuitem7" to "edit-menu"
Ben Pfaff [Sun, 3 Jan 2016 18:28:04 +0000 (10:28 -0800)]
GET DATA /TYPE=TXT: Remove obsolete IMPORTCASES subcommand.
For compatibility.
Reported by Charles Johnson.
John Darrington [Wed, 30 Dec 2015 08:53:20 +0000 (09:53 +0100)]
Rename Dataset dialog: Add spacing and help button
Ben Pfaff [Sun, 3 Jan 2016 06:28:12 +0000 (22:28 -0800)]
REGRESSION: Warn when REGRESSION with SAVE runs with a filter configured.
Reported by elias tsolis.
Bug #46727.
Ben Pfaff [Sun, 3 Jan 2016 06:05:00 +0000 (22:05 -0800)]
val-labs-dialog: Improve keyboard interface.
Before, hitting Enter in the value label dialog did nothing. With this
commit, Enter in the value entry moves to the label entry, and Enter in
the label entry adds or changes the value label and jumps back to the
value entry.
Requested by dr soumalya ray.
Ben Pfaff [Sun, 3 Jan 2016 05:34:13 +0000 (21:34 -0800)]
QUICK CLUSTER: Correct typo in documentation of PRINT subcommand.
The PRINT subcommand has a setting CLUSTER (not CLUSTERS).
Reported by Andy King.
Fix from Alan Mead.
Ben Pfaff [Sun, 3 Jan 2016 04:44:22 +0000 (20:44 -0800)]
sys-file-reader: Disallow system and scratch long variable names too.
Before this commit, the system file reader disallowed system and
scratch short variable names (e.g. names beginning with $ or #)
but not as long variable names. This fixes the problem.
Bug #46783.
Ben Pfaff [Sun, 3 Jan 2016 04:42:41 +0000 (20:42 -0800)]
RANK: Issue syntax error in case where it was omitted before.
Bug #46783.
Ben Pfaff [Sun, 3 Jan 2016 04:19:32 +0000 (20:19 -0800)]
LIST: Allow a subset of the CASES settings to be specified.
The LIST documentation said that any subset of the FROM, TO, and BY
settings could be used on the CASES subcommand, but until now the command
as implemented required all of them to be present. This commit fixes
the implementation.
Also updates the documentation to reflect the current implementation.
Ben Pfaff [Sun, 3 Jan 2016 04:18:29 +0000 (20:18 -0800)]
psppire-dialog-action: Fix compilation error.
John Darrington [Thu, 31 Dec 2015 13:59:49 +0000 (14:59 +0100)]
Select Cases Dialog: Convert to PsppireDialogAction
John Darrington [Wed, 30 Dec 2015 07:38:40 +0000 (08:38 +0100)]
Select Cases Dialog: minor refactor.
Encapsulate pointers to widgets in the dialog structure instead of retreiving
them from the GtkBuilder on each usage.
John Darrington [Tue, 29 Dec 2015 17:02:24 +0000 (18:02 +0100)]
Rearange widget registration into a table.
I think this will make things easier with Gtk3
John Darrington [Tue, 29 Dec 2015 14:17:21 +0000 (15:17 +0100)]
Split File Dialog: Convert to PsppireDialogAction
John Darrington [Tue, 29 Dec 2015 12:17:13 +0000 (13:17 +0100)]
Add an appropriate help page for the Variable Info dialog box
John Darrington [Tue, 29 Dec 2015 11:33:02 +0000 (12:33 +0100)]
examples/physiology.sav: Add a DOCUMENT comment to explain that the file contains "deliberate" data entry errors.
Occasionally this is the subject of bug reports.
John Darrington [Tue, 29 Dec 2015 11:31:46 +0000 (12:31 +0100)]
Comments dialog: convert to PsppireDialogAction
John Darrington [Tue, 29 Dec 2015 10:00:01 +0000 (11:00 +0100)]
Weight cases dialog: Convert from add hoc to PsppireDialogAction
John Darrington [Mon, 28 Dec 2015 11:26:43 +0000 (12:26 +0100)]
PsppireKeypad: Correct the attachment of buttons to the grid.
This buglet appears to have crept in during the GtkTable -> GtkGrid transition.
John Darrington [Sun, 27 Dec 2015 09:10:49 +0000 (10:10 +0100)]
Change some instances of GtkAction to PsppireDialogAction
John Darrington [Sat, 26 Dec 2015 10:15:15 +0000 (11:15 +0100)]
Rewrite Import Dialog.
This is a major rewrite of the text/spreadsheet import assistant.
Hopefully there are less bugs and it will be easier to maintain.
John Darrington [Tue, 22 Dec 2015 23:10:24 +0000 (00:10 +0100)]
Whitespace changes only
John Darrington [Tue, 22 Dec 2015 23:08:01 +0000 (00:08 +0100)]
Remove deprecated widgets
John Darrington [Tue, 22 Dec 2015 19:26:09 +0000 (20:26 +0100)]
Remove stray quotation marks and angle brackets
John Darrington [Mon, 21 Dec 2015 09:58:51 +0000 (10:58 +0100)]
Improved the autoconf test for xmllint
John Darrington [Thu, 17 Dec 2015 06:16:58 +0000 (07:16 +0100)]
Remove string stat_version
This string contained a timestamp indicating when ./configure had
been run. This makes for reproducibility issues and possibly
privacy issues too.
John Darrington [Wed, 16 Dec 2015 07:32:56 +0000 (08:32 +0100)]
Autorecode Dialog: Convert from add hoc to PsppireDialogAction
Friedrich Beckmann [Tue, 15 Dec 2015 23:35:11 +0000 (00:35 +0100)]
GRAPH scatterplot - fixed missing BY variable rendering
scatterplot with GRAPH /SCATTERPLOT x WITH y BY z did not use the by z
grouping of the cases. This patch fixes this.
John Darrington [Tue, 15 Dec 2015 17:08:05 +0000 (18:08 +0100)]
PsppSheetViewColumn: Replace some deprecated functions
John Darrington [Tue, 15 Dec 2015 11:31:06 +0000 (12:31 +0100)]
PsppSheetViewColumn: Replace GtkAlignment with a GtkBin
GtkAlignment is deprecated
John Darrington [Tue, 15 Dec 2015 06:43:21 +0000 (07:43 +0100)]
PsppSheetViewColumn: Remove GtkArrow
This widget is deprecated and we don't use this feature anyway.
John Darrington [Tue, 15 Dec 2015 19:34:35 +0000 (20:34 +0100)]
Recode Dialog: Remove deprecated widgets
John Darrington [Mon, 14 Dec 2015 10:42:26 +0000 (11:42 +0100)]
Fix crash calling RINDEX with a zero needle length
Also add a test and correct the documentation.
John Darrington [Mon, 14 Dec 2015 15:26:48 +0000 (16:26 +0100)]
Kolmogorov Smironov Dialog: Add help_page property
John Darrington [Sun, 13 Dec 2015 15:13:28 +0000 (16:13 +0100)]
Fix compiler warnings
John Darrington [Sun, 13 Dec 2015 14:03:25 +0000 (15:03 +0100)]
Select Cases Dialog: Replace obsolete widgets
John Darrington [Sun, 13 Dec 2015 13:06:45 +0000 (14:06 +0100)]
PsppireSheetView: Remove code marked with GTK3_TRANSITION
John Darrington [Sat, 12 Dec 2015 14:26:31 +0000 (15:26 +0100)]
Documentation add subsections for each GRAPH type
John Darrington [Sat, 12 Dec 2015 13:03:37 +0000 (14:03 +0100)]
Aggregate Dialog: Convert from old fashioned method to PsppireDialogAction paradigm
John Darrington [Fri, 11 Dec 2015 07:18:20 +0000 (08:18 +0100)]
Rename psppire_dialog_action_get_pointer -> psppire_dialog_action_get_hash_table
Also add a comment explaining what it is for.
Friedrich Beckmann [Fri, 11 Dec 2015 15:54:51 +0000 (16:54 +0100)]
changed a character in po/pl.po that was reported as illegal in sed on MacOS
build failed on MacOS because sed complained about an illegal character
in the po file. The build failed after the introduction of the sed script
that removes the build time stamp.
John Darrington [Thu, 10 Dec 2015 11:13:11 +0000 (12:13 +0100)]
Replace "sed" with "$(SED)" in Makefiles
John Darrington [Thu, 10 Dec 2015 10:51:08 +0000 (11:51 +0100)]
Make rule for src/libpspp/version.c atomic
This rule could have resulted in a half constructed target if it failed
half way through for any reason. Now it is all or nothing.
John Darrington [Wed, 9 Dec 2015 07:14:56 +0000 (08:14 +0100)]
Compute dialog: Avoid double population
John Darrington [Wed, 9 Dec 2015 06:47:18 +0000 (07:47 +0100)]
Fix generate-changelog rule when building from outside of the source repository
The "make dist" target depends upon a phony target "generate-changelog" which
generates the ChangeLog file. Unfortunately, this was failing if the current
directory was not the source directory. Worse, this failure was not detected,
but would erroneously generate an empty ChangeLog.
This change fixes both these problems.
John Darrington [Tue, 8 Dec 2015 20:23:36 +0000 (21:23 +0100)]
Aggregate Dialog: Replace deprecated widgets
John Darrington [Tue, 8 Dec 2015 17:54:44 +0000 (18:54 +0100)]
Compute Dialog: Replace deprecated widgets
John Darrington [Tue, 8 Dec 2015 14:56:13 +0000 (15:56 +0100)]
Fix generation of help-pages-list file
John Darrington [Tue, 8 Dec 2015 12:41:09 +0000 (13:41 +0100)]
Update selector widgets on dialog activation.
When a dialog is activated, call update_subjects on
any PsppireSelector widgets that the dialog contains.
This ensures that the subjects (typically lists of
variables) are in a consistent state if the dialog
is reactivated after having changed a list.
John Darrington [Tue, 8 Dec 2015 07:44:23 +0000 (08:44 +0100)]
Fix minor grammatical error in documentation
John Darrington [Tue, 8 Dec 2015 06:56:11 +0000 (07:56 +0100)]
Remove POT-Creation-Date from pspp.pot and from .po files
The modern trend is in favour of byte-for-byte reproducible
builds. The use of timestamps in generated files breaks this.
John Darrington [Mon, 7 Dec 2015 22:17:04 +0000 (23:17 +0100)]
T-Test Dialog: remove deprecated widgets
John Darrington [Mon, 7 Dec 2015 21:37:09 +0000 (22:37 +0100)]
Weight Dialog: Cosmetic improvements
John Darrington [Mon, 7 Dec 2015 21:16:53 +0000 (22:16 +0100)]
Barchart Dialog: Cosmetic improvements
John Darrington [Mon, 7 Dec 2015 21:08:14 +0000 (22:08 +0100)]
Paired Samples Dialog: Fix broken logic
John Darrington [Mon, 7 Dec 2015 20:09:35 +0000 (21:09 +0100)]
Chi Square Dialog: Cosmetic improvements
John Darrington [Mon, 7 Dec 2015 19:53:49 +0000 (20:53 +0100)]
Transpose Dialog: Add margin
John Darrington [Mon, 7 Dec 2015 18:52:54 +0000 (19:52 +0100)]
Crosstabs Dialog: Avoid populating dialog more than once
John Darrington [Mon, 7 Dec 2015 18:44:21 +0000 (19:44 +0100)]
Factor Dialog: Avoid populating dialog more than once
John Darrington [Mon, 7 Dec 2015 18:40:34 +0000 (19:40 +0100)]
K Means Dialog: Correct order of widgets
John Darrington [Mon, 7 Dec 2015 18:16:15 +0000 (19:16 +0100)]
Barchart Dialog: Avoid initialising multiple times
John Darrington [Mon, 7 Dec 2015 18:04:00 +0000 (19:04 +0100)]
Frequencies Dialog: Avoid initialising things more than once per dialog
John Darrington [Mon, 7 Dec 2015 17:25:29 +0000 (18:25 +0100)]
Fix bug rendering margin in output viewer.
commit
7b1373b8bded55eedc2328c1afd3eece6d259c34 tried to add an
offset to the output viewer rendering. However the implementation
was somewhat naive. The result was that the desired rendering was
not observed until an expose or resize event occured. This change
improves the implementation.
John Darrington [Mon, 7 Dec 2015 15:21:52 +0000 (16:21 +0100)]
Descriptives Dialog: Avoid multiple appendages to the statistics list box
John Darrington [Mon, 7 Dec 2015 15:14:11 +0000 (16:14 +0100)]
Remove destroy signal handler for dialogs.
Now (since the dialog persistance feature) dialog boxes survive their associated datasets,
it is no longer necessary or desireable for the destroy callback to remove the notification
callback.
John Darrington [Sun, 6 Dec 2015 21:18:03 +0000 (22:18 +0100)]
Autorecode Dialog: replace deprecated widgets
John Darrington [Sun, 6 Dec 2015 20:55:38 +0000 (21:55 +0100)]
Missing Values Dialog: replace deprecated widgets
John Darrington [Sun, 6 Dec 2015 20:33:38 +0000 (21:33 +0100)]
examples/repairs.sav: Update sav file version
The repairs.sav example provoked a warning when loaded. This change replaces it with a version
which does not.
John Darrington [Sun, 6 Dec 2015 20:01:17 +0000 (21:01 +0100)]
Kolmogorov Smirnof One Sample Dialog: replace deprecated widgets
John Darrington [Sun, 6 Dec 2015 19:42:30 +0000 (20:42 +0100)]
Chi Square Dialog: Replace deprecated widgets
John Darrington [Sun, 6 Dec 2015 19:00:15 +0000 (20:00 +0100)]
Variable Type Dialog: Replace deprecated widgets
John Darrington [Sun, 6 Dec 2015 18:45:47 +0000 (19:45 +0100)]
Means Dialog: Replace deprecated widgets
John Darrington [Sun, 6 Dec 2015 18:26:07 +0000 (19:26 +0100)]
Univariate Dialog: replace deprecated widgets
John Darrington [Sun, 6 Dec 2015 15:05:45 +0000 (16:05 +0100)]
Count Dialog: Replace deprecated widgets
John Darrington [Sun, 6 Dec 2015 14:42:35 +0000 (15:42 +0100)]
Rank Dialog: Replace deprecated widgets
John Darrington [Sun, 6 Dec 2015 14:23:39 +0000 (15:23 +0100)]
Runs Dialog: Replace deprecated widgets
John Darrington [Sun, 6 Dec 2015 14:07:32 +0000 (15:07 +0100)]
Split File Dialog: Remove deprecated widgets
John Darrington [Sun, 6 Dec 2015 12:01:23 +0000 (13:01 +0100)]
Independent Samples Dialog: Remove GtkAlignment widgets