Ben Pfaff [Tue, 15 Dec 2020 07:13:11 +0000 (23:13 -0800)]
font resolution works!
Ben Pfaff [Mon, 14 Dec 2020 08:00:09 +0000 (00:00 -0800)]
pango fucking cairo resolution!
Ben Pfaff [Mon, 14 Dec 2020 07:43:03 +0000 (23:43 -0800)]
printing works; font sizes are weird
Ben Pfaff [Mon, 14 Dec 2020 05:27:49 +0000 (21:27 -0800)]
Refactoring.
Ben Pfaff [Sat, 12 Dec 2020 07:20:56 +0000 (23:20 -0800)]
cairo output works again
Ben Pfaff [Wed, 9 Dec 2020 17:34:10 +0000 (09:34 -0800)]
cairo: Use arrays for page sizes and margins, to simplify code.
Ben Pfaff [Mon, 7 Dec 2020 06:06:57 +0000 (22:06 -0800)]
cairo: Move chart code into cairo-chart.
Ben Pfaff [Mon, 7 Dec 2020 05:50:59 +0000 (21:50 -0800)]
cairo: Get rid of unused PangoLayouts.
Ben Pfaff [Mon, 7 Dec 2020 05:14:18 +0000 (21:14 -0800)]
cairo: Remove unneeded code.
Ben Pfaff [Mon, 7 Dec 2020 04:07:56 +0000 (20:07 -0800)]
Revert "something odd with extra-large fixed font in output"
This reverts commit
39891174310b92424353a45044c67301ee16da1e.
Ben Pfaff [Mon, 7 Dec 2020 04:07:47 +0000 (20:07 -0800)]
something odd with extra-large fixed font in export and print output
Ben Pfaff [Mon, 7 Dec 2020 03:40:39 +0000 (19:40 -0800)]
cairo: Get rid of xr_render_fsm.
Ben Pfaff [Mon, 7 Dec 2020 03:25:11 +0000 (19:25 -0800)]
Ben Pfaff [Mon, 7 Dec 2020 03:25:07 +0000 (19:25 -0800)]
work
Ben Pfaff [Sun, 6 Dec 2020 22:18:26 +0000 (14:18 -0800)]
cairo: Factor out code for basic rendering.
Ben Pfaff [Sun, 6 Dec 2020 22:18:15 +0000 (14:18 -0800)]
render: Add comment.
Ben Pfaff [Sun, 6 Dec 2020 21:33:00 +0000 (13:33 -0800)]
cairo: Remove "emphasis" font option because it had no real effect.
Ben Pfaff [Sun, 6 Dec 2020 21:08:34 +0000 (13:08 -0800)]
render: Make struct render_params a little smaller.
This factors out pieces that currently in practice are always the same for
a particular driver.
Ben Pfaff [Sun, 6 Dec 2020 21:08:24 +0000 (13:08 -0800)]
page-eject-item: Factor out of text_item.
These really don't have much in common.
Ben Pfaff [Sun, 6 Dec 2020 21:05:41 +0000 (13:05 -0800)]
output: Fix typos in copyright notices.
Ben Pfaff [Sun, 6 Dec 2020 01:35:24 +0000 (17:35 -0800)]
cairo: Drop unused line_spacing, line_width members from xr_driver.
Ben Pfaff [Sun, 6 Dec 2020 01:07:12 +0000 (17:07 -0800)]
psppire-output-view: Consistently apply "transparent" and "systemcolors".
Commit
81dece3642da ("output view: make items selectable and use system
colours") add transparency and system colors to the driver in the GUI,
but it did so somewhat after the driver was created. I don't know why.
It makes more sense to me to set these options when creating the driver.
This commit makes that change. It also deletes the function to change
the options; it had no other user.
Ben Pfaff [Sun, 13 Dec 2020 19:24:22 +0000 (11:24 -0800)]
psppire-dialog-action-crosstabs: Mention Cramer's V along with Phi.
Asking for Phi already produced Cramer's V also, but the label didn't
indicate that. This just updates the label.
Bug #59670.
Ben Pfaff [Sat, 5 Dec 2020 06:53:03 +0000 (22:53 -0800)]
output: Move parse_color() from cairo.c to options.c.
Seems like a more natural place for it.
Ben Pfaff [Sat, 5 Dec 2020 06:53:28 +0000 (22:53 -0800)]
options: Fix error message for parsing chart file names.
Ben Pfaff [Mon, 30 Nov 2020 06:50:27 +0000 (22:50 -0800)]
cairo: Remove 'x' from struct xr_driver.
It always had value 0.
Ben Pfaff [Mon, 30 Nov 2020 04:40:09 +0000 (20:40 -0800)]
cairo: Remove 'heading_vars' from struct xr_driver.
This was accessed in a few places but they didn't have any visible effects
on behavior.
Ben Pfaff [Mon, 30 Nov 2020 04:39:25 +0000 (20:39 -0800)]
cairo: Remove unused 'command_name', 'title', 'subtitle' from xr_driver.
These really weren't used anywhere.
Ben Pfaff [Mon, 30 Nov 2020 04:32:54 +0000 (20:32 -0800)]
cairo: Remove obsolete 'nest' member from struct xr_driver.
Commit
a8799bb1d22a ("output: Remove support for nested tables.")
removed the real users for this member but didn't remove the member
itself or two unneeded uses of it.
Ben Pfaff [Sat, 28 Nov 2020 04:00:35 +0000 (20:00 -0800)]
cairo: Simplify and modernize xr_create().
Move common code from callers into xr_create(), and initialize variables at
point of creation.
John Darrington [Sat, 28 Nov 2020 20:44:56 +0000 (21:44 +0100)]
Documentation: Add the generated screenshots to the git repository
John Darrington [Sat, 28 Nov 2020 20:32:24 +0000 (21:32 +0100)]
Documentation: Add some screenshots to the user manual.
Added a mechanism to automatically generate screenshots from the
graphic user interface for inclusion in the manual.
John Darrington [Sat, 28 Nov 2020 13:07:29 +0000 (14:07 +0100)]
doc/variables.texi: Rearrange sections into a more logical reading order.
John Darrington [Sat, 28 Nov 2020 10:50:39 +0000 (11:50 +0100)]
Documentation: Add an example for SORT CASES
John Darrington [Sat, 28 Nov 2020 10:29:43 +0000 (11:29 +0100)]
Documentation: Add an example showing how AGGREGATE works
John Darrington [Sat, 28 Nov 2020 10:22:41 +0000 (11:22 +0100)]
Documentation: Add an example showing the use of SELECT IF.
John Darrington [Sat, 28 Nov 2020 10:11:11 +0000 (11:11 +0100)]
Documentation: New example for the temporary command
Ben Pfaff [Sat, 28 Nov 2020 02:56:35 +0000 (18:56 -0800)]
doc: Make figure references relative to doc/, not to doc/pspp-figures.
This frame of reference is what the viewers for the generated XML and Info
files expect (from testing). It also seems to be what the Makefile expects
since this allows us to eliminate a couple of include directory options.
Ben Pfaff [Sat, 28 Nov 2020 02:23:59 +0000 (18:23 -0800)]
doc: Use $(convert) variable consistently.
Apparently I introduced this halfway.
Ben Pfaff [Sat, 28 Nov 2020 02:21:44 +0000 (18:21 -0800)]
doc: Be consistent about plurals in figure target and variable names.
Before this commit, "txt" and "texi" used plural forms, "html" and "pdf"
used singular, and "spv" was mixed (!). This consistently uses the plural.
Ben Pfaff [Fri, 27 Nov 2020 23:38:07 +0000 (15:38 -0800)]
doc: Move output examples from "examples" to "pspp-figures".
The Texinfo manual suggests this convention:
If you want to install image files for use by Info readers too, we
recommend putting them in a subdirectory like 'FOO-figures' for a
package FOO. Copying the files into '$(infodir)/FOO-figures/' should be
done in your 'Makefile'.
Although it suggests this convention for the installed Info, it helps to
use the convention for the source and build directories, because "makeinfo"
looks for the files at Info build time.
Ben Pfaff [Fri, 27 Nov 2020 22:58:22 +0000 (14:58 -0800)]
Makefile: Fix spelling of "prerequisites".
Ben Pfaff [Fri, 27 Nov 2020 23:05:55 +0000 (15:05 -0800)]
src/libpspp/Makefile.am: Fix atomicity of version.c generation.
If the Makefile has a bug, or someone runs two "make"s in parallel, the
approach of truncating version.c then appending to it line by line,
reopening the file each time, can wind up with a nasty partial result. By
generating it in a single go, and then replacing the file atomically, we
avoid that problem.
John Darrington [Tue, 17 Nov 2020 17:27:38 +0000 (18:27 +0100)]
src/ui/gui/psppire-import-textfile.c: Fix compiler warnings
John Darrington [Tue, 17 Nov 2020 17:27:38 +0000 (18:27 +0100)]
Only reset the separators page when going forwards
John Darrington [Tue, 17 Nov 2020 17:27:38 +0000 (18:27 +0100)]
Fix on_quote_combo_change callback
John Darrington [Tue, 17 Nov 2020 17:27:38 +0000 (18:27 +0100)]
Remove diagnostic
John Darrington [Tue, 17 Nov 2020 17:27:38 +0000 (18:27 +0100)]
src/data/dictionary.c (make_hinted_name): Limit generated name to 64 bytes long
John Darrington [Tue, 17 Nov 2020 17:27:38 +0000 (18:27 +0100)]
Move syntax generation to the psppire-import-textfile module
John Darrington [Sun, 15 Nov 2020 14:33:16 +0000 (15:33 +0100)]
Partial revert "work on getting better output into documentation"
This change reverts part of commit
543a4fc802d42256c8f7b950580343fa81370f73
which I think was committed in error.
Friedrich Beckmann [Mon, 16 Nov 2020 20:35:00 +0000 (21:35 +0100)]
windows: EXEEXT was at wrong place
The EXEXT must only be in the dependency but not in the executable.
Ben Pfaff [Mon, 16 Nov 2020 18:13:21 +0000 (10:13 -0800)]
svg2png: Speed up gimp startup with -d option.
This option prevents gimp from loading patterns, gradients, palettes,
and brushes. I think that these are mostly for interactive use. I didn't
see any difference in output quality.
On my system this sped up "make -f Smake -j128 icons" from 1.8 to 1.6
seconds. On other systems I guess it will make a bigger difference.
Ben Pfaff [Mon, 16 Nov 2020 17:58:24 +0000 (09:58 -0800)]
Smake: Clean icons from "clean" target and add clean-icons target.
Ben Pfaff [Fri, 13 Nov 2020 16:45:45 +0000 (08:45 -0800)]
work on getting better output into documentation
John Darrington [Mon, 16 Nov 2020 17:07:17 +0000 (18:07 +0100)]
doc/automake.mk: Re-instate html-local as a dummy rule
commit
a58b271cad7e72bc5f2c0e8f7e98fadc27759089 removed the html-local
rule, but did not remove all references to it. I'm intending to use
this rule again for upcoming changes. In the meantime I'm re-instating
it as a rule which does nothing.
Friedrich Beckmann [Sun, 15 Nov 2020 23:02:07 +0000 (00:02 +0100)]
MacOS: wc does not support -L option
The default wc application on MacOS does not support the -L option. I added
autotools support to search for GNU wc and use that instead. This assumes
that the application name is gwc which is the case whan using macports.
The tex tests use wc with the -L option. These regression tests fail on MacOS if the default wc application is used.
Friedrich Beckmann [Sun, 15 Nov 2020 08:15:13 +0000 (09:15 +0100)]
check gcc version before using gnu_printf attribute
The MacOS clang compiler does not know the gnu_printf attribute.
gnu_printf was introduced with gcc version 4.4 so I check the
gcc version before using gnu_printf. Otherwise I fallback to the
previous __printf__ attribute.
Friedrich Beckmann [Sat, 14 Nov 2020 22:33:04 +0000 (23:33 +0100)]
automake: added EXEEXT for windows support
The make process fails when the excutable is called pspp on windows. I
added the EXEEXT such that pspp.exe is the target on Windows.
John Darrington [Sat, 14 Nov 2020 06:52:43 +0000 (07:52 +0100)]
Fix leak in perl module
Ben Pfaff [Fri, 13 Nov 2020 16:53:47 +0000 (08:53 -0800)]
Fix parsing of some more .tlo files.
Ben Pfaff [Mon, 9 Nov 2020 02:29:49 +0000 (18:29 -0800)]
Add support for .tlo TableLook files from SPSS 15 and earlier.
John Darrington [Sat, 7 Nov 2020 08:11:13 +0000 (09:11 +0100)]
New function: xr_draw_eps_chart
John Darrington [Sun, 1 Nov 2020 07:48:30 +0000 (08:48 +0100)]
TeX driver: Add some REVERSED glyphs
John Darrington [Sun, 1 Nov 2020 18:46:37 +0000 (19:46 +0100)]
TeX driver: Use the glyphs from wasyfont instead of rolling our own
John Darrington [Sun, 1 Nov 2020 11:19:32 +0000 (12:19 +0100)]
doc/automake.mk: Simplify conversion rules
John Darrington [Sun, 1 Nov 2020 10:58:09 +0000 (11:58 +0100)]
doc/automake.mk: Remove comment which is no longer appropriate
Ben Pfaff [Tue, 3 Nov 2020 07:09:13 +0000 (23:09 -0800)]
spv-table-look: Don't use user-provided text as format string.
Thanks to Mindaugus for reporting this issue.
John Darrington [Sat, 31 Oct 2020 08:24:16 +0000 (09:24 +0100)]
Fix oneway bug and add a test
Reported-by: Arbe Kablau
John Darrington [Sun, 25 Oct 2020 07:51:00 +0000 (08:51 +0100)]
User manual: Add 2020 to copyright date
John Darrington [Sun, 25 Oct 2020 17:26:42 +0000 (18:26 +0100)]
User manual: kg -> kilogram
John Darrington [Sun, 25 Oct 2020 17:26:15 +0000 (18:26 +0100)]
User manual: Mention TeX in the list of supported output formats
John Darrington [Sun, 25 Oct 2020 07:38:52 +0000 (08:38 +0100)]
User manual: Move some sentances out of the future tense.
John Darrington [Sun, 25 Oct 2020 20:33:52 +0000 (21:33 +0100)]
User manual: filename -> file name
The GNU Coding Standards prescribe this.
John Darrington [Sun, 25 Oct 2020 07:41:59 +0000 (08:41 +0100)]
User manual: Use italic typeface for latin abbreviations
Ben Pfaff [Fri, 30 Oct 2020 07:02:43 +0000 (00:02 -0700)]
output: Break struct pivot_table_look out of struct pivot_table.
Ben Pfaff [Fri, 30 Oct 2020 06:11:59 +0000 (23:11 -0700)]
table: Rename area_style to table_area_style for consistency.
Other, similarly situated data structures have a table_ prefix.
Ben Pfaff [Thu, 29 Oct 2020 06:01:12 +0000 (23:01 -0700)]
doc: Use --css-ref option to makeinfo, instead of postprocessing with sed.
This option was introduced with makeinfo 4.11, released in 2007, so it
should be widely available.
Ben Pfaff [Thu, 29 Oct 2020 05:55:10 +0000 (22:55 -0700)]
render: Fix rendering of backgrounds in middle- or bottom-justified cells.
Ben Pfaff [Thu, 29 Oct 2020 05:40:10 +0000 (22:40 -0700)]
output: New HTML driver option "bare".
Ben Pfaff [Thu, 29 Oct 2020 05:30:43 +0000 (22:30 -0700)]
pspp-output: New command get-table-look.
Ben Pfaff [Thu, 29 Oct 2020 05:29:40 +0000 (22:29 -0700)]
spv: Support underlining in table styles.
Ben Pfaff [Tue, 27 Oct 2020 02:38:03 +0000 (19:38 -0700)]
help-menu: Avoid const-ness warnings on Mingw.
Ben Pfaff [Tue, 27 Oct 2020 02:36:51 +0000 (19:36 -0700)]
psppire-window: Use "long int" for %ld.
Found on mingw.
Ben Pfaff [Tue, 27 Oct 2020 02:36:08 +0000 (19:36 -0700)]
spv: Avoid some compiler warnings on mingw.
The mingw compiler warned about these, and it's harmless to avoid them.
Ben Pfaff [Tue, 27 Oct 2020 02:35:09 +0000 (19:35 -0700)]
Use gnu_printf in attribute(()) to indicate GNU printf extension support.
By writing ordinary printf (or __printf__) inside __attribute__((format)),
one indicates that the system's typical format specifiers are supported.
This is OK for building for glibc, but it falls down for building for
mingw, since PSPP actually supports GNU format specifiers there via gnulib.
By writing gnu_printf instead, we avoid some incorrect warnings on mingw.
Ben Pfaff [Tue, 27 Oct 2020 02:31:18 +0000 (19:31 -0700)]
pspp-output: New option --table-look.
John Darrington [Mon, 26 Oct 2020 18:11:28 +0000 (19:11 +0100)]
TeX driver: Conditionally emit "\input graphics" control sequence.
Only emit the \input graphicx control sequence if it is actually needed.
This way, systems which do not have the graphicx package installed will
not fail on examples which need no graphics component.
Ben Pfaff [Mon, 26 Oct 2020 01:06:59 +0000 (18:06 -0700)]
doc: Fix use of @psppsyntax that should have been @psppoutput.
Ben Pfaff [Mon, 26 Oct 2020 00:29:12 +0000 (17:29 -0700)]
doc: Improve formatting of tutorial in PDF output.
In the PDF version of the manual, excerpts from the output were formatted
awkwardly because output couldn't be split across pages. In one case,
the output spilled off the bottom of the page. This fixes the problem.
This change is pretty big. It's because @float can't split across pages,
but without @float one must write in a different style that doesn't assume
the reader can jump back and forth to figures and tables. I also took
the opportunity to start using pspp-output to excerpt portions of output.
Ben Pfaff [Sun, 25 Oct 2020 21:32:42 +0000 (14:32 -0700)]
tex: Avoid compiler warning for unused variable.
Ben Pfaff [Sun, 25 Oct 2020 21:28:55 +0000 (14:28 -0700)]
pspp-output: Add new --nth-commands option.
John Darrington [Sun, 25 Oct 2020 19:46:00 +0000 (20:46 +0100)]
Add a TeX driver
Ben Pfaff [Sun, 25 Oct 2020 06:17:48 +0000 (23:17 -0700)]
doc: Fix dependencies.
These didn't cause a problem for me until I started using the autobuilder.
Build systems are so frustrating.
Ben Pfaff [Sun, 25 Oct 2020 06:08:21 +0000 (23:08 -0700)]
doc: Enclose @psppoutput and @psppsyntax in @smallexample.
This makes these fit better horizontally within the page width for PDF
output.
Ben Pfaff [Sun, 25 Oct 2020 06:07:28 +0000 (23:07 -0700)]
doc: Generate output for tutorial examples at build time too.
The trickiest part here is that the final example should only include part
of the output, the coefficients tables only. For that, we can use the
pspp-output utility to pull just those tables from the output file.
Ben Pfaff [Sun, 25 Oct 2020 05:45:28 +0000 (22:45 -0700)]
doc: Improve rules for generating output from examples.
This adds support for --enable-silent-rules, avoids the need for $PWD,
and behaves better if there is a failure (by not creating the output file).
Ben Pfaff [Sun, 25 Oct 2020 05:29:08 +0000 (22:29 -0700)]
zip-writer: Fix writing a zip file to a pipe.
The code here had comment indicating that it could write a zip file to a
pipe, but it didn't actually work. This fixes it and adds a test.
Ben Pfaff [Sun, 25 Oct 2020 05:15:51 +0000 (22:15 -0700)]
spv-driver: Fix double free on error path.
The output_driver_destroy() call also indirectly called fh_unref().
Ben Pfaff [Sun, 25 Oct 2020 03:26:13 +0000 (20:26 -0700)]
Make configure create doc/examples so the Makefiles don't need to.
Ben Pfaff [Sat, 24 Oct 2020 20:24:15 +0000 (13:24 -0700)]
doc: Add targets to build example outputs and HTML.