pspp
11 years agoCorrected warning message which made no logical sense. 20131020030504/pspp
John Darrington [Sat, 19 Oct 2013 16:16:10 +0000 (18:16 +0200)]
Corrected warning message which made no logical sense.

11 years agoRespect forground and background options when writing PNG charts.
John Darrington [Sat, 19 Oct 2013 12:20:38 +0000 (14:20 +0200)]
Respect forground and background options when writing PNG charts.

The default colours for charts in PNG format was black on black,
which wasn't very useful.  This change makes the defaults black
on white.

Perhaps for png charts intended for embedding in HTML it should be
black on transparent, but this hasn't been implemented in this change.

Fixes bugs #40107 and #40208

11 years agoNew structure xr_color
John Darrington [Sat, 19 Oct 2013 11:44:54 +0000 (13:44 +0200)]
New structure xr_color

11 years agoUpdated ca and es translations from translationproject.org 20131017030503/pspp 20131018030508/pspp 20131019030509/pspp
John Darrington [Wed, 16 Oct 2013 17:03:02 +0000 (19:03 +0200)]
Updated ca and es translations from translationproject.org

11 years agorl_echo_signal_char: Allow it to work on systems without termios 20131016030505/pspp
John Darrington [Tue, 15 Oct 2013 20:28:32 +0000 (22:28 +0200)]
rl_echo_signal_char: Allow it to work on systems without termios

11 years agoPersist font settings 20131015030506/pspp
John Darrington [Mon, 14 Oct 2013 17:36:02 +0000 (19:36 +0200)]
Persist font settings

Allow the font size and family chosen for the data editor to
persist between sessions

Requested-by: Paul Wright <pmwrightmiller@yahoo.com>
11 years agoOneway anova dialog: Converted to PsppireDialogAction 20131014030504/pspp
John Darrington [Sun, 13 Oct 2013 10:38:28 +0000 (12:38 +0200)]
Oneway anova dialog: Converted to PsppireDialogAction

11 years agoNPar two samples dialog and T-Test paired dialogs: Converted to PsppireDialogAction 20131012030504/pspp 20131013030505/pspp
John Darrington [Sat, 12 Oct 2013 07:01:26 +0000 (09:01 +0200)]
NPar two samples dialog and T-Test paired dialogs: Converted to PsppireDialogAction

11 years agoConvert count dialog to PsppireDialogAction 20131011030504/pspp
John Darrington [Fri, 11 Oct 2013 07:24:34 +0000 (09:24 +0200)]
Convert count dialog to PsppireDialogAction

11 years agoCompute Dialog: Convert to PsppireDialogAction 20131010030503/pspp
John Darrington [Thu, 10 Oct 2013 07:31:03 +0000 (09:31 +0200)]
Compute Dialog: Convert to PsppireDialogAction

11 years agoRemove remaining references to about-logo
John Darrington [Wed, 9 Oct 2013 10:31:50 +0000 (12:31 +0200)]
Remove remaining references to about-logo

This file was deleted by change 56231bc7e8c2cda46a69d10362193556dd8cad41 but not all
references were erased.

11 years agoK-Related Samples Test Dialog: Convert from old style to PsppireDialogAction
John Darrington [Wed, 9 Oct 2013 10:20:08 +0000 (12:20 +0200)]
K-Related Samples Test Dialog: Convert from old style to PsppireDialogAction

11 years agoRemove old signal handlers when target widgets are destroyed 20131009030508/pspp
John Darrington [Tue, 8 Oct 2013 13:43:49 +0000 (15:43 +0200)]
Remove old signal handlers when target widgets are destroyed

11 years agoProvide home grown rl_echo_signal_char if readline does not provide it
John Darrington [Tue, 8 Oct 2013 19:34:28 +0000 (21:34 +0200)]
Provide home grown rl_echo_signal_char if readline does not provide it

11 years agoRemoved the about-logo image which is redundant
John Darrington [Tue, 8 Oct 2013 16:32:20 +0000 (18:32 +0200)]
Removed the about-logo image which is redundant

11 years agoSimplify psppire-var-view and its relationship to psppire-means-layer
John Darrington [Tue, 8 Oct 2013 04:46:38 +0000 (06:46 +0200)]
Simplify psppire-var-view and its relationship to psppire-means-layer

11 years agocomments-dialog: Avoid segfault in comments dialog pasting very long text. 20131008030504/pspp
Ben Pfaff [Tue, 8 Oct 2013 03:40:24 +0000 (20:40 -0700)]
comments-dialog: Avoid segfault in comments dialog pasting very long text.

The code in wrap_line() used a GtkTextIter after an insertion invalidated
it.  In some setups, with a sufficiently long pasted text, this caused a
Gtk-WARNING and a subsequent segfault.  This commit fixes the problem by
removing the offending code.  In my testing, this didn't cause a UI
regression.

Reported by Bastián Díaz in the thread starting at
http://lists.gnu.org/archive/html/bug-gnu-pspp/2013-10/msg00005.html

11 years agoRecent to Gtk+2.24
John Darrington [Mon, 7 Oct 2013 15:42:14 +0000 (17:42 +0200)]
Recent to Gtk+2.24

11 years agoText import dialog: Display the thousands separator in the number of cases.
John Darrington [Mon, 7 Oct 2013 15:41:21 +0000 (17:41 +0200)]
Text import dialog: Display the thousands separator in the number of cases.

This number can be very large, so it is easier to read if the thousands are separated.

11 years agoInstall scalable application icon.
John Darrington [Mon, 7 Oct 2013 15:00:42 +0000 (17:00 +0200)]
Install scalable application icon.

Closes bug #40183

11 years agoProvisional new image is added for univariate analysis. 20131007030503/pspp
Bastián Díaz [Sun, 6 Oct 2013 22:21:18 +0000 (19:21 -0300)]
Provisional new image is added for univariate analysis.

Added a provisional icon to the univariate analysis (experimental).
The image will be updated to a new icon in the next update of
artwork (0.2.1 version).

Changes:
*analyze-univariate-analysis is added
*Smake is edited
*data-editor.ui is edited

11 years agoChange toolbar style such that only icons are displayed and no labels.
John Darrington [Sun, 6 Oct 2013 16:52:43 +0000 (18:52 +0200)]
Change toolbar style such that only icons are displayed and no labels.

The labels occupy too much horizontal space.

11 years agoFixed potentially incorrect dereference in autorecode dialog
John Darrington [Sat, 5 Oct 2013 17:18:12 +0000 (19:18 +0200)]
Fixed potentially incorrect dereference in autorecode dialog

11 years agoMEANS: Fix potential errors in gui syntax generation
John Darrington [Sat, 5 Oct 2013 10:30:12 +0000 (12:30 +0200)]
MEANS: Fix potential errors in gui syntax generation

11 years agoRemove unncessary property assignments
John Darrington [Sat, 5 Oct 2013 10:15:39 +0000 (12:15 +0200)]
Remove unncessary property assignments

11 years agoT-Test One Sample Dialog: Convert to PsppireDialogAction
John Darrington [Fri, 4 Oct 2013 20:44:22 +0000 (22:44 +0200)]
T-Test One Sample Dialog: Convert to PsppireDialogAction

11 years agoOne sample Kalmogorov-Smirnov Dialog: convert from old style to PsppireDialogAction
John Darrington [Fri, 4 Oct 2013 15:26:57 +0000 (17:26 +0200)]
One sample Kalmogorov-Smirnov Dialog: convert from old style to PsppireDialogAction

11 years agoUnivariate Dialog: Convert from old style to PsppireDialogAction
John Darrington [Fri, 4 Oct 2013 15:01:05 +0000 (17:01 +0200)]
Univariate Dialog: Convert from old style to PsppireDialogAction

11 years agoChi-square dialog: Convert from old style to psppire-dialog-action
John Darrington [Fri, 4 Oct 2013 13:22:56 +0000 (15:22 +0200)]
Chi-square dialog: Convert from old style to psppire-dialog-action

11 years agoTranspose dialog: convert from old style to PsppireDialogAction
John Darrington [Fri, 4 Oct 2013 11:59:51 +0000 (13:59 +0200)]
Transpose dialog: convert from old style to PsppireDialogAction

11 years agoRuns dialog: convert from old style to PsppireDialogAction
John Darrington [Fri, 4 Oct 2013 10:24:33 +0000 (12:24 +0200)]
Runs dialog: convert from old style to PsppireDialogAction

11 years agoReplace checkbox-treeview functions with a object PsppireCheckboxTreeview
John Darrington [Wed, 2 Oct 2013 13:14:15 +0000 (15:14 +0200)]
Replace checkbox-treeview functions with a object PsppireCheckboxTreeview

Prior to this change there existed a function which operated on
a GtkTreeView which populated it with a model and renderers such
that it would display a list of annotated checkboxes.

This change subclasses GtkTreeView and moves the function to a
method of that class.

I anticipate this will ease implementation of upcoming functionality.

11 years agodoc: Fix odd quotes in text. 20131006030505/pspp
Ben Pfaff [Sat, 5 Oct 2013 22:28:32 +0000 (15:28 -0700)]
doc: Fix odd quotes in text.

Reported by Michel Boaventura.
Bug #40189.

11 years agoSmake: pspp.png is the generated app icon, not pspp.png.
Ben Pfaff [Sat, 5 Oct 2013 15:23:37 +0000 (08:23 -0700)]
Smake: pspp.png is the generated app icon, not pspp.png.

Fixes "make -f Smake" error:
make: *** No rule to make target `src/ui/gui/icons/apps/scalable/pspp.svg', needed by `icons'.  Stop.

Bug introduced by commit (gui: Support for more flat icons and tag loss
fixing in some menus.)

Reported by Michel Boaventura.
Bug #40183.

11 years agodoc: Fix usage of @itemx.
Ben Pfaff [Sat, 5 Oct 2013 15:14:58 +0000 (08:14 -0700)]
doc: Fix usage of @itemx.

These @itemx commands should have been @item commands.

Reported by Michel Boaventura.
Bug #40182.

11 years agoRemove some #includes which were not necessary 20131003030503/pspp 20131004030505/pspp 20131005030503/pspp
John Darrington [Wed, 2 Oct 2013 13:02:29 +0000 (15:02 +0200)]
Remove some #includes which were not necessary

11 years agoUse the 32x32 icon set for the toolbar. 20131002030504/pspp
John Darrington [Tue, 1 Oct 2013 10:44:45 +0000 (12:44 +0200)]
Use the 32x32 icon set for the toolbar.

A (partial) set of 32x32 icons has recently been added.  This change tells the icon factory to
use those icons for the toolbar.

11 years agoDetect absence of rl_outstream and handle accordingly. 20131001030504/pspp
John Darrington [Tue, 1 Oct 2013 07:36:06 +0000 (09:36 +0200)]
Detect absence of rl_outstream and handle accordingly.

Older versions of readline do not appear to have the variable rl_outstream.  This variable,
almost certainly points to the same stream as stdout, so this change detects its absence
and uses stdout in those cases.

11 years agogui: Support for more flat icons and tag loss fixing in some menus.
Bastián Díaz [Mon, 30 Sep 2013 21:22:37 +0000 (18:22 -0300)]
gui: Support for more flat icons and tag loss fixing in some menus.

→ Icons for "new syntax", "new data", "Display information in working
file and external file are added.
→ Add the reference to the new icons to Smake an *.ui files
→ Replacement of some icons (bug fixes)

11 years agogui: Fix some problems after upgrading flat icons to version 0.2.
Bastián Díaz [Mon, 30 Sep 2013 14:18:31 +0000 (11:18 -0300)]
gui: Fix some problems after upgrading flat icons to version 0.2.

→ Replacement icon "about flat icon"
→ Replacement icon "measure string nominal"
→ Added label to Menu|Save
→ Addel label and icon to "sort-ascending" and "sort-descending"
→ Add reference to "analyze descriptive statistics"

11 years agogui: Improved application icon.
Bastián Díaz [Mon, 30 Sep 2013 13:55:38 +0000 (10:55 -0300)]
gui: Improved application icon.

It improves the esthetics and visual definition of application icon in different sizes of canvas, and adds a scalable version for desktop environments that use that value.

11 years agovariable: Complete renaming of ROLE_OUTPUT to ROLE_TARGET. 20130930030504/pspp
Ben Pfaff [Mon, 30 Sep 2013 07:12:35 +0000 (00:12 -0700)]
variable: Complete renaming of ROLE_OUTPUT to ROLE_TARGET.

Commit 47d59628a7d51a (psppire-var-sheet: Rename references to the icons
for align, measure and role icons) renamed some but not all uses of
ROLE_OUTPUT, breaking the build.  This commit completes the rename.

According to Bastián Díaz, "target" is better than "output" because it
is "a broader concept for function".

11 years agoSmake: Fix recently introduced typos.
Ben Pfaff [Mon, 30 Sep 2013 07:06:51 +0000 (00:06 -0700)]
Smake: Fix recently introduced typos.

This commit fixes typos were introduced in commit 3d543a3b6363 (Smake:
Rename references of images and add new ones).

11 years agosys-file-reader: Add support for long string missing values.
Ben Pfaff [Mon, 30 Sep 2013 02:11:41 +0000 (19:11 -0700)]
sys-file-reader: Add support for long string missing values.

I assumed earlier that long string missing values used the same fields in
the system file as other missing values, but I was wrong.  This commit
updates the support to match what I've seen in actual system files.

Reported by Przemek Powalko <pp.alter.ego@gmail.com>.

11 years agomissing-values: Make mv_add_str() easier to use.
Ben Pfaff [Mon, 30 Sep 2013 01:55:38 +0000 (18:55 -0700)]
missing-values: Make mv_add_str() easier to use.

Both existing callers of mv_add_str() were applying their own padding to
the string value.  This commit moves the padding into mv_add_str() itself.

This commit also fixes a minor to-do item in the MISSING VALUES command
whereby truncation of too-long missing values was done bytewise rather than
on the basis of full characters.

11 years agopsppire-var-sheet: Rename references to the icons for align, measure and role icons
Bastián Díaz [Mon, 30 Sep 2013 01:10:20 +0000 (22:10 -0300)]
psppire-var-sheet: Rename references to the icons for align, measure and role icons

11 years agogui:Add new reference to the icons in *.ui files
Bastián Díaz [Sun, 29 Sep 2013 21:32:35 +0000 (18:32 -0300)]
gui:Add new reference to the icons in *.ui files

11 years agoSmake: Rename references of images and add new ones
Bastián Díaz [Sun, 29 Sep 2013 20:18:40 +0000 (17:18 -0300)]
Smake: Rename references of images and add new ones

11 years agogui: Update flat icon set to version 0.2
Bastián Díaz [Sun, 29 Sep 2013 19:26:33 +0000 (16:26 -0300)]
gui: Update flat icon set to version 0.2

11 years agopsppire-data-store: Don't try to parse strings as custom currency formats. 20130929030504/pspp
Ben Pfaff [Sat, 28 Sep 2013 23:26:08 +0000 (16:26 -0700)]
psppire-data-store: Don't try to parse strings as custom currency formats.

Custom currency formats are not usable for input, only for output, but this
code tried to use them for input if the format was changed to a custom
currency format in the GUI.  This commit fixes the problem by using a
DOLLAR format, instead, for parsing.

Reported by Bastián Díaz <diaz.bastian@ymail.com>.

11 years agovariable: Only notify variable width change if it really did change.
Ben Pfaff [Sat, 28 Sep 2013 23:03:32 +0000 (16:03 -0700)]
variable: Only notify variable width change if it really did change.

This code was notifying a width change every time, even if the width did
not really change, which is wasteful.  This had a side effect of revealing
a bug in the GUI code which caused an assertion failure.  The bug still
remains in the GUI code, though it is now slightly harder to trigger, and
will be fixed separately in an upcoming commit.

11 years agoscan-test: Print nonintegers with limited precision to avoid test failures.
Ben Pfaff [Sat, 28 Sep 2013 21:57:23 +0000 (14:57 -0700)]
scan-test: Print nonintegers with limited precision to avoid test failures.

Cygwin printed 0.1 as 0.10000000000000001, even with dtoastr().

Reported by Przemek Powalko <pp.alter.ego@gmail.com>.

11 years agotests: Skip recently added Gnumeric tests if Gnumeric reader was not built.
Ben Pfaff [Sat, 28 Sep 2013 21:42:08 +0000 (14:42 -0700)]
tests: Skip recently added Gnumeric tests if Gnumeric reader was not built.

The Gnumeric tests written earlier already did this.

Reported by Przemek Powalko <pp.alter.ego@gmail.com>.

11 years agorender: Fix bug measuring spanned cells.
Ben Pfaff [Sat, 28 Sep 2013 20:55:14 +0000 (13:55 -0700)]
render: Fix bug measuring spanned cells.

11 years agoIgnore some files that are used for the build but not checked in.
Ben Pfaff [Sat, 28 Sep 2013 20:02:40 +0000 (13:02 -0700)]
Ignore some files that are used for the build but not checked in.

11 years agoDocumentation: Explain locale issues in the tutorial. 20130928030503/pspp
John Darrington [Sat, 28 Sep 2013 06:12:53 +0000 (08:12 +0200)]
Documentation: Explain locale issues in the tutorial.

Mention that explicitly setting the input format is necessary if the user wishes
to ignore the system's LC_NUMERIC setting.   Otherwise,  following the tutorial
strictly to the letter will result in confusing for users whose locale uses a
comma as the decimal separator.

11 years agoUse correct argument order for pool_nmalloc.
John Darrington [Fri, 27 Sep 2013 12:21:08 +0000 (14:21 +0200)]
Use correct argument order for pool_nmalloc.

This function (and other calloc-like functions) are may not take zero as the size argument.  Hence
the order is important.  Reported by Przemek Powalko <pp.alter.ego@gmail.com>

11 years agogui: Avoid referencing freed data upon closing data window. 20130926030516/pspp 20130927030516/pspp
Ben Pfaff [Thu, 26 Sep 2013 04:23:41 +0000 (21:23 -0700)]
gui: Avoid referencing freed data upon closing data window.

Without this commit, the following procedure always yielded Glib/GTK+
warnings or criticals for me:

1. Invoke PSPPIRE with a .sav file specified on the command line.
2. Choose Utilities|Variables...
3. Select a variable in the dialog box, then click on Cancel.
3. Close the output window using the window manager.
4. Close the data window using the window manager.

This commit fixes the problem.

11 years agoascii: Use correct arguments in call to msg_error().
Ben Pfaff [Thu, 26 Sep 2013 04:26:37 +0000 (21:26 -0700)]
ascii: Use correct arguments in call to msg_error().

11 years agoCharts: Use colours from Tango palette instead of fully saturated primaries 20130925030506/pspp
John Darrington [Tue, 24 Sep 2013 09:06:25 +0000 (11:06 +0200)]
Charts: Use colours from Tango palette instead of fully saturated primaries

11 years agoUse the msg function to report errors wherever possible.
John Darrington [Mon, 23 Sep 2013 14:46:53 +0000 (16:46 +0200)]
Use the msg function to report errors wherever possible.

Previously, some errors were reported using the GNU "error" function from error.h
rather than the PSPP msg function.  This wasn't too bad for the terminal user interace,
but gui users could miss important messages (since they never see stderr).

The reason for not using msg in some instances, was twofold: 1) Some
errors might occur before the messaging system had been initialised. 2) If an
error occured whilst reporting an error, an infinite loop would occur.

This change overcomes these problems by detecting re-entrancy, and uninitialised
messaging system, and falling back to fwrite if either of these conditions occur.

11 years agoAdded some gtk-criticals when the datasheet is null.
John Darrington [Sun, 22 Sep 2013 08:46:52 +0000 (10:46 +0200)]
Added some gtk-criticals when the datasheet is  null.

In a single threaded, non-concurrent system, this should never happen.

11 years agopo: Add Ukrainian translation from translationproject.org.
Ben Pfaff [Wed, 25 Sep 2013 03:36:30 +0000 (20:36 -0700)]
po: Add Ukrainian translation from translationproject.org.

11 years agoUpdate version number to 0.8.1. 20130924030503/pspp
Ben Pfaff [Tue, 24 Sep 2013 02:59:42 +0000 (19:59 -0700)]
Update version number to 0.8.1.

11 years agopsppire-dialog-action-var-info: Allow multiple variable selection. 20130923030505/pspp
Ben Pfaff [Mon, 23 Sep 2013 05:35:36 +0000 (22:35 -0700)]
psppire-dialog-action-var-info: Allow multiple variable selection.

This allows the user to select, view, and paste more than one variable
at a time in the Utilities|Variables dialog.

Requested by Bastian Diaz.

11 years agopsppire-dictview: New function psppire_dict_view_get_selected_variables().
Ben Pfaff [Mon, 23 Sep 2013 05:34:15 +0000 (22:34 -0700)]
psppire-dictview: New function psppire_dict_view_get_selected_variables().

11 years agogui: Remove unused dictionary parameter from missing_values_to_string().
Ben Pfaff [Mon, 23 Sep 2013 05:19:12 +0000 (22:19 -0700)]
gui: Remove unused dictionary parameter from missing_values_to_string().

11 years agoUpdated lithuanian translation from TP 20130921030502/pspp 20130922030503/pspp
John Darrington [Sat, 21 Sep 2013 06:05:04 +0000 (08:05 +0200)]
Updated lithuanian translation from TP

11 years agoAdded a test which checks the Fisher Exact Test results
John Darrington [Thu, 19 Sep 2013 05:16:51 +0000 (07:16 +0200)]
Added a test which checks the Fisher Exact Test results

11 years agoCalculate Fisher Exact Test even if all cell counts >= 5
John Darrington [Wed, 18 Sep 2013 17:16:08 +0000 (19:16 +0200)]
Calculate Fisher Exact Test even if all cell counts >= 5

Remove the condition that one of the cell counts must be < 5
before calculating the fisher exact test.  This condition seems
to be an anachronism, but still (erroneously) documented in Algorithms.

11 years agoCorrect error calculating significance of fisher exact test.
John Darrington [Wed, 18 Sep 2013 19:00:34 +0000 (21:00 +0200)]
Correct error calculating significance of fisher exact test.

The two tailed significance is the sum of the one tailed signficance and those point significances which
are greater than P(N = n1)

11 years agoCrosstabs: Use logarithms to calculate the product/quotients of factorials
John Darrington [Wed, 18 Sep 2013 18:37:59 +0000 (20:37 +0200)]
Crosstabs: Use logarithms to calculate the product/quotients of factorials

Avoid overflow of large numbers resulting from factorials, by using the logarithms as
intermediate results

11 years agosys-file-reader: Add support for record 7, subtype 10. 20130920030502/pspp
Ben Pfaff [Fri, 20 Sep 2013 06:39:53 +0000 (23:39 -0700)]
sys-file-reader: Add support for record 7, subtype 10.

Reported by Christoph Ruip with .sav file attached here:
http://lists.gnu.org/archive/html/bug-gnu-pspp/2013-09/msg00044.html

11 years agosys-file-info: Make cmd_sysfile_info() more flexible internally.
Ben Pfaff [Fri, 20 Sep 2013 05:32:58 +0000 (22:32 -0700)]
sys-file-info: Make cmd_sysfile_info() more flexible internally.

This change should not have any visible effect but does allow new rows to
be inserted between existing rows.

11 years agoFACTOR: Fix bug interpreting the /CRITERIA=ITERATE subcommand 20130917030502/pspp 20130918030502/pspp 20130919030506/pspp
John Darrington [Mon, 16 Sep 2013 06:49:43 +0000 (08:49 +0200)]
FACTOR: Fix bug interpreting the /CRITERIA=ITERATE subcommand

11 years agoNEWS: Mention the new icons 20130907030503/pspp 20130908030503/pspp 20130909030503/pspp 20130910030504/pspp 20130911030503/pspp 20130912030505/pspp 20130913030503/pspp 20130914030502/pspp 20130915030505/pspp 20130916030502/pspp
John Darrington [Sat, 7 Sep 2013 05:55:40 +0000 (07:55 +0200)]
NEWS: Mention the new icons

11 years agoMake one of the icon sets a wildcard set.
John Darrington [Sat, 7 Sep 2013 05:12:59 +0000 (07:12 +0200)]
Make one of the icon sets a wildcard set.

We currently have two icon sets: A 16x16 and a 24x24 set.  Previously,
we had been using the 16x16 set for menuitems and the 24x24 set for the
toolbar.  However it appeared that windows uses the symbol GTK_ICON_SIZE_SMALL_TOOLBAR
instead of GTK_ICON_SIZE_LARGE_TOOLBAR, which meant no icons appeared in the
toolbar.

This change sets the 24x24 set as a "wildcard" set meaning it will be used for
all purposes except menuitems.

11 years agopsppire-var-sheet: Add icons for role column too. 20130905030502/pspp 20130906030503/pspp
Ben Pfaff [Thu, 5 Sep 2013 04:42:59 +0000 (21:42 -0700)]
psppire-var-sheet: Add icons for role column too.

Some of the changes here reflect the way that all three combo box columns
now include a pixbuf, allowing greater code reuse.

Artwork contributed by Bastian Diaz.

11 years agoChange instances of GNM_SUPPORT to GNM_READ_SUPPORT
John Darrington [Wed, 4 Sep 2013 17:32:33 +0000 (19:32 +0200)]
Change instances of GNM_SUPPORT to GNM_READ_SUPPORT

Commit 82c1097ab658e8c13ab3ad439970148defba6e19 used the preprocessor
symbol GNM_READ_SUPPORT but GNM_SUPPORT was the one set in the autconf
files.  Hence some code was erroneously omitted.

This change uses GNM_READ_SUPPORT throughout which is consistent
with ODF_READ_SUPPORT

11 years agopsppire-var-sheet: Add icons to combo boxes for alignment and measurement. 20130904030503/pspp
Ben Pfaff [Wed, 4 Sep 2013 04:54:05 +0000 (21:54 -0700)]
psppire-var-sheet: Add icons to combo boxes for alignment and measurement.

We can easily add them for roles, too, if we get icons for those.

Suggested by Bastian Diaz.

11 years agopsppire-var-sheet: Factor out code into new function path_string_to_var().
Ben Pfaff [Wed, 4 Sep 2013 04:52:55 +0000 (21:52 -0700)]
psppire-var-sheet: Factor out code into new function path_string_to_var().

An upcoming commit will add a second user.

11 years agopsppire-var-sheet: Generalize get_var_align_stock_id().
Ben Pfaff [Wed, 4 Sep 2013 04:52:19 +0000 (21:52 -0700)]
psppire-var-sheet: Generalize get_var_align_stock_id().

This change allows finding a stock-id speculatively, without having a
variable on hand.

11 years agopsppire-dictview: Generalize psppire_dict_view_get_var_measurement_stock_id().
Ben Pfaff [Mon, 2 Sep 2013 23:14:28 +0000 (16:14 -0700)]
psppire-dictview: Generalize psppire_dict_view_get_var_measurement_stock_id().

This change allows finding a stock-id speculatively, without having a
variable on hand.

11 years agospreadsheet-reader: Avoid 'unused variable' warnings.
Ben Pfaff [Wed, 4 Sep 2013 04:56:23 +0000 (21:56 -0700)]
spreadsheet-reader: Avoid 'unused variable' warnings.

If ODS and GNM support are both unavailable then GCC warns here.

11 years agoDont try to build in gnumeric/odf reader if the libraries are not installed
John Darrington [Tue, 3 Sep 2013 16:59:20 +0000 (18:59 +0200)]
Dont try to build in gnumeric/odf reader if the libraries are not installed

11 years agodata-parser: A hard delimiter at end of line is not an empty field. 20130903030505/pspp
Ben Pfaff [Mon, 2 Sep 2013 20:00:30 +0000 (13:00 -0700)]
data-parser: A hard delimiter at end of line is not an empty field.

Until now, DATA LIST FREE(',') treated input like this:

    1,2,
    3,4,

as describing six fields, two of which were blank at the end of a line.
A bug report and subsequent experiments showed that in fact this is only
four fields, none of which is blank.  This commit fixes the problem and
adds a new test that should avoid regression against this issue.

Reported by Samuel Afflerbach.

11 years agoVARIABLE ROLE: Document the format and add a test. 20130827030505/pspp 20130828030503/pspp 20130829030514/pspp 20130830030503/pspp 20130831030502/pspp 20130901030502/pspp 20130902030504/pspp
Ben Pfaff [Tue, 27 Aug 2013 05:05:21 +0000 (22:05 -0700)]
VARIABLE ROLE: Document the format and add a test.

11 years agoVARIABLE ROLE: Use correct system file representation.
Ben Pfaff [Tue, 27 Aug 2013 05:04:59 +0000 (22:04 -0700)]
VARIABLE ROLE: Use correct system file representation.

Thanks to Paul Vella, Alan Mead, and Bastián Díaz for helping with this.

11 years agoVARIABLE ROLE: New command. 20130826030511/pspp
Ben Pfaff [Mon, 26 Aug 2013 05:57:56 +0000 (22:57 -0700)]
VARIABLE ROLE: New command.

Also adds GUI support.

The system file representation for variable roles is really just an
educated guess.  I am going to ask for assistance in confirming the
representation.

11 years agogui: Remove declarations of variables not defined anywhere.
Ben Pfaff [Sun, 25 Aug 2013 18:23:50 +0000 (11:23 -0700)]
gui: Remove declarations of variables not defined anywhere.

11 years agoAdded url for ODS to the documentation 20130818030502/pspp 20130819030515/pspp 20130820030504/pspp 20130821030502/pspp 20130822030502/pspp 20130823030507/pspp 20130824030504/pspp 20130825030503/pspp
John Darrington [Sat, 17 Aug 2013 10:48:43 +0000 (12:48 +0200)]
Added url for ODS to the documentation

11 years agoSmake: Move the svg2png function to its own $call
John Darrington [Sat, 17 Aug 2013 10:45:34 +0000 (12:45 +0200)]
Smake: Move the svg2png function to its own $call

11 years agolexer: Rename LEX_ERROR_INTERACTIVE to LEX_ERROR_TERMINAL, change default 20130816030502/pspp
Ben Pfaff [Fri, 16 Aug 2013 05:35:19 +0000 (22:35 -0700)]
lexer: Rename LEX_ERROR_INTERACTIVE to LEX_ERROR_TERMINAL, change default

The LEX_ERROR_INTERACTIVE error handling mode really only makes sense for
reading from a terminal, where we know we're getting one line at a time
and not partial lines.  Unfortunately LEX_ERROR_INTERACTIVE was the default
and it was getting used as such in the GUI for reading from syntax files.
This meant that if there was an error in the GUI then the current buffer
(which might be any arbitrary chunk of syntax) was being discarded, which
caused terrible confusion.

This commit changes the default to LEX_ERROR_CONTINUE, which works
in a reasonable fashion regardless of the input source.  It also renames
LEX_ERROR_INTERACTIVE to LEX_ERROR_TERMINAL to make it clear that that's
the only reasonable use.

Reported by Thambu David <thambu@cmcvellore.ac.in>, archived at:
http://lists.gnu.org/archive/html/pspp-users/2013-08/msg00019.html

11 years agoDeleted legacy icons 20130814030519/pspp 20130815030504/pspp
John Darrington [Tue, 13 Aug 2013 06:41:39 +0000 (08:41 +0200)]
Deleted legacy icons

11 years agopsppire-var-sheet: Hard-code size of pixbuf cells. 20130812030507/pspp 20130813030502/pspp
Ben Pfaff [Mon, 12 Aug 2013 04:56:52 +0000 (21:56 -0700)]
psppire-var-sheet: Hard-code size of pixbuf cells.

Otherwise the icons disappear if the sheet is initially empty, because
there's no icon for an empty row and thus nothing to make the pixbuf cells
nonzero size.

Reported by Bastian Diaz.

11 years agopsppire: Relocate icon files also.
Ben Pfaff [Mon, 12 Aug 2013 04:55:42 +0000 (21:55 -0700)]
psppire: Relocate icon files also.

Otherwise the icons can't be found with --enable-relocatable when the
program is not installed in the normal system location.

11 years agodoc: Clarify that DO REPEAT only substitutes whole words.
Ben Pfaff [Sun, 11 Aug 2013 17:37:08 +0000 (10:37 -0700)]
doc: Clarify that DO REPEAT only substitutes whole words.

Based on this conversation:
https://lists.gnu.org/archive/html/pspp-users/2013-08/msg00009.html

11 years agoMakefiles: Use $(LTLIBREADLINE) instead of $(LIBREADLINE).
Ben Pfaff [Sun, 11 Aug 2013 15:25:08 +0000 (08:25 -0700)]
Makefiles: Use $(LTLIBREADLINE) instead of $(LIBREADLINE).

Fixes a link failure with -Wl,--as-needed.

Reported by Sebastien Fabbro.
Bug #39707.

11 years agosrc/output/table.h: Rename class -> klass 20130811030503/pspp
John Darrington [Wed, 7 Aug 2013 17:07:25 +0000 (19:07 +0200)]
src/output/table.h: Rename class -> klass

This makes it possible to include this file in C++ compiled programs.

11 years agoFixed bug in command line parser
John Darrington [Sun, 11 Aug 2013 06:53:52 +0000 (08:53 +0200)]
Fixed bug in command line parser