Ben Pfaff [Sun, 25 Nov 2012 18:32:05 +0000 (10:32 -0800)]
tests: Add tests to cover corner cases in DATESUM, DATEDIFF.
These corner cases weren't covered by previous tests.
Bug #30708.
Reported by Daniel E WILLIAMS <Daniel.E.Williams@state.or.us>.
Ben Pfaff [Sun, 25 Nov 2012 17:04:54 +0000 (09:04 -0800)]
Remove feature to automatically connect to GDB when debugging is enabled.
This feature caused a few problems in "make check" on some distributions
when debugging was enabled at compile time. It is probably possible to
find and fix those particular problems, but the feature itself is
little-used, so this commit instead removes it.
Bug #37444.
Reported by Mindaugas.
John Darrington [Sun, 25 Nov 2012 10:07:44 +0000 (11:07 +0100)]
file handle properties: Make encoding member const
This member is never modified. So declare it as const. This way it
can be initialised from a static string.
John Darrington [Sat, 24 Nov 2012 20:33:20 +0000 (21:33 +0100)]
Aggregate Dialog: use global callback
John Darrington [Sat, 24 Nov 2012 19:56:20 +0000 (20:56 +0100)]
Runs Dialog: use global callback instead of a private one
Ben Pfaff [Sun, 25 Nov 2012 05:41:00 +0000 (21:41 -0800)]
psppire-data-window: Only allow saving a file with at least one variable.
A data file with no variables can't be saved to a file. Until now, this
wasn't detected until the user had already chosen a file name, and the
message used to report it was confusing: "SAVE is allowed only after the
active file has been defined." With this commit, the menu item and toolbar
item for save operations is, instead, disabled if the file has no
variables.
Bug #30700.
Reported by eric thivant, via Harry Thijssen, with help from Michel
Boaventura.
Ben Pfaff [Sun, 25 Nov 2012 01:50:05 +0000 (17:50 -0800)]
DATA LIST: Accept freefield format types without widths use minimum width.
A user reported that SPSS accepts syntax such as "DATA LIST FREE/
d (DATETIME)." using a default width for the field with no specified width.
This commit makes PSPP accept this syntax too, although it does not get
the width exactly right (please let me know if you figure out how to do
that).
Bug #30690.
Reported by Andreas Lappe.
Ben Pfaff [Sun, 25 Nov 2012 01:26:38 +0000 (17:26 -0800)]
format-parser: Improve error message when format specifier lacks width.
Until now, parse_format_specifier() was willing to parse, e.g. "datetime"
as a format specifier. It would then be rejected later by e.g.
fmt_check_input() with a message like "Input format DATETIME0.0 specifies
width 0, but DATETIME requires a width between 17 and 40," which makes no
sense to the user. This commit improves the error message.
Ben Pfaff [Sat, 24 Nov 2012 23:51:33 +0000 (15:51 -0800)]
data-parser: Use data-file error types for data-file errors.
The SW error type that these calls to msg() used before this command
include the name of the executing command in the error message. This can
be confusing because the executing command may not have any connection to
the command that said to read the data file. This commit changes these
error types to DW, which is intended for errors in a data file (and omits
the command name).
Bug #26517.
Ben Pfaff [Sat, 24 Nov 2012 22:14:16 +0000 (14:14 -0800)]
INPUT PROGRAM: Don't break out of INPUT PROGRAM on interactive error.
Until now, any erroneous command typed within an input program at an
interactive command prompt implicitly "broke out" of the input program,
causing confusing behavior. This commit fixes the problem: commands
following an erroneous command within INPUT PROGRAM continue to be part of
the input program.
Bug #33419.
Reported by John Darrington.
Ben Pfaff [Sat, 24 Nov 2012 21:47:06 +0000 (13:47 -0800)]
DATA LIST FREE: Warn when a quoted string is not followed by a delimiter.
A field parsed by DATA LIST FREE (or LIST) is either quoted or unquoted.
When it is quoted, this means that the entire field has to be quoted, that
is, it is not possible to quote some initial part of the field, then leave
some part of it unquoted (then possibly quote an additional part, etc.).
That means that the quoted portion should be followed by a delimiter,
such as white space, a comma, or end of line, but PSPP didn't warn when
it was not. This commit makes PSPP warn in this situation, which makes
errors in the input easier to find.
Bug #26522.
Reported by Pascal Barbedor <pbarbedor@gmail.com>.
Ben Pfaff [Sat, 24 Nov 2012 20:03:42 +0000 (12:03 -0800)]
output: Make default output file name depend on the format.
Before this commit, "-O html" caused HTML output to be written to a file
named "-", which is confusing. After this commit, it is written to a file
named "pspp.html". Similarly for other output drivers, except that text
and CSV output are still written to stdout by default.
Bug #35030.
Reported by John Darrington.
Ben Pfaff [Sat, 24 Nov 2012 19:11:17 +0000 (11:11 -0800)]
CROSSTABS: Use FORMAT setting to control output format.
Reported by Daniel Harper.
John Darrington [Sat, 24 Nov 2012 15:29:39 +0000 (16:29 +0100)]
Frequencies dialog: Convert to new system
John Darrington [Sat, 24 Nov 2012 08:06:54 +0000 (09:06 +0100)]
Fixed bug in NPAR BINOMIAL
This bug would crash when an incorrect syntax was encountered.
John Darrington [Sat, 24 Nov 2012 07:46:15 +0000 (08:46 +0100)]
Binomial test dialog: Convert to new style of action objects.
John Darrington [Fri, 23 Nov 2012 18:59:42 +0000 (19:59 +0100)]
Fix compiler warning
John Darrington [Fri, 23 Nov 2012 18:49:03 +0000 (19:49 +0100)]
Refactoring: common function set_sensitivity from toggle
Many dialog boxes have a signal handler to set the sensitivity
of a widget, according to the state of a toggle button. Until
now, they had all written their own.
John Darrington [Fri, 23 Nov 2012 14:18:42 +0000 (15:18 +0100)]
Merge remote branch 'origin/master' into psppsheet
John Darrington [Fri, 23 Nov 2012 08:01:36 +0000 (09:01 +0100)]
Logistic Regression: Ignore cases with missing dependent variables.
Prior to this change, cases with missing values in the predictor
variables were ignored, but cases with missing values only in the
dependent variable would provoke an error. Subsequent to this change
such cases are also ignored. This seems to be the behaviour of other
software, despite what their documentation may suggest.
John Darrington [Thu, 22 Nov 2012 19:15:44 +0000 (20:15 +0100)]
Logistic Regression: Added options dialog box
John Darrington [Thu, 22 Nov 2012 15:25:06 +0000 (16:25 +0100)]
Logistic Regression: Added a test to check the confidence interval display
John Darrington [Thu, 22 Nov 2012 14:39:48 +0000 (15:39 +0100)]
Logistic Regression: Fix bug where some confidence intervals were not reported.
John Darrington [Wed, 21 Nov 2012 21:13:27 +0000 (22:13 +0100)]
Logistic Regression: Calculate the logs of the likelihood instead of the raw value.
The likelihood values can become extremely large which can result in
lost precision in a double. This change therefore calculates the
logarithms of the likelihoods instead of their actual value.
John Darrington [Wed, 21 Nov 2012 18:13:20 +0000 (19:13 +0100)]
Logistic Regression Dialog: Added missing shortcut target.
John Darrington [Wed, 21 Nov 2012 18:10:06 +0000 (19:10 +0100)]
Changed the labels of the Regression menu to keep them shorter.
John Darrington [Tue, 20 Nov 2012 18:04:00 +0000 (19:04 +0100)]
Added rudimentary version of the Logistic Regression Dialog
John Darrington [Tue, 20 Nov 2012 17:05:07 +0000 (18:05 +0100)]
Analyze Menu: New submenu for Regression
Move the Linear Regression menuitem into a new submenu Regression.
This is in preparation for a new menuitem for Logistic Regression
John Darrington [Tue, 20 Nov 2012 11:32:34 +0000 (12:32 +0100)]
Fix (again) problems displaying a GtkSourceView widget on Cygwin
Under certain compiler options, the effect of the gtk_*get_type
function call was optimised away. This change fixes that. It
seems that both static and volatile are necessary, in order to
avoid the compiler from complaining and/or optimising the call
away.
John Darrington [Tue, 20 Nov 2012 09:32:14 +0000 (10:32 +0100)]
Logistic Regression: Optimise the classification calculations.
Instead of calculating the logit of the prediction for each case,
pre-calculate the inverse logit of the threshold before the process
starts. This should give a small performance gain..
John Darrington [Mon, 19 Nov 2012 18:45:14 +0000 (19:45 +0100)]
Fixed Texinfo problems which arise under Texinfo 4.13.90
John Darrington [Mon, 19 Nov 2012 14:35:43 +0000 (15:35 +0100)]
Logistic Regression: Added the Classification Table
Added a table to logistic regression to show how the predicted values
would be classified by the calculated coefficients.
John Darrington [Thu, 15 Nov 2012 14:23:37 +0000 (15:23 +0100)]
logistic.c: minor refactoring
John Darrington [Mon, 19 Nov 2012 10:15:49 +0000 (11:15 +0100)]
Fix possible memory corruption when creating dialogs with selectors.
The PsppireSelector widget's class structure contains a map of selectors
indexed by the source widget with which they are associated. Until now, that
map was never depopulated. This could have caused problems if newly created
widgets happened to use the same address as old, destroyed ones. This change
removes selectors from the map upon destruction.
John Darrington [Wed, 14 Nov 2012 16:05:01 +0000 (17:05 +0100)]
Logistic Regression: Handle missing categoricals
Ensure that missing values on categorical predictors are handled properly.
John Darrington [Wed, 14 Nov 2012 10:47:09 +0000 (11:47 +0100)]
Logistic Regression: Fix crash if categorical variable has no distinct values
John Darrington [Tue, 13 Nov 2012 18:49:07 +0000 (19:49 +0100)]
Remove empty _finalize function
John Darrington [Tue, 13 Nov 2012 18:42:34 +0000 (19:42 +0100)]
Find dialog: Don't crash when searching for a non-existant label.
John Darrington [Tue, 13 Nov 2012 18:37:07 +0000 (19:37 +0100)]
Small refactoring and cleanup of psppire-selector.c
Made explicit variables from some expressions. This provides
the opportinutiy to test if they are valid.
John Darrington [Tue, 13 Nov 2012 18:00:38 +0000 (19:00 +0100)]
Remove _base_init and base_finalize functions from psppire-selector
Gtk+ documentation recommends these are avoided in modern code.
They differ only from class_init in the case where the class has subclasses,
which PsppireSelector does not.
Ben Pfaff [Mon, 12 Nov 2012 16:57:34 +0000 (08:57 -0800)]
Merge 'master' into 'psppsheet'.
John Darrington [Sun, 11 Nov 2012 13:19:05 +0000 (14:19 +0100)]
Logistic Regression: Added categorical variable support
With this commit Logistic Regression now supports the /CATEGORICALS
subcommand, allowing a dependent variable to be regressed against one
or more categorical predictor variables.
Ben Pfaff [Sat, 10 Nov 2012 22:12:49 +0000 (14:12 -0800)]
pspp-sheet-view: Make Home and End go to left and right of sheet.
Requested by rocko mazuki <rockorocko@gmail.com>.
Ben Pfaff [Sat, 10 Nov 2012 22:11:55 +0000 (14:11 -0800)]
pspp-sheet-view: Enable Home and End in sheet.
However, they go to the top and bottom.
Ben Pfaff [Sat, 10 Nov 2012 22:09:21 +0000 (14:09 -0800)]
pspp-sheet-view: Refactor pspp_sheet_view_event().
This form seems easier to extend to new key combinations that include
Cnotrol or Shift or Alt.
Ben Pfaff [Fri, 9 Nov 2012 06:51:52 +0000 (22:51 -0800)]
gui: Rename psppire_data_sheet_show_variable().
psppire_data_sheet_goto_variable() is a more accurate name for the revised
behavior of this function.
Ben Pfaff [Fri, 9 Nov 2012 06:51:08 +0000 (22:51 -0800)]
psppire-data-sheet: Set cursor on row in psppire_data_sheet_show_variable().
psppire_data_sheet_show_variable() only ensured that the variable in
question was visible in the data sheet. This commit makes it also put
the cursor on the variable's column. This affects the function's two
callers: the Find Dialog now selects a cell instead of an entire row,
and double-clicking a row number in the variable sheet now does likewise.
This solves a problem reported by John Darrington, who reported that
double-clicking on a row number in the variable sheet did not change
the selected cell but only switched to the data sheet.
Ben Pfaff [Fri, 9 Nov 2012 06:10:58 +0000 (22:10 -0800)]
psppire-button-editable: Fix infinite recursion in button-release-event.
"release" and "button-release-event" are different. Before commit
8f843c3a5e905c (Avoid deprecated function: gtk_button_released),
psppire_button_editable_button_release() invoked the former. That commit
changed it to invoke the latter, which is the same signal that the
function itself implements, hence causing infinite recursion. This commit
changes it to invoke the former.
Without this commit, the following instructions reliably crash for me:
1. Load a data file, click over to variables tab.
2. Click on a ... button in the Type column.
3. Click on Cancel button in Type dialog.
4. Click on the same ... button as before.
With this commit, those instructions don't crash (the Type dialog pops
back up after step 4, as it should).
Reported by John Darrington.
John Darrington [Thu, 8 Nov 2012 13:33:51 +0000 (14:33 +0100)]
Categoricals.c: Ensure that categories are processed order of their categorical variable(s).
Some procedures require that categoricals are processed in a particular order.
Mathematically, the order is irrelevant, however for reporting purposes it is
sometimes required. This change adds a level of indirection, so that the codes
are allocated in ascending order of the categorical variable.
John Darrington [Tue, 6 Nov 2012 19:50:33 +0000 (20:50 +0100)]
Categoricals: Provide separate functions for effects and dummy coding.
Until now, the function categoricals_get_code_for_case returned the
"effects" coding (ie, a bipolar code). Some uses require "dummy" coding
(a binary coding). This change provides seperate functions to return
whatever is desired.
Conflicts:
src/language/stats/logistic.c
John Darrington [Sun, 4 Nov 2012 16:14:13 +0000 (17:14 +0100)]
Fixed some compiler warnings, which arose from recent commits.
John Darrington [Sat, 3 Nov 2012 10:19:13 +0000 (11:19 +0100)]
Added mnemonics to rank types dialog
John Darrington [Fri, 2 Nov 2012 15:33:06 +0000 (16:33 +0100)]
Added markup to GUI elements where necessary
John Darrington [Fri, 2 Nov 2012 14:36:00 +0000 (15:36 +0100)]
Fix bug in parse_design_interaction.
Previously this function would crash if it failed to succesfully parse
an interaction. This change fixes that.
John Darrington [Fri, 2 Nov 2012 14:31:45 +0000 (15:31 +0100)]
Categoricals: Accept null pointer as subject.
Previously, certain functions would crash, or behave badly if their
argument was NULL. This change makes them do nothing, or return
default values, as appropriate. This saves callers having to always
test for NULL.
John Darrington [Fri, 2 Nov 2012 14:24:12 +0000 (15:24 +0100)]
cateoricals.c categoricals.h clean up.
Removed a prototype whose implementation no longer exists.
Added a few comments.
Whitespace changes.
John Darrington [Thu, 1 Nov 2012 21:30:53 +0000 (22:30 +0100)]
Added mnemonic to t-test options dialog
John Darrington [Thu, 1 Nov 2012 17:44:17 +0000 (18:44 +0100)]
Added Mnemonics to the value chooser widget and to the recode dialog.
John Darrington [Thu, 1 Nov 2012 06:14:41 +0000 (07:14 +0100)]
Added markup to the spilt-file dialog
John Darrington [Tue, 30 Oct 2012 18:22:47 +0000 (19:22 +0100)]
Compute Dialog: Add mnemonics and focus widgets on activation.
John Darrington [Tue, 30 Oct 2012 05:54:09 +0000 (06:54 +0100)]
logistic.c: Fix read from uninitialised memory.
Found-by valgrind.
Ben Pfaff [Sun, 28 Oct 2012 20:22:33 +0000 (13:22 -0700)]
pspp-sheet-view: Fix warning using arrow keys to navigate column buttons.
Before this commit, clicking on a column head button in the data sheet,
then holding down the right arrow key until the data sheet began to scroll
right would often produce a warning of the form:
** (psppire:16451): WARNING **: Internal button not found
because nothing caused the underlying GtkButton to be instantiated in this
scenario. This commit fixes the problem.
Ben Pfaff [Sun, 28 Oct 2012 20:02:13 +0000 (13:02 -0700)]
Merge 'master' into 'psppsheet'.
Ben Pfaff [Sun, 28 Oct 2012 20:01:47 +0000 (13:01 -0700)]
pspp-sheet-view: Make Shift+Tab select only one cell when switching rows.
Before this commit, Shift+Tab at the start of a row in the data sheet would
select both the new cell and the cell below it. After this commit, only
the new cell is selected, as one would expect.
Reported by John Darrington.
John Darrington [Sun, 28 Oct 2012 09:16:01 +0000 (10:16 +0100)]
Move function parse_design_interaction into variable-parser.c
This function is (or will be) used by several procedures, so
make it public.
John Darrington [Sun, 28 Oct 2012 08:36:35 +0000 (09:36 +0100)]
glm.c: (lex_match_variable and parse_design_interaction) remove dependence on struct glm
Made these functions independent of struct glm, so that they can potentially be reused
for other procedures.
John Darrington [Sat, 27 Oct 2012 08:42:28 +0000 (10:42 +0200)]
Anova Dialog: Fix widget associations
John Darrington [Sat, 27 Oct 2012 05:34:20 +0000 (07:34 +0200)]
logistic.c : Avoid compiler warnings
John Darrington [Sat, 27 Oct 2012 05:21:05 +0000 (07:21 +0200)]
GUI: Added Mnemonic keys to Examine dialog
Ben Pfaff [Thu, 25 Oct 2012 06:24:25 +0000 (23:24 -0700)]
gui: Make Tab, Shift+Tab skip row head and new-var columns in data sheet.
Before this commit, Tab and Shift+Tab acted just like Left and Right in
the data sheet, that is, they visit every column except the row head
column and always stay on the same row. After this commit, Tab and
Shift+Tab skip the row head and new-variable columns. Also, Tab at the
end of a row goes to the beginning of the next row, and Shift+Tab at the
beginning of a row goes to the end of the previous row.
Suggested by John Darrington.
John Darrington [Tue, 16 Oct 2012 18:41:44 +0000 (20:41 +0200)]
First attempt at a LOGISTIC REGRESSION command
John Darrington [Thu, 18 Oct 2012 09:28:44 +0000 (11:28 +0200)]
Updated my entry in AUTHORS
Ben Pfaff [Mon, 15 Oct 2012 04:02:31 +0000 (21:02 -0700)]
psppire-data-sheet: Implement Edit|Paste.
This missing feature was reported by John Darrington.
Ben Pfaff [Sun, 14 Oct 2012 21:32:05 +0000 (14:32 -0700)]
psppire-data-sheet: Implement Edit|Cut.
I overlooked this earlier.
Reported by John Darrington.
Ben Pfaff [Sun, 14 Oct 2012 18:45:36 +0000 (11:45 -0700)]
psppire-var-sheet: Make clicking on Variables column select all data.
This does what users expect in the variable sheet.
Reported by John Darrington.
Ben Pfaff [Sun, 14 Oct 2012 18:40:28 +0000 (11:40 -0700)]
psppire-data-sheet: Make clicking on Cases column select all data.
This does what users expect in the data sheet.
Reported by John Darrington.
Ben Pfaff [Sun, 14 Oct 2012 18:36:13 +0000 (11:36 -0700)]
pspp-sheet-view-column: Make clicking on a row head column select all data.
This is what users typically expect: clicking on the upper-left of a
spreadsheet selects all of the cells in the spreadsheet.
Ben Pfaff [Sun, 14 Oct 2012 18:35:06 +0000 (11:35 -0700)]
psppire-data-sheet: Use specific functions instead of g_object_set().
Using particular functions seems less error-prone, since it avoids the
possibility of misspelling a property name or getting their values' types
wrong.
Ben Pfaff [Sun, 14 Oct 2012 18:33:42 +0000 (11:33 -0700)]
pspp-sheet-view-column: Be consistent about use of !! for booleans.
When "x = !!x;" is used, there's no need to use "x?TRUE:FALSE" later,
since one knows that the value is already 0 or 1, but some code did this
anyway.
This is a cleanup only that should not change behavior.
John Darrington [Sat, 13 Oct 2012 15:41:59 +0000 (17:41 +0200)]
doc/introduction.texi: Update documentations introductory section
John Darrington [Sat, 13 Oct 2012 14:46:22 +0000 (16:46 +0200)]
doc/automake.mk: Added a convenience rule for building all the documentation formats
John Darrington [Sat, 13 Oct 2012 13:22:38 +0000 (15:22 +0200)]
doc/automake.mk: Replace lines inadvertently removed by previous commit
John Darrington [Sat, 13 Oct 2012 10:59:18 +0000 (12:59 +0200)]
doc/automake.mk: Added further mutations to docbook xml to workaround makeinfo bugs
John Darrington [Sat, 13 Oct 2012 10:44:05 +0000 (12:44 +0200)]
doc/automake.mk: New mutations to generated docbook xml to workaround makeinfo bugs
John Darrington [Mon, 8 Oct 2012 20:14:36 +0000 (22:14 +0200)]
Fix bug where, after double-clicking to switch sheet view, a spurious release event was processed.
From http://developer.gnome.org/gdk/2.24/gdk-Event-Structures.html#GdkEventButton
Double and triple-clicks result in a sequence of events being received. For
double-clicks the order of events will be:
1. GDK_BUTTON_PRESS
2. GDK_BUTTON_RELEASE
3. GDK_BUTTON_PRESS
4. GDK_2BUTTON_PRESS
5. GDK_BUTTON_RELEASE
So what was happening was this: When the var-name was double-clicked, the view switched
from VarView to DataView as soon as event 4 (GDK_2BUTTON_PRESS) occured. Then event 5
(GDK_BUTTON_RELEASE) occured.
Now the PsppSheetView object is written such that, it decides to edit a cell, on button
release event. Hence, whichever cell the pointer happended to be in, when the user lifts
his finger after double clicking, starts to be edited.
This change ignores button release events on the object unless a corresponding button press
event was seen.
Ben Pfaff [Mon, 8 Oct 2012 19:06:11 +0000 (12:06 -0700)]
psppire-data-editor: Keep value labels setting across Windows|Split.
Before this commit, Windows|Split always turned off displaying value
labels in data sheet cells. This commit causes this setting to be
preserved across Windows|Split.
John Darrington [Mon, 8 Oct 2012 17:16:02 +0000 (19:16 +0200)]
Avoid deprecated function: gtk_button_released
Ben Pfaff [Fri, 5 Oct 2012 04:22:42 +0000 (21:22 -0700)]
configure.ac: Increase pango minimum version from 1.20 to 1.22
Commit
bd4d6e7453 (cairo: Avoid deprecated
pango_cairo_font_map_create_context().) added a dependency on pango
version 1.22 or later, but configure.ac only checked for version 1.20
or later. This commit fixes the discrepancy.
INSTALL already documented that Pango 1.22 or later was needed.
Reported by John Darrington.
Ben Pfaff [Sun, 30 Sep 2012 19:29:33 +0000 (12:29 -0700)]
tests: Better isolate search text in test of error reporting.
Some GNU/Linux distributions print additional text on a segfault,
e.g. "Cannot exec debugger: No such file or directory", which this
test was seeing in output and interpreting as a failed test. This
commit fixes the problem by ignoring text up to the ***** line that
marks the start of the expected output.
Bug #37444.
Reported by Mindaugus.
Ben Pfaff [Sun, 30 Sep 2012 18:29:46 +0000 (11:29 -0700)]
Remove variable assigned to but never used.
Found by GCC 4.7.
Ben Pfaff [Sun, 30 Sep 2012 18:25:23 +0000 (11:25 -0700)]
Merge 'master' into 'psppsheet'.
Ben Pfaff [Wed, 26 Sep 2012 04:18:32 +0000 (21:18 -0700)]
Suppress GCC 4.7 warnings by changes to code that make it less clear.
I'm not entirely happy with these changes, because they make the code
slightly less obvious. However, it's still not really bad code, and
it's convenient to have a warning-free build.
Ben Pfaff [Wed, 26 Sep 2012 04:20:09 +0000 (21:20 -0700)]
Suppress GCC 4.7 warnings due to unimplemented features.
GCC 4.7 complains that the variables removed by this commit are
assigned values that are not used. Fair enough, so this commit
removes them.
Ben Pfaff [Wed, 26 Sep 2012 00:09:47 +0000 (17:09 -0700)]
gnumeric-reader: Add cast to suppress warning.
This suppresses a GCC warning for a mismatch between
xmlInputCloseCallback, which takes a "void *" parameter, and
gzclose(), which takes a "gzFile" (which is "struct gzFile_s *").
This came up with an upgrade from "squeeze" to "wheezy". I assume
that a gzclose prototype became visible or that gzFile changed away
from "void *".
An alternative would be to write a trampoline to just transform one
pointer type to the other, but the xmlReaderForIO() invocation
already has one function cast so a second cast doesn't make it much
worse.
Ben Pfaff [Wed, 26 Sep 2012 00:03:10 +0000 (17:03 -0700)]
split-file-dialog: Add use of unused variable in split_file_dialog().
'selector' was assigned but never used, but here's a use.
Reported by GCC 4.7.
Ben Pfaff [Wed, 26 Sep 2012 00:02:21 +0000 (17:02 -0700)]
Suppress warnings for suspicious use of "enum" constants.
In each case, the code is using values of enums in valid ways that
GCC 4.7 does not expect, so use a cast to suppress the warnings.
Ben Pfaff [Wed, 26 Sep 2012 00:00:34 +0000 (17:00 -0700)]
gui: Check return value of gtk_tree_model_get_iter().
In these two cases the return value was assigned to a variable but
never used. This commit adds a check for the return value.
Ben Pfaff [Tue, 25 Sep 2012 22:54:43 +0000 (15:54 -0700)]
cairo: Avoid deprecated pango_cairo_font_map_create_context().
Pango 1.30 that is in Debian "wheezy" has marked this function as
deprecated. The replacement pango_font_map_create_context() was
introduced in Pango 1.22, which was also in Debian "squeeze" (which
had Pango 1.28), so it seems safe to switch without worrying about
a Pango version check.
Ben Pfaff [Tue, 25 Sep 2012 22:47:04 +0000 (15:47 -0700)]
Remove unused "finalize" functions.
A finalize function that just calls into the parent class finalize
function is a no-op that need not exist.
Ben Pfaff [Tue, 25 Sep 2012 22:36:50 +0000 (15:36 -0700)]
Remove variables assigned to but never used.
Each of the variables removed here was assigned a value that was
never used, the assignment didn't have any useful side effects, and
I don't see anything that the variable should have been used for.
Found by GCC 4.7.