pspp
11 years agodoc: Fix usage of @itemx.
Ben Pfaff [Sat, 5 Oct 2013 15:14:58 +0000 (08:14 -0700)]
doc: Fix usage of @itemx.

These @itemx commands should have been @item commands.

Reported by Michel Boaventura.
Bug #40182.

11 years agoRemove some #includes which were not necessary 20131003030503/pspp 20131004030505/pspp 20131005030503/pspp
John Darrington [Wed, 2 Oct 2013 13:02:29 +0000 (15:02 +0200)]
Remove some #includes which were not necessary

11 years agoUse the 32x32 icon set for the toolbar. 20131002030504/pspp
John Darrington [Tue, 1 Oct 2013 10:44:45 +0000 (12:44 +0200)]
Use the 32x32 icon set for the toolbar.

A (partial) set of 32x32 icons has recently been added.  This change tells the icon factory to
use those icons for the toolbar.

11 years agoDetect absence of rl_outstream and handle accordingly. 20131001030504/pspp
John Darrington [Tue, 1 Oct 2013 07:36:06 +0000 (09:36 +0200)]
Detect absence of rl_outstream and handle accordingly.

Older versions of readline do not appear to have the variable rl_outstream.  This variable,
almost certainly points to the same stream as stdout, so this change detects its absence
and uses stdout in those cases.

11 years agogui: Support for more flat icons and tag loss fixing in some menus.
Bastián Díaz [Mon, 30 Sep 2013 21:22:37 +0000 (18:22 -0300)]
gui: Support for more flat icons and tag loss fixing in some menus.

→ Icons for "new syntax", "new data", "Display information in working
file and external file are added.
→ Add the reference to the new icons to Smake an *.ui files
→ Replacement of some icons (bug fixes)

11 years agogui: Fix some problems after upgrading flat icons to version 0.2.
Bastián Díaz [Mon, 30 Sep 2013 14:18:31 +0000 (11:18 -0300)]
gui: Fix some problems after upgrading flat icons to version 0.2.

→ Replacement icon "about flat icon"
→ Replacement icon "measure string nominal"
→ Added label to Menu|Save
→ Addel label and icon to "sort-ascending" and "sort-descending"
→ Add reference to "analyze descriptive statistics"

11 years agogui: Improved application icon.
Bastián Díaz [Mon, 30 Sep 2013 13:55:38 +0000 (10:55 -0300)]
gui: Improved application icon.

It improves the esthetics and visual definition of application icon in different sizes of canvas, and adds a scalable version for desktop environments that use that value.

11 years agovariable: Complete renaming of ROLE_OUTPUT to ROLE_TARGET. 20130930030504/pspp
Ben Pfaff [Mon, 30 Sep 2013 07:12:35 +0000 (00:12 -0700)]
variable: Complete renaming of ROLE_OUTPUT to ROLE_TARGET.

Commit 47d59628a7d51a (psppire-var-sheet: Rename references to the icons
for align, measure and role icons) renamed some but not all uses of
ROLE_OUTPUT, breaking the build.  This commit completes the rename.

According to Bastián Díaz, "target" is better than "output" because it
is "a broader concept for function".

11 years agoSmake: Fix recently introduced typos.
Ben Pfaff [Mon, 30 Sep 2013 07:06:51 +0000 (00:06 -0700)]
Smake: Fix recently introduced typos.

This commit fixes typos were introduced in commit 3d543a3b6363 (Smake:
Rename references of images and add new ones).

11 years agosys-file-reader: Add support for long string missing values.
Ben Pfaff [Mon, 30 Sep 2013 02:11:41 +0000 (19:11 -0700)]
sys-file-reader: Add support for long string missing values.

I assumed earlier that long string missing values used the same fields in
the system file as other missing values, but I was wrong.  This commit
updates the support to match what I've seen in actual system files.

Reported by Przemek Powalko <pp.alter.ego@gmail.com>.

11 years agomissing-values: Make mv_add_str() easier to use.
Ben Pfaff [Mon, 30 Sep 2013 01:55:38 +0000 (18:55 -0700)]
missing-values: Make mv_add_str() easier to use.

Both existing callers of mv_add_str() were applying their own padding to
the string value.  This commit moves the padding into mv_add_str() itself.

This commit also fixes a minor to-do item in the MISSING VALUES command
whereby truncation of too-long missing values was done bytewise rather than
on the basis of full characters.

11 years agopsppire-var-sheet: Rename references to the icons for align, measure and role icons
Bastián Díaz [Mon, 30 Sep 2013 01:10:20 +0000 (22:10 -0300)]
psppire-var-sheet: Rename references to the icons for align, measure and role icons

11 years agogui:Add new reference to the icons in *.ui files
Bastián Díaz [Sun, 29 Sep 2013 21:32:35 +0000 (18:32 -0300)]
gui:Add new reference to the icons in *.ui files

11 years agoSmake: Rename references of images and add new ones
Bastián Díaz [Sun, 29 Sep 2013 20:18:40 +0000 (17:18 -0300)]
Smake: Rename references of images and add new ones

11 years agogui: Update flat icon set to version 0.2
Bastián Díaz [Sun, 29 Sep 2013 19:26:33 +0000 (16:26 -0300)]
gui: Update flat icon set to version 0.2

11 years agopsppire-data-store: Don't try to parse strings as custom currency formats. 20130929030504/pspp
Ben Pfaff [Sat, 28 Sep 2013 23:26:08 +0000 (16:26 -0700)]
psppire-data-store: Don't try to parse strings as custom currency formats.

Custom currency formats are not usable for input, only for output, but this
code tried to use them for input if the format was changed to a custom
currency format in the GUI.  This commit fixes the problem by using a
DOLLAR format, instead, for parsing.

Reported by Bastián Díaz <diaz.bastian@ymail.com>.

11 years agovariable: Only notify variable width change if it really did change.
Ben Pfaff [Sat, 28 Sep 2013 23:03:32 +0000 (16:03 -0700)]
variable: Only notify variable width change if it really did change.

This code was notifying a width change every time, even if the width did
not really change, which is wasteful.  This had a side effect of revealing
a bug in the GUI code which caused an assertion failure.  The bug still
remains in the GUI code, though it is now slightly harder to trigger, and
will be fixed separately in an upcoming commit.

11 years agoscan-test: Print nonintegers with limited precision to avoid test failures.
Ben Pfaff [Sat, 28 Sep 2013 21:57:23 +0000 (14:57 -0700)]
scan-test: Print nonintegers with limited precision to avoid test failures.

Cygwin printed 0.1 as 0.10000000000000001, even with dtoastr().

Reported by Przemek Powalko <pp.alter.ego@gmail.com>.

11 years agotests: Skip recently added Gnumeric tests if Gnumeric reader was not built.
Ben Pfaff [Sat, 28 Sep 2013 21:42:08 +0000 (14:42 -0700)]
tests: Skip recently added Gnumeric tests if Gnumeric reader was not built.

The Gnumeric tests written earlier already did this.

Reported by Przemek Powalko <pp.alter.ego@gmail.com>.

11 years agorender: Fix bug measuring spanned cells.
Ben Pfaff [Sat, 28 Sep 2013 20:55:14 +0000 (13:55 -0700)]
render: Fix bug measuring spanned cells.

11 years agoIgnore some files that are used for the build but not checked in.
Ben Pfaff [Sat, 28 Sep 2013 20:02:40 +0000 (13:02 -0700)]
Ignore some files that are used for the build but not checked in.

11 years agoDocumentation: Explain locale issues in the tutorial. 20130928030503/pspp
John Darrington [Sat, 28 Sep 2013 06:12:53 +0000 (08:12 +0200)]
Documentation: Explain locale issues in the tutorial.

Mention that explicitly setting the input format is necessary if the user wishes
to ignore the system's LC_NUMERIC setting.   Otherwise,  following the tutorial
strictly to the letter will result in confusing for users whose locale uses a
comma as the decimal separator.

11 years agoUse correct argument order for pool_nmalloc.
John Darrington [Fri, 27 Sep 2013 12:21:08 +0000 (14:21 +0200)]
Use correct argument order for pool_nmalloc.

This function (and other calloc-like functions) are may not take zero as the size argument.  Hence
the order is important.  Reported by Przemek Powalko <pp.alter.ego@gmail.com>

11 years agogui: Avoid referencing freed data upon closing data window. 20130926030516/pspp 20130927030516/pspp
Ben Pfaff [Thu, 26 Sep 2013 04:23:41 +0000 (21:23 -0700)]
gui: Avoid referencing freed data upon closing data window.

Without this commit, the following procedure always yielded Glib/GTK+
warnings or criticals for me:

1. Invoke PSPPIRE with a .sav file specified on the command line.
2. Choose Utilities|Variables...
3. Select a variable in the dialog box, then click on Cancel.
3. Close the output window using the window manager.
4. Close the data window using the window manager.

This commit fixes the problem.

11 years agoascii: Use correct arguments in call to msg_error().
Ben Pfaff [Thu, 26 Sep 2013 04:26:37 +0000 (21:26 -0700)]
ascii: Use correct arguments in call to msg_error().

11 years agoCharts: Use colours from Tango palette instead of fully saturated primaries 20130925030506/pspp
John Darrington [Tue, 24 Sep 2013 09:06:25 +0000 (11:06 +0200)]
Charts: Use colours from Tango palette instead of fully saturated primaries

11 years agoUse the msg function to report errors wherever possible.
John Darrington [Mon, 23 Sep 2013 14:46:53 +0000 (16:46 +0200)]
Use the msg function to report errors wherever possible.

Previously, some errors were reported using the GNU "error" function from error.h
rather than the PSPP msg function.  This wasn't too bad for the terminal user interace,
but gui users could miss important messages (since they never see stderr).

The reason for not using msg in some instances, was twofold: 1) Some
errors might occur before the messaging system had been initialised. 2) If an
error occured whilst reporting an error, an infinite loop would occur.

This change overcomes these problems by detecting re-entrancy, and uninitialised
messaging system, and falling back to fwrite if either of these conditions occur.

11 years agoAdded some gtk-criticals when the datasheet is null.
John Darrington [Sun, 22 Sep 2013 08:46:52 +0000 (10:46 +0200)]
Added some gtk-criticals when the datasheet is  null.

In a single threaded, non-concurrent system, this should never happen.

11 years agopo: Add Ukrainian translation from translationproject.org.
Ben Pfaff [Wed, 25 Sep 2013 03:36:30 +0000 (20:36 -0700)]
po: Add Ukrainian translation from translationproject.org.

11 years agoUpdate version number to 0.8.1. 20130924030503/pspp
Ben Pfaff [Tue, 24 Sep 2013 02:59:42 +0000 (19:59 -0700)]
Update version number to 0.8.1.

11 years agopsppire-dialog-action-var-info: Allow multiple variable selection. 20130923030505/pspp
Ben Pfaff [Mon, 23 Sep 2013 05:35:36 +0000 (22:35 -0700)]
psppire-dialog-action-var-info: Allow multiple variable selection.

This allows the user to select, view, and paste more than one variable
at a time in the Utilities|Variables dialog.

Requested by Bastian Diaz.

11 years agopsppire-dictview: New function psppire_dict_view_get_selected_variables().
Ben Pfaff [Mon, 23 Sep 2013 05:34:15 +0000 (22:34 -0700)]
psppire-dictview: New function psppire_dict_view_get_selected_variables().

11 years agogui: Remove unused dictionary parameter from missing_values_to_string().
Ben Pfaff [Mon, 23 Sep 2013 05:19:12 +0000 (22:19 -0700)]
gui: Remove unused dictionary parameter from missing_values_to_string().

11 years agoUpdated lithuanian translation from TP 20130921030502/pspp 20130922030503/pspp
John Darrington [Sat, 21 Sep 2013 06:05:04 +0000 (08:05 +0200)]
Updated lithuanian translation from TP

11 years agoAdded a test which checks the Fisher Exact Test results
John Darrington [Thu, 19 Sep 2013 05:16:51 +0000 (07:16 +0200)]
Added a test which checks the Fisher Exact Test results

11 years agoCalculate Fisher Exact Test even if all cell counts >= 5
John Darrington [Wed, 18 Sep 2013 17:16:08 +0000 (19:16 +0200)]
Calculate Fisher Exact Test even if all cell counts >= 5

Remove the condition that one of the cell counts must be < 5
before calculating the fisher exact test.  This condition seems
to be an anachronism, but still (erroneously) documented in Algorithms.

11 years agoCorrect error calculating significance of fisher exact test.
John Darrington [Wed, 18 Sep 2013 19:00:34 +0000 (21:00 +0200)]
Correct error calculating significance of fisher exact test.

The two tailed significance is the sum of the one tailed signficance and those point significances which
are greater than P(N = n1)

11 years agoCrosstabs: Use logarithms to calculate the product/quotients of factorials
John Darrington [Wed, 18 Sep 2013 18:37:59 +0000 (20:37 +0200)]
Crosstabs: Use logarithms to calculate the product/quotients of factorials

Avoid overflow of large numbers resulting from factorials, by using the logarithms as
intermediate results

11 years agosys-file-reader: Add support for record 7, subtype 10. 20130920030502/pspp
Ben Pfaff [Fri, 20 Sep 2013 06:39:53 +0000 (23:39 -0700)]
sys-file-reader: Add support for record 7, subtype 10.

Reported by Christoph Ruip with .sav file attached here:
http://lists.gnu.org/archive/html/bug-gnu-pspp/2013-09/msg00044.html

11 years agosys-file-info: Make cmd_sysfile_info() more flexible internally.
Ben Pfaff [Fri, 20 Sep 2013 05:32:58 +0000 (22:32 -0700)]
sys-file-info: Make cmd_sysfile_info() more flexible internally.

This change should not have any visible effect but does allow new rows to
be inserted between existing rows.

11 years agoFACTOR: Fix bug interpreting the /CRITERIA=ITERATE subcommand 20130917030502/pspp 20130918030502/pspp 20130919030506/pspp
John Darrington [Mon, 16 Sep 2013 06:49:43 +0000 (08:49 +0200)]
FACTOR: Fix bug interpreting the /CRITERIA=ITERATE subcommand

11 years agoNEWS: Mention the new icons 20130907030503/pspp 20130908030503/pspp 20130909030503/pspp 20130910030504/pspp 20130911030503/pspp 20130912030505/pspp 20130913030503/pspp 20130914030502/pspp 20130915030505/pspp 20130916030502/pspp
John Darrington [Sat, 7 Sep 2013 05:55:40 +0000 (07:55 +0200)]
NEWS: Mention the new icons

11 years agoMake one of the icon sets a wildcard set.
John Darrington [Sat, 7 Sep 2013 05:12:59 +0000 (07:12 +0200)]
Make one of the icon sets a wildcard set.

We currently have two icon sets: A 16x16 and a 24x24 set.  Previously,
we had been using the 16x16 set for menuitems and the 24x24 set for the
toolbar.  However it appeared that windows uses the symbol GTK_ICON_SIZE_SMALL_TOOLBAR
instead of GTK_ICON_SIZE_LARGE_TOOLBAR, which meant no icons appeared in the
toolbar.

This change sets the 24x24 set as a "wildcard" set meaning it will be used for
all purposes except menuitems.

11 years agopsppire-var-sheet: Add icons for role column too. 20130905030502/pspp 20130906030503/pspp
Ben Pfaff [Thu, 5 Sep 2013 04:42:59 +0000 (21:42 -0700)]
psppire-var-sheet: Add icons for role column too.

Some of the changes here reflect the way that all three combo box columns
now include a pixbuf, allowing greater code reuse.

Artwork contributed by Bastian Diaz.

11 years agoChange instances of GNM_SUPPORT to GNM_READ_SUPPORT
John Darrington [Wed, 4 Sep 2013 17:32:33 +0000 (19:32 +0200)]
Change instances of GNM_SUPPORT to GNM_READ_SUPPORT

Commit 82c1097ab658e8c13ab3ad439970148defba6e19 used the preprocessor
symbol GNM_READ_SUPPORT but GNM_SUPPORT was the one set in the autconf
files.  Hence some code was erroneously omitted.

This change uses GNM_READ_SUPPORT throughout which is consistent
with ODF_READ_SUPPORT

11 years agopsppire-var-sheet: Add icons to combo boxes for alignment and measurement. 20130904030503/pspp
Ben Pfaff [Wed, 4 Sep 2013 04:54:05 +0000 (21:54 -0700)]
psppire-var-sheet: Add icons to combo boxes for alignment and measurement.

We can easily add them for roles, too, if we get icons for those.

Suggested by Bastian Diaz.

11 years agopsppire-var-sheet: Factor out code into new function path_string_to_var().
Ben Pfaff [Wed, 4 Sep 2013 04:52:55 +0000 (21:52 -0700)]
psppire-var-sheet: Factor out code into new function path_string_to_var().

An upcoming commit will add a second user.

11 years agopsppire-var-sheet: Generalize get_var_align_stock_id().
Ben Pfaff [Wed, 4 Sep 2013 04:52:19 +0000 (21:52 -0700)]
psppire-var-sheet: Generalize get_var_align_stock_id().

This change allows finding a stock-id speculatively, without having a
variable on hand.

11 years agopsppire-dictview: Generalize psppire_dict_view_get_var_measurement_stock_id().
Ben Pfaff [Mon, 2 Sep 2013 23:14:28 +0000 (16:14 -0700)]
psppire-dictview: Generalize psppire_dict_view_get_var_measurement_stock_id().

This change allows finding a stock-id speculatively, without having a
variable on hand.

11 years agospreadsheet-reader: Avoid 'unused variable' warnings.
Ben Pfaff [Wed, 4 Sep 2013 04:56:23 +0000 (21:56 -0700)]
spreadsheet-reader: Avoid 'unused variable' warnings.

If ODS and GNM support are both unavailable then GCC warns here.

11 years agoDont try to build in gnumeric/odf reader if the libraries are not installed
John Darrington [Tue, 3 Sep 2013 16:59:20 +0000 (18:59 +0200)]
Dont try to build in gnumeric/odf reader if the libraries are not installed

11 years agodata-parser: A hard delimiter at end of line is not an empty field. 20130903030505/pspp
Ben Pfaff [Mon, 2 Sep 2013 20:00:30 +0000 (13:00 -0700)]
data-parser: A hard delimiter at end of line is not an empty field.

Until now, DATA LIST FREE(',') treated input like this:

    1,2,
    3,4,

as describing six fields, two of which were blank at the end of a line.
A bug report and subsequent experiments showed that in fact this is only
four fields, none of which is blank.  This commit fixes the problem and
adds a new test that should avoid regression against this issue.

Reported by Samuel Afflerbach.

11 years agoVARIABLE ROLE: Document the format and add a test. 20130827030505/pspp 20130828030503/pspp 20130829030514/pspp 20130830030503/pspp 20130831030502/pspp 20130901030502/pspp 20130902030504/pspp
Ben Pfaff [Tue, 27 Aug 2013 05:05:21 +0000 (22:05 -0700)]
VARIABLE ROLE: Document the format and add a test.

11 years agoVARIABLE ROLE: Use correct system file representation.
Ben Pfaff [Tue, 27 Aug 2013 05:04:59 +0000 (22:04 -0700)]
VARIABLE ROLE: Use correct system file representation.

Thanks to Paul Vella, Alan Mead, and Bastián Díaz for helping with this.

11 years agoVARIABLE ROLE: New command. 20130826030511/pspp
Ben Pfaff [Mon, 26 Aug 2013 05:57:56 +0000 (22:57 -0700)]
VARIABLE ROLE: New command.

Also adds GUI support.

The system file representation for variable roles is really just an
educated guess.  I am going to ask for assistance in confirming the
representation.

11 years agogui: Remove declarations of variables not defined anywhere.
Ben Pfaff [Sun, 25 Aug 2013 18:23:50 +0000 (11:23 -0700)]
gui: Remove declarations of variables not defined anywhere.

11 years agoAdded url for ODS to the documentation 20130818030502/pspp 20130819030515/pspp 20130820030504/pspp 20130821030502/pspp 20130822030502/pspp 20130823030507/pspp 20130824030504/pspp 20130825030503/pspp
John Darrington [Sat, 17 Aug 2013 10:48:43 +0000 (12:48 +0200)]
Added url for ODS to the documentation

11 years agoSmake: Move the svg2png function to its own $call
John Darrington [Sat, 17 Aug 2013 10:45:34 +0000 (12:45 +0200)]
Smake: Move the svg2png function to its own $call

11 years agolexer: Rename LEX_ERROR_INTERACTIVE to LEX_ERROR_TERMINAL, change default 20130816030502/pspp
Ben Pfaff [Fri, 16 Aug 2013 05:35:19 +0000 (22:35 -0700)]
lexer: Rename LEX_ERROR_INTERACTIVE to LEX_ERROR_TERMINAL, change default

The LEX_ERROR_INTERACTIVE error handling mode really only makes sense for
reading from a terminal, where we know we're getting one line at a time
and not partial lines.  Unfortunately LEX_ERROR_INTERACTIVE was the default
and it was getting used as such in the GUI for reading from syntax files.
This meant that if there was an error in the GUI then the current buffer
(which might be any arbitrary chunk of syntax) was being discarded, which
caused terrible confusion.

This commit changes the default to LEX_ERROR_CONTINUE, which works
in a reasonable fashion regardless of the input source.  It also renames
LEX_ERROR_INTERACTIVE to LEX_ERROR_TERMINAL to make it clear that that's
the only reasonable use.

Reported by Thambu David <thambu@cmcvellore.ac.in>, archived at:
http://lists.gnu.org/archive/html/pspp-users/2013-08/msg00019.html

11 years agoDeleted legacy icons 20130814030519/pspp 20130815030504/pspp
John Darrington [Tue, 13 Aug 2013 06:41:39 +0000 (08:41 +0200)]
Deleted legacy icons

11 years agopsppire-var-sheet: Hard-code size of pixbuf cells. 20130812030507/pspp 20130813030502/pspp
Ben Pfaff [Mon, 12 Aug 2013 04:56:52 +0000 (21:56 -0700)]
psppire-var-sheet: Hard-code size of pixbuf cells.

Otherwise the icons disappear if the sheet is initially empty, because
there's no icon for an empty row and thus nothing to make the pixbuf cells
nonzero size.

Reported by Bastian Diaz.

11 years agopsppire: Relocate icon files also.
Ben Pfaff [Mon, 12 Aug 2013 04:55:42 +0000 (21:55 -0700)]
psppire: Relocate icon files also.

Otherwise the icons can't be found with --enable-relocatable when the
program is not installed in the normal system location.

11 years agodoc: Clarify that DO REPEAT only substitutes whole words.
Ben Pfaff [Sun, 11 Aug 2013 17:37:08 +0000 (10:37 -0700)]
doc: Clarify that DO REPEAT only substitutes whole words.

Based on this conversation:
https://lists.gnu.org/archive/html/pspp-users/2013-08/msg00009.html

11 years agoMakefiles: Use $(LTLIBREADLINE) instead of $(LIBREADLINE).
Ben Pfaff [Sun, 11 Aug 2013 15:25:08 +0000 (08:25 -0700)]
Makefiles: Use $(LTLIBREADLINE) instead of $(LIBREADLINE).

Fixes a link failure with -Wl,--as-needed.

Reported by Sebastien Fabbro.
Bug #39707.

11 years agosrc/output/table.h: Rename class -> klass 20130811030503/pspp
John Darrington [Wed, 7 Aug 2013 17:07:25 +0000 (19:07 +0200)]
src/output/table.h: Rename class -> klass

This makes it possible to include this file in C++ compiled programs.

11 years agoFixed bug in command line parser
John Darrington [Sun, 11 Aug 2013 06:53:52 +0000 (08:53 +0200)]
Fixed bug in command line parser

11 years agoReduce the possibility of translator errors
John Darrington [Sun, 11 Aug 2013 05:40:27 +0000 (07:40 +0200)]
Reduce the possibility of translator errors

11 years agogui: Restore icons deleted in error. 20130810095603/pspp
Ben Pfaff [Sat, 10 Aug 2013 16:48:32 +0000 (09:48 -0700)]
gui: Restore icons deleted in error.

These icons were deleted by commit caa467c9a26a7 (gui: Update artwork.)
even though they were still in use.  This commit restores them and allows
"make -f Smake" to complete without error.

11 years agoDeleted some files which do not seem to serve any purpose 20130810030502/pspp
John Darrington [Fri, 9 Aug 2013 07:53:56 +0000 (09:53 +0200)]
Deleted some files which do not seem to serve any purpose

11 years agoRemove legacy icons 20130809030501/pspp
John Darrington [Thu, 8 Aug 2013 16:05:30 +0000 (18:05 +0200)]
Remove legacy icons

11 years agoAdded the new "about-logo"
John Darrington [Thu, 8 Aug 2013 16:04:06 +0000 (18:04 +0200)]
Added the new "about-logo"

11 years agoSmake: Add appropriate dependencies to manifest and icon-names targets 20130808030502/pspp
John Darrington [Wed, 7 Aug 2013 06:22:43 +0000 (08:22 +0200)]
Smake: Add appropriate dependencies to manifest and icon-names targets

11 years agogui: Update artwork.
Bastián Díaz [Wed, 7 Aug 2013 06:16:26 +0000 (02:16 -0400)]
gui: Update artwork.

11 years agoAdded new icons and made them stock items. 20130806030502/pspp
John Darrington [Mon, 5 Aug 2013 18:30:43 +0000 (20:30 +0200)]
Added new icons and made them stock items.

Added the new artwork by Bastian Diaz, and created stock items for them.
Used a few of these stock items where appropriate.

11 years agoencoding-guesser: Fix bug in parsing fallback encodings. 20130805030512/pspp
Ben Pfaff [Mon, 5 Aug 2013 02:42:29 +0000 (19:42 -0700)]
encoding-guesser: Fix bug in parsing fallback encodings.

The encoding guesser originally used UTF-8 as a fallback in situations
where it had already figured out that UTF-8 couldn't be right.  Commit
d6c75296 (encoding-guesser: Fall back to windows-1252 when UTF-8 can't be
right.) fixed this, by falling back to window-1252 when UTF-8 was known to
be wrong, but it also introduced a bug where this change to the fallback
encoding occurred even when UTF-8 had not be determined to be wrong.  This
commit fixes that problem.

Reported by John Darrington.

11 years agosys-file-reader: Accept measurement value of zero without complaint. 20130804030502/pspp
Ben Pfaff [Sat, 3 Aug 2013 21:48:36 +0000 (14:48 -0700)]
sys-file-reader: Accept measurement value of zero without complaint.

SPSS 14 seemed to output a measurement value of 0 for string variables,
but SPSS 21 does the same thing for numeric variables.  We might as well
accept it.

Reported by Mindaugus.
Bug #39502

11 years agosys-file-reader: Ignore subtype 24 written by SPSS 21.
Ben Pfaff [Sat, 3 Aug 2013 21:16:22 +0000 (14:16 -0700)]
sys-file-reader: Ignore subtype 24 written by SPSS 21.

Reported by Mindaugus.

11 years agosys-file-reader: Handle SPSS 21 change in representation of LOWEST.
Ben Pfaff [Sat, 3 Aug 2013 19:20:46 +0000 (12:20 -0700)]
sys-file-reader: Handle SPSS 21 change in representation of LOWEST.

Thanks to Mindaugus for reporting this issue.
Bug #39502.

11 years agosys-file-reader: Improve diagnostics for unexpected special values.
Ben Pfaff [Sat, 3 Aug 2013 18:59:07 +0000 (11:59 -0700)]
sys-file-reader: Improve diagnostics for unexpected special values.

SPSS 21 schanged the value that it reports for "lowest" in the machine
float info record, but the existing diagnostics made it hard to tell
exactly what changed.  Adding hexadecimal float output makes it obvious.

11 years agopspp-dump-sav: Print a new-line following text record content.
Ben Pfaff [Sat, 3 Aug 2013 20:38:03 +0000 (13:38 -0700)]
pspp-dump-sav: Print a new-line following text record content.

Text records don't necessarily end in a new-line so this ensures that the
next line of output starts at the beginning of a line.

11 years agopsppire-var-sheet: Add alignment icons to variable sheet.
Ben Pfaff [Sat, 3 Aug 2013 16:47:39 +0000 (09:47 -0700)]
psppire-var-sheet: Add alignment icons to variable sheet.

11 years agogui: Remove processor-area from status bar to reduce minimum window width. 20130730030503/pspp 20130731030504/pspp 20130801030502/pspp 20130802030502/pspp 20130803030513/pspp
Ben Pfaff [Sun, 28 Jul 2013 22:24:39 +0000 (15:24 -0700)]
gui: Remove processor-area from status bar to reduce minimum window width.

Nothing ever puts anything in the processor-area widget, but it forces
the data window to be 35 character widths wider, so by removing it we can
allow the window to be resized much narrower when the status bar is shown.

Reported by Bastián Díaz <diaz.bastian@ymail.com>.

11 years agopsppire-var-sheet: Add measurement level icons to variable sheet. 20130729030504/pspp
Ben Pfaff [Mon, 29 Jul 2013 04:28:32 +0000 (21:28 -0700)]
psppire-var-sheet: Add measurement level icons to variable sheet.

Suggested by Bastián Díaz <diaz.bastian@ymail.com>.

11 years agopspp-sheet-view: Draw vertical grid lines at far right of grid.
Ben Pfaff [Sun, 28 Jul 2013 23:47:40 +0000 (16:47 -0700)]
pspp-sheet-view: Draw vertical grid lines at far right of grid.

11 years agopspp-sheet-view: Fix bug that omitted bottom of cell grid lines.
Ben Pfaff [Sun, 28 Jul 2013 23:43:13 +0000 (16:43 -0700)]
pspp-sheet-view: Fix bug that omitted bottom of cell grid lines.

11 years agoReplaced the splash screen with a new one 20130728030502/pspp
John Darrington [Sat, 27 Jul 2013 20:04:11 +0000 (22:04 +0200)]
Replaced the splash screen with a new one

11 years agoReplace legacy application icon by new one
John Darrington [Sat, 27 Jul 2013 15:54:06 +0000 (17:54 +0200)]
Replace legacy application icon by new one

11 years agoMake distcheck pass
John Darrington [Sat, 27 Jul 2013 15:04:38 +0000 (17:04 +0200)]
Make distcheck pass

11 years agoIntegrated the application icons 20130727030502/pspp
John Darrington [Fri, 26 Jul 2013 17:34:45 +0000 (19:34 +0200)]
Integrated the application icons

11 years agoAdded names of new artwork contributors to about dialog 20130726030501/pspp
John Darrington [Thu, 25 Jul 2013 20:23:48 +0000 (22:23 +0200)]
Added names of new artwork contributors to about dialog

11 years agoAdded mimetype icons
John Darrington [Thu, 25 Jul 2013 18:50:17 +0000 (20:50 +0200)]
Added mimetype icons

Added some icons to represent pspp file types in file managers etc.

11 years agoUse "auto" mode for parsing syntax in the GUI (and elsewhere). 20130724030505/pspp 20130725030502/pspp
Ben Pfaff [Wed, 24 Jul 2013 05:13:34 +0000 (22:13 -0700)]
Use "auto" mode for parsing syntax in the GUI (and elsewhere).

This should be less surprising, I hope, than always parsing syntax in
"interactive" mode.

Reported by Ronald Crichton <Ronald.Crichton@cit.edu.au>.

11 years agoChange "variable_changed" to "variable-changed" in signal name
John Darrington [Tue, 23 Jul 2013 20:05:18 +0000 (22:05 +0200)]
Change "variable_changed" to "variable-changed" in signal name

This makes it consistent with usage elsewhere.

11 years agopo: Update Dutch translation from translationproject.org.
Ben Pfaff [Wed, 24 Jul 2013 04:17:36 +0000 (21:17 -0700)]
po: Update Dutch translation from translationproject.org.

11 years agoFix crash when changing variable formats in data import dialog.
John Darrington [Tue, 23 Jul 2013 19:47:38 +0000 (21:47 +0200)]
Fix crash when changing variable formats in data import dialog.

Recent changes altered the CHANGE_VARIABLE signal handler signature,
but this handler had not been updated.

Reported-by: dr soumalya ray <drsoumalya-ray@yahoo.co.in>
11 years agoUpdate version number to 0.8.0.
Ben Pfaff [Tue, 23 Jul 2013 13:58:56 +0000 (06:58 -0700)]
Update version number to 0.8.0.

11 years agoUpdated localisations from translation-project.org
Ben Pfaff [Tue, 23 Jul 2013 05:06:08 +0000 (22:06 -0700)]
Updated localisations from translation-project.org

11 years agoREGRESSION: Fix issues found by by review 20130719030506/pspp 20130720030502/pspp 20130721030502/pspp 20130722030502/pspp 20130723030502/pspp
John Darrington [Wed, 17 Jul 2013 14:12:07 +0000 (16:12 +0200)]
REGRESSION: Fix issues found by by review

Ben reported following potential problems:

I think that if the DEPENDENT subcommand is given twice (a user error), then
the variables specified the first time will be silently leaked.

cmd_regression() has two local variables named 'i'.

I don't understand why "struct workspace" has a member 'psw' that is a
dynamically allocated array, because it looks like each element of the array
is used only during processing a single split file group.  That is, I think
that 'psw' could be just a singleton, instead of an array.

I think that fill_all_vars() is wrong: if an absent var follows a not-absent
var, then vars[] will be filled with a gap and there will be a write into
unallocated memory.

Reported-by: Ben Pfaff
Avoids shadowing variable in lower scope.  suggested by Ben Pfaff

11 years agoconfigure.ac: Increase version number to 0.7.11. 20130714030503/pspp 20130715030502/pspp 20130716030502/pspp 20130717030502/pspp
Ben Pfaff [Sun, 14 Jul 2013 05:05:09 +0000 (22:05 -0700)]
configure.ac: Increase version number to 0.7.11.

11 years agoONEWAY: Fix memory leak in run_oneway.
Ben Pfaff [Sat, 13 Jul 2013 15:44:48 +0000 (08:44 -0700)]
ONEWAY: Fix memory leak in run_oneway.

Bug #39070.