pspp
7 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Sun, 14 Aug 2016 05:51:36 +0000 (07:51 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

Conflicts:
src/ui/gui/psppire-data-window.c

7 years agoFix compiler warning
John Darrington [Sun, 14 Aug 2016 05:47:48 +0000 (07:47 +0200)]
Fix compiler warning

7 years agoFix bug where the gui was unresponsive after starting with a file as command line...
John Darrington [Sun, 14 Aug 2016 05:38:15 +0000 (07:38 +0200)]
Fix bug where the gui was unresponsive after starting with a file as command line argument

7 years agoImprove the conversion to and from cell values
John Darrington [Sat, 13 Aug 2016 18:15:42 +0000 (20:15 +0200)]
Improve the conversion to and from cell values

7 years agoNew module value-variant
John Darrington [Sat, 13 Aug 2016 14:39:58 +0000 (16:39 +0200)]
New module value-variant

7 years agoFix bug inadvertently introduced by previous commit
John Darrington [Sat, 13 Aug 2016 07:13:42 +0000 (09:13 +0200)]
Fix bug inadvertently introduced by previous commit

7 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Sat, 13 Aug 2016 06:30:07 +0000 (08:30 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

7 years agoNew option --no-unique
John Darrington [Sat, 13 Aug 2016 06:25:03 +0000 (08:25 +0200)]
New option --no-unique

7 years agoAUTORECODE now optionally accepts / before INTO
John Darrington [Sat, 13 Aug 2016 05:29:30 +0000 (07:29 +0200)]
AUTORECODE now optionally accepts / before INTO

Fixes Bug #48762

7 years agoAdd markup to the option description strings
John Darrington [Fri, 12 Aug 2016 18:58:03 +0000 (20:58 +0200)]
Add markup to the option description strings

7 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Fri, 12 Aug 2016 16:40:23 +0000 (18:40 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

7 years agoFix GtkCriticals when --no-splash is given
John Darrington [Fri, 12 Aug 2016 16:22:14 +0000 (18:22 +0200)]
Fix GtkCriticals when --no-splash is given

7 years agoFix potential null pointer dereference
John Darrington [Fri, 12 Aug 2016 04:53:35 +0000 (06:53 +0200)]
Fix potential null pointer dereference

Found by cppcheck

7 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Fri, 12 Aug 2016 04:43:40 +0000 (06:43 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

7 years agoFix possible null pointer dereference
John Darrington [Thu, 11 Aug 2016 20:11:38 +0000 (22:11 +0200)]
Fix possible null pointer dereference

7 years agoFix possible null pointer dereference.
John Darrington [Thu, 11 Aug 2016 19:52:52 +0000 (21:52 +0200)]
Fix possible null pointer dereference.

Found by cppcheck

7 years agoAvoid unnecessary test
John Darrington [Thu, 11 Aug 2016 19:26:51 +0000 (21:26 +0200)]
Avoid unnecessary test

7 years agoFix possible buffer overrun
John Darrington [Thu, 11 Aug 2016 19:19:36 +0000 (21:19 +0200)]
Fix possible buffer overrun

Found by cppcheck

7 years agoRemove redundant "break"
John Darrington [Thu, 11 Aug 2016 18:59:22 +0000 (20:59 +0200)]
Remove redundant "break"

7 years agoRemove unused code
John Darrington [Wed, 10 Aug 2016 19:47:28 +0000 (21:47 +0200)]
Remove unused code

7 years agoRe-enable the goto-case dialog
John Darrington [Wed, 10 Aug 2016 19:44:52 +0000 (21:44 +0200)]
Re-enable the goto-case dialog

7 years agoAvoid compiler warning
John Darrington [Wed, 10 Aug 2016 17:19:10 +0000 (19:19 +0200)]
Avoid compiler warning

7 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Wed, 10 Aug 2016 05:51:08 +0000 (07:51 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

7 years agoFix compiler warning whilst building perl module
John Darrington [Wed, 10 Aug 2016 05:47:51 +0000 (07:47 +0200)]
Fix compiler warning whilst building perl module

7 years agoInitialise iter stamp and fix compiler warning
John Darrington [Tue, 9 Aug 2016 23:21:57 +0000 (01:21 +0200)]
Initialise iter stamp and fix compiler warning

7 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Tue, 9 Aug 2016 23:03:58 +0000 (01:03 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

7 years agoRemove call to deprecated gtk_style_context_get_font
John Darrington [Tue, 9 Aug 2016 23:02:07 +0000 (01:02 +0200)]
Remove call to deprecated gtk_style_context_get_font

7 years agoFail more gracefully when selecting cells out of range
John Darrington [Mon, 8 Aug 2016 21:01:41 +0000 (23:01 +0200)]
Fail more gracefully when selecting cells out of range

7 years agoEnable the Cut menuitem
John Darrington [Mon, 8 Aug 2016 19:19:56 +0000 (21:19 +0200)]
Enable the Cut menuitem

7 years agoFix compiler warning
John Darrington [Mon, 8 Aug 2016 18:52:06 +0000 (20:52 +0200)]
Fix compiler warning

7 years agoEnable the Edit Copy functionality
John Darrington [Sun, 7 Aug 2016 13:56:50 +0000 (15:56 +0200)]
Enable the Edit Copy functionality

7 years agoMerge branch 'master' into sheet
John Darrington [Sun, 7 Aug 2016 07:26:22 +0000 (09:26 +0200)]
Merge branch 'master' into sheet

7 years agoRemove obsolete file
John Darrington [Sun, 7 Aug 2016 06:02:47 +0000 (08:02 +0200)]
Remove obsolete file

7 years agoRe-enable the gridlines toggle and mark some other commented code with SHEET_MERGE
John Darrington [Sun, 7 Aug 2016 05:57:54 +0000 (07:57 +0200)]
Re-enable the gridlines toggle and mark some other commented code with SHEET_MERGE

7 years agoFix compiler warning
John Darrington [Sat, 6 Aug 2016 18:53:43 +0000 (20:53 +0200)]
Fix compiler warning

7 years agoFix compiler warning
John Darrington [Sat, 6 Aug 2016 18:54:22 +0000 (20:54 +0200)]
Fix compiler warning

7 years agoFix compiler warning
John Darrington [Sat, 6 Aug 2016 18:53:43 +0000 (20:53 +0200)]
Fix compiler warning

7 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Sat, 6 Aug 2016 17:40:31 +0000 (19:40 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

Conflicts:
src/ui/gui/automake.mk
src/ui/gui/psppire-data-editor.c
src/ui/gui/psppire-data-sheet.c
src/ui/gui/psppire-var-sheet.c

7 years agoRemove deprecated objects GtkAction and GtkUIManager
John Darrington [Sat, 6 Aug 2016 08:01:17 +0000 (10:01 +0200)]
Remove deprecated objects GtkAction and GtkUIManager

Instead use GAction and GMenuModel.  A lot of other code needed to be adjusted too.

7 years agoFix buffer overrun in sys-file-reader.c(text_match)
John Darrington [Sat, 6 Aug 2016 02:45:26 +0000 (04:45 +0200)]
Fix buffer overrun in sys-file-reader.c(text_match)

Found by valgrind

7 years agoAdd hu.po and update translations from translationproject.org
John Darrington [Mon, 1 Aug 2016 05:24:01 +0000 (07:24 +0200)]
Add hu.po and update translations from translationproject.org

7 years agoFix memory leak when T-TEST failed to parse
John Darrington [Sun, 31 Jul 2016 15:16:45 +0000 (17:16 +0200)]
Fix memory leak when T-TEST failed to parse

7 years agoFix memory leak in test program
John Darrington [Sun, 31 Jul 2016 13:47:06 +0000 (15:47 +0200)]
Fix memory leak in test program

7 years agoFix possible crash if no buttons are active (should never be the case)
John Darrington [Sat, 30 Jul 2016 14:09:18 +0000 (16:09 +0200)]
Fix possible crash if no buttons are active (should never be the case)

Found by cppcheck

7 years agoRemove unused variable.
John Darrington [Sat, 30 Jul 2016 14:08:00 +0000 (16:08 +0200)]
Remove unused variable.

Found by cppcheck.

7 years agoRemove PsppireVButtonBox and PsppireHButtonBox
John Darrington [Sat, 30 Jul 2016 05:19:40 +0000 (07:19 +0200)]
Remove PsppireVButtonBox and PsppireHButtonBox

Instead, use the orientable property of the ancester GtkButtonBox

7 years agorange-set-test: Remove special case for llvm-gcc on Mac OS.
Ben Pfaff [Wed, 27 Jul 2016 03:39:24 +0000 (20:39 -0700)]
range-set-test: Remove special case for llvm-gcc on Mac OS.

According to Jeremy Lavergne, recent llvm-gcc doesn't have the same bug.

7 years agoIncrement version number to 0.10.3.
Ben Pfaff [Mon, 25 Jul 2016 18:13:58 +0000 (11:13 -0700)]
Increment version number to 0.10.3.

7 years agoAllow the variable info dialog to paste more than one variables.
John Darrington [Sat, 23 Jul 2016 07:03:58 +0000 (09:03 +0200)]
Allow the variable info dialog to paste more than one variables.

Fixes bug #48596

7 years agoFix compiler warning on gcc 5.4
John Darrington [Thu, 14 Jul 2016 18:35:51 +0000 (20:35 +0200)]
Fix compiler warning on gcc 5.4

7 years agoReplace gtk_widget_get_style in favour of gtk_widget_get_style_context
John Darrington [Mon, 11 Jul 2016 19:51:42 +0000 (21:51 +0200)]
Replace gtk_widget_get_style in favour of gtk_widget_get_style_context

7 years agoLogistic Regression syntax generator: replace ds_data with ds_cstr
John Darrington [Mon, 11 Jul 2016 18:51:18 +0000 (20:51 +0200)]
Logistic Regression syntax generator: replace ds_data with ds_cstr

ds_data does not produce a terminating null.  So garbage could be appended at the end of the command.

Fixes bug #48467

7 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Sun, 10 Jul 2016 05:47:34 +0000 (07:47 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

7 years agoUpdate NEWS
John Darrington [Thu, 7 Jul 2016 05:07:05 +0000 (07:07 +0200)]
Update NEWS

7 years agoFixed GLM vs. missing values in the dependent variable
John Darrington [Thu, 23 Jun 2016 08:07:23 +0000 (10:07 +0200)]
Fixed GLM vs. missing values in the dependent variable

7 years agoFixed typo in comment
John Darrington [Thu, 23 Jun 2016 07:13:53 +0000 (09:13 +0200)]
Fixed typo in comment

7 years agoAvoid link error when compiling without libxml2 installed
John Darrington [Wed, 22 Jun 2016 05:09:58 +0000 (07:09 +0200)]
Avoid link error when compiling without libxml2 installed

7 years agoUpdate the Gnulib version
John Darrington [Sun, 19 Jun 2016 11:36:48 +0000 (13:36 +0200)]
Update the Gnulib version

The primary motive for doing this is to update gl/version_etc which changes
the copyright year to 2016.  This is the value which gets displayed by --version
I do not think it is ideal that we must update gnulib to get the current year
in our version string, but I did not design this aspect of the code.

7 years agoFixed a small bug in te variable info dialog.
John Darrington [Sun, 12 Jun 2016 07:03:33 +0000 (09:03 +0200)]
Fixed a small bug in te variable info dialog.

7 years agoadded FREQUENCIES regression test for bug#48128
Friedrich Beckmann [Wed, 8 Jun 2016 18:22:00 +0000 (20:22 +0200)]
added FREQUENCIES regression test for bug#48128

FREQUENCIES command crashed in a combination of /histogram /percentiles
and /statistics option. This was fixed in commit 86642e. Here a crash
test is added exactly for this situation.

7 years agosrc/output.tab.c: Format according to Gnu Coding Standards
John Darrington [Tue, 7 Jun 2016 18:44:13 +0000 (20:44 +0200)]
src/output.tab.c: Format according to Gnu Coding Standards

7 years agotab.c: Compile error in debug mode
Friedrich Beckmann [Sat, 4 Jun 2016 22:44:26 +0000 (00:44 +0200)]
tab.c: Compile error in debug mode

tab.c could not be compile with --enable-debug configuration because
the return value did not fit with the function. In addition a typo in
a "bad cell" check was fixed.

7 years agofrequencies: fixed bug #48128 in percentiles
Friedrich Beckmann [Sat, 4 Jun 2016 22:41:05 +0000 (00:41 +0200)]
frequencies: fixed bug #48128 in percentiles

The frequencies command crashed with a certain combination of
percentiles and histogram options. The bug was reported by
Cubyrk Zyrvay in
http://lists.gnu.org/archive/html/bug-gnu-pspp/2016-06/msg00000.html

Closes bug #48128

7 years agoRecode Dialog Action: Split into RecodeDialogAction, RecodeDialogActionSame and Recod...
John Darrington [Sun, 29 May 2016 08:48:24 +0000 (10:48 +0200)]
Recode Dialog Action: Split into RecodeDialogAction, RecodeDialogActionSame and RecodeDialogActionDifferent

7 years agoNEWS: added online help feature and T-Test gui bug for 0.10.2 version
Friedrich Beckmann [Sun, 29 May 2016 20:18:04 +0000 (22:18 +0200)]
NEWS: added online help feature and T-Test gui bug for 0.10.2 version

7 years agohelp-menu.c: start the default html browser via wscript instead of cmd
Friedrich Beckmann [Sat, 28 May 2016 09:42:30 +0000 (11:42 +0200)]
help-menu.c: start the default html browser via wscript instead of cmd

Harry mentioned that starting help via cmd shows the command window for
a short time on windows. With this patch the default html browser is
started via wscript instead of cmd /C <uri>.

Unfortunatly the nice function  g_app_info_launch_default_for_uri does
not work, at least on osx and windows.

7 years agoWhitespace changes only
John Darrington [Sat, 28 May 2016 06:01:54 +0000 (08:01 +0200)]
Whitespace changes only

7 years agoIndependent Samples Gui: Make the on_grp_var function and associated code less naive.
John Darrington [Sat, 28 May 2016 05:59:57 +0000 (07:59 +0200)]
Independent Samples Gui: Make the on_grp_var function and associated code less naive.

Addresses bug #48015

7 years agohelp-menu.c: fix default html browser start on windows - correct uri
Friedrich Beckmann [Thu, 26 May 2016 11:05:33 +0000 (13:05 +0200)]
help-menu.c: fix default html browser start on windows - correct uri

commit #6c9aaa introduced calling the default html browser in case the
yelp system is not available on the system. This patch fixes a
problem on WINDOWS, where the browser did not open. The problem is
that on windows the "start" command is not a regular executable but
a part of the cmd shell. So the executable that has to be called is
"cmd" with start as a parameter to execute. There is an additional
problem on windows that the "Program Files" directory contains a
space in the path name. For a proper uri, this has to be
translated to Program%20Files. This is done via the
g_filename_to_uri function.

8 years agoscatterplot: changed colorscheme - first color is black - fixes bug#47806
Friedrich Beckmann [Mon, 23 May 2016 20:00:38 +0000 (22:00 +0200)]
scatterplot: changed colorscheme - first color is black - fixes bug#47806

The default data colour palette choses light colors (yellow). This patch
selects black if no BY variable is selected for the scatterplot. Having
a special colour palette for scatterplot will interfere with the legend
coloring scheme. That would need more changes to have data points and
legend having the same color palette.

8 years agoadded help function via html if yelp is not installed
Friedrich Beckmann [Mon, 23 May 2016 15:51:54 +0000 (17:51 +0200)]
added help function via html if yelp is not installed

The current help system requires yelp to be installed. This patch
will fallback to local html help and then internet html help via
http://www.gnu.org/software/pspp if no html is installed. The browser
is invoked via open (MAC), start (windows) and xdg-open (linux)

8 years agoRevert "adding osx application bundler scripts"
Friedrich Beckmann [Sun, 22 May 2016 22:11:53 +0000 (00:11 +0200)]
Revert "adding osx application bundler scripts"

This reverts commit c2c8832630ad1619cd8e1769da3a294a1d35d1ed.

This interferes with distribution check...

8 years agoadding osx application bundler scripts
Friedrich Beckmann [Sun, 22 May 2016 21:01:37 +0000 (23:01 +0200)]
adding osx application bundler scripts

This adds a utility script which produces a mac application bundle
based on the macports installation of pspp. The application bundle
can then be distributed as a single file and can be installed exactly
like a usual mac application. This is easier for mac users as they
do not need to install XCode, macports, XQuartz but just this package.

8 years agoFix bug in syntax parser of GET DATA /TYPE=TXT
John Darrington [Thu, 21 Apr 2016 10:39:36 +0000 (12:39 +0200)]
Fix bug in syntax parser of GET DATA /TYPE=TXT

Fixed a bug which manifested itself when GET DATA /TYPE=TXT was
passed a variable name which happened also to be a token identifier.
The actual bug might also have caused other ill effects, but seems
to have been masked.

Reported-by: Rob L
8 years agoFix compiler warning
John Darrington [Mon, 11 Apr 2016 17:12:59 +0000 (19:12 +0200)]
Fix compiler warning

8 years agoCROSSTABS: Implement COUNT subcommand to round case or cell weights.
Ben Pfaff [Mon, 11 Apr 2016 01:50:12 +0000 (18:50 -0700)]
CROSSTABS: Implement COUNT subcommand to round case or cell weights.

Bug #47547.
Requested by Harry Thijssen.

8 years agotests: Fix error message when using a wrapper for the first time.
Ben Pfaff [Mon, 11 Apr 2016 00:45:13 +0000 (17:45 -0700)]
tests: Fix error message when using a wrapper for the first time.

8 years agoFILE HANDLE: Get rid of use of q2c preprocessor.
Ben Pfaff [Mon, 11 Apr 2016 00:44:53 +0000 (17:44 -0700)]
FILE HANDLE: Get rid of use of q2c preprocessor.

8 years agoChange warning about test versions.
John Darrington [Sat, 9 Apr 2016 08:20:23 +0000 (10:20 +0200)]
Change warning about test versions.

The consensus was that this warning was too strong.  These change makes
it somewhat weaker.

8 years agoMerge remote-tracking branch 'origin/master' into sheet
John Darrington [Thu, 7 Apr 2016 11:30:01 +0000 (13:30 +0200)]
Merge remote-tracking branch 'origin/master' into sheet

8 years agoFixed crash on FLIP vs. invalid variable names.
John Darrington [Wed, 6 Apr 2016 07:38:56 +0000 (09:38 +0200)]
Fixed crash on FLIP vs. invalid variable names.

FLIP would crash if the designated new names were not
valid names.  For example "TO", "BY", "" etc.

Found by zzuf.

8 years agoFixed a crash when data for correlations was empty.
John Darrington [Tue, 5 Apr 2016 19:08:50 +0000 (21:08 +0200)]
Fixed a crash when data for correlations was empty.

Found by zzuf.

8 years agoAdd test for PERMISSIONS with bad syntax
John Darrington [Tue, 5 Apr 2016 18:01:35 +0000 (20:01 +0200)]
Add test for PERMISSIONS with bad syntax

8 years agoFix crash in T-Test after parsing a null terminated string.
John Darrington [Mon, 4 Apr 2016 11:42:21 +0000 (13:42 +0200)]
Fix crash in T-Test after parsing a null terminated string.

Found by zzuf.

8 years agotests: Fix a deeper bug in null byte check in testsuite.
Ben Pfaff [Sun, 3 Apr 2016 18:52:55 +0000 (11:52 -0700)]
tests: Fix a deeper bug in null byte check in testsuite.

Thanks to Jeremy Lavergne for reporting the problem.

8 years agotests: Fix bug in null byte check in testsuite.
Ben Pfaff [Sun, 3 Apr 2016 18:20:27 +0000 (11:20 -0700)]
tests: Fix bug in null byte check in testsuite.

Thanks to Jeremy Lavergne for reporting the problem.

8 years agoUpdate version number to 0.10.2.
Ben Pfaff [Sun, 3 Apr 2016 03:50:51 +0000 (20:50 -0700)]
Update version number to 0.10.2.

8 years agoRelease PSPP 0.10.1.
Ben Pfaff [Sun, 3 Apr 2016 03:37:15 +0000 (20:37 -0700)]
Release PSPP 0.10.1.

8 years agolexer: Treat null characters in input as spaces.
Ben Pfaff [Sun, 3 Apr 2016 00:53:52 +0000 (17:53 -0700)]
lexer: Treat null characters in input as spaces.

In some circumstances nulls could confuse the lexer and cause crashes.

Thanks to John Darrington for reporting the problem.

Bug #47602.

8 years agolexer: Add comments and update style in lex_source_get__().
Ben Pfaff [Sat, 2 Apr 2016 23:41:13 +0000 (16:41 -0700)]
lexer: Add comments and update style in lex_source_get__().

8 years agoCROSSTABS: Fix corner case in integer mode.
Ben Pfaff [Sat, 2 Apr 2016 18:09:15 +0000 (11:09 -0700)]
CROSSTABS: Fix corner case in integer mode.

I'm not really sure what I was thinking when I wrote this code, but the
off-by-one errors could cause a crash.

Thanks to John Darrington for reporting the problem.

Bug #47600.

8 years agoDocumentation: Update copyright notice to reflect recent changes
John Darrington [Sat, 2 Apr 2016 08:21:09 +0000 (10:21 +0200)]
Documentation: Update copyright notice to reflect recent changes

8 years agoFix date format tests when running under wine
John Darrington [Sat, 2 Apr 2016 04:01:43 +0000 (06:01 +0200)]
Fix date format tests when running under wine

8 years agoReplace valgrind-wrapper with a generic wrapper.
Ben Pfaff [Sat, 2 Apr 2016 03:12:29 +0000 (05:12 +0200)]
Replace valgrind-wrapper with a generic wrapper.

One potential use is to run tests under an emulator such as wine.

8 years agolexer.h: Add WARN_UNUSED_RESULT to lex_force functions.
John Darrington [Fri, 1 Apr 2016 13:38:37 +0000 (15:38 +0200)]
lexer.h: Add WARN_UNUSED_RESULT to lex_force functions.

There does not seem to be any sensible and safe use of these
functions unless the return value is used somehow.

8 years agoCheck the return value of various calls to lex_force_match.
John Darrington [Fri, 1 Apr 2016 10:16:15 +0000 (12:16 +0200)]
Check the return value of various calls to lex_force_match.

8 years agooutput.c: cmd_output: Check return values of lex_force_match
John Darrington [Fri, 1 Apr 2016 09:44:17 +0000 (11:44 +0200)]
output.c: cmd_output: Check return values of lex_force_match

8 years agovariable-display.c (cmd_variable_level): Check return value of lex_force_match
John Darrington [Fri, 1 Apr 2016 09:37:02 +0000 (11:37 +0200)]
variable-display.c (cmd_variable_level): Check return value of lex_force_match

8 years agovalue-parser.c (parse_number): Simplified logic and removed redundant lines.
John Darrington [Fri, 1 Apr 2016 09:30:44 +0000 (11:30 +0200)]
value-parser.c (parse_number): Simplified logic and removed redundant lines.

8 years agoFix crash in NPAR when no variables were parsed.
John Darrington [Thu, 31 Mar 2016 20:27:52 +0000 (22:27 +0200)]
Fix crash in NPAR when no variables were parsed.

Found by zzuf.