Ben Pfaff [Sat, 9 Oct 2010 03:59:10 +0000 (20:59 -0700)]
perl-module: Fix build race.
perl_module_tarball invokes module-make in a submake. In turn, until now
module-make has depended on src/libpspp-core.la. But if a parallel build
is in progress, then the parent make is likely also building the same
library. Sometimes the race in linking this library causes build failures.
The ideal solution would be to avoid the submake. We could do this, by
giving the files in the build different names from those in the source
directory (e.g. distributing the files with .dist extensions, or copying
them into or out of a subdirectory).
This commit instead implements a minimal fix, by making the dependency on
src/libpspp-core.la part of the top-level perl_module_tarball target,
instead of part of the submake's module-make target.
With this commit, 10 consecutive test runs on my laptop completed
successfully. Without this commit, about 50% of nontrivial builds fail.
Ben Pfaff [Sat, 9 Oct 2010 03:24:14 +0000 (20:24 -0700)]
tests: Distribute testsuite.at and loosen its dependencies.
testsuite.at has to be distributed or "make" from a distributed tarball
will have to make it, which means that the system used for building needs
Autoconf installed and will need to write to the source directory.
testsuite.at cannot depend on the Makefile or it will have to be rebuilt
every time "configure" runs, which would also cause the problems mentioned
above.
Ben Pfaff [Sat, 9 Oct 2010 03:20:26 +0000 (20:20 -0700)]
perl-module: Use ABSTRACT instead of ABSTRACT_FROM in Makefile.PL.
This fixes the following warning from Perl:
WARNING: Setting ABSTRACT via file 'lib/PSPP.pm' failed
at /usr/share/perl/5.10/ExtUtils/MakeMaker.pm line 583
Ben Pfaff [Wed, 6 Oct 2010 04:59:17 +0000 (21:59 -0700)]
tests: Convert tab handling test to Autotest framework.
Ben Pfaff [Wed, 6 Oct 2010 03:39:53 +0000 (20:39 -0700)]
EXAMINE: Convert another test to Autotest framework.
Ben Pfaff [Tue, 5 Oct 2010 05:10:48 +0000 (22:10 -0700)]
T-TEST: Convert tests to Autotest framework.
Ben Pfaff [Tue, 5 Oct 2010 04:33:03 +0000 (21:33 -0700)]
SPLIT FILE: Convert test to Autotest framework.
Ben Pfaff [Tue, 5 Oct 2010 04:30:14 +0000 (21:30 -0700)]
SYSFILE INFO: Convert test to Autotest framework.
Ben Pfaff [Tue, 5 Oct 2010 04:28:50 +0000 (21:28 -0700)]
tests: Remove tests/command/sysfiles-old.sh from list of tests.
This file was deleted in a previous commit but it was still listed in
tests/automake.mk.
Ben Pfaff [Tue, 5 Oct 2010 00:33:55 +0000 (17:33 -0700)]
tests: Convert system file tests to Autotest framework.
Ben Pfaff [Tue, 5 Oct 2010 00:23:28 +0000 (17:23 -0700)]
SORT CASES: Convert tests to Autotest framework.
Ben Pfaff [Mon, 4 Oct 2010 22:27:36 +0000 (15:27 -0700)]
SAMPLE: Convert test to Autotest framework.
Ben Pfaff [Mon, 4 Oct 2010 22:08:29 +0000 (15:08 -0700)]
ROC: Convert tests to Autotest framework.
Ben Pfaff [Mon, 4 Oct 2010 21:59:48 +0000 (14:59 -0700)]
RELIABILITY: Convert tests to Autotest framework.
Ben Pfaff [Mon, 4 Oct 2010 19:49:05 +0000 (12:49 -0700)]
tests: Convert REGRESSION tests to Autotest framework.
Ben Pfaff [Mon, 4 Oct 2010 19:38:06 +0000 (12:38 -0700)]
RENAME VARIABLES: Convert tests to Autotest framework.
John Darrington [Mon, 4 Oct 2010 19:47:44 +0000 (21:47 +0200)]
Fix bug in autorecode - strings vs. /group
Fixed a bug which caused autorecode to crash when the /GROUP
subcommand was used concurrently with variables of different widths.
John Darrington [Mon, 4 Oct 2010 17:37:08 +0000 (19:37 +0200)]
Workaround for gettext deficiencies
xgettext doesn't have a --language=gtkbuilder option.
Instead, we've been (mis)using --language=glade which
has worked ok except that it doesn't extract labels
from the columns of GtkListStore items.
This change adds a pair of dummy widgets containing identical
label strings so that these strings will get entered into
the .pot file. Closes bug #31033
Ben Pfaff [Mon, 4 Oct 2010 18:25:25 +0000 (11:25 -0700)]
RANK: Convert tests to Autotest framework.
Ben Pfaff [Mon, 4 Oct 2010 03:36:33 +0000 (20:36 -0700)]
pspp: Fix crash passing the name of a nonexistent file on the command line.
Also adds a test.
Ben Pfaff [Mon, 4 Oct 2010 03:35:33 +0000 (20:35 -0700)]
pspp: Make style slightly more like the rest of the program.
Ben Pfaff [Sun, 3 Oct 2010 22:45:44 +0000 (15:45 -0700)]
Convert PRINT and WRITE tests to Autotest framework.
Ben Pfaff [Sun, 3 Oct 2010 15:06:50 +0000 (08:06 -0700)]
PERMISSIONS: Convert test to Autotest framework.
Ben Pfaff [Sun, 3 Oct 2010 12:42:58 +0000 (05:42 -0700)]
NPAR TESTS: Convert SIGN test to Autotest framework.
Ben Pfaff [Sun, 3 Oct 2010 12:41:05 +0000 (05:41 -0700)]
NPAR TESTS: Convert WILCOXON tests to Autotest framework.
Ben Pfaff [Sun, 3 Oct 2010 12:37:39 +0000 (05:37 -0700)]
NPAR TESTS: Convert CHISQUARE tests to Autotest framework.
John Darrington [Sun, 3 Oct 2010 12:41:54 +0000 (14:41 +0200)]
Update generated HTML to conform to W3C standards.
Changed the html output driver so that the generated
HTML is accepted by http://validator.w3.org
John Darrington [Sun, 3 Oct 2010 12:11:01 +0000 (14:11 +0200)]
Added gettext markup to some strings which required it
John Darrington [Sun, 3 Oct 2010 11:56:02 +0000 (13:56 +0200)]
Undo inappropriate quote substitution in generated HTML.
Commit
173d1687aea88e0e5e1b1d8615ed68ebefb15d08 erroneously
substituted these quotes in html fragments.
John Darrington [Sun, 3 Oct 2010 11:16:36 +0000 (13:16 +0200)]
Consolidate translatable strings
John Darrington [Sun, 3 Oct 2010 10:45:06 +0000 (12:45 +0200)]
Remove erroneous CONST_CAST
Commit
97f9b8ad137e333af9b3c767556d28dfda93a461 attempted to use CONST_CAST to
avoid a compiler warning about constness. However it applies at the wrong
level of deference. This change undoes that particular problem and reverts
to the original cast.
John Darrington [Sun, 3 Oct 2010 10:37:30 +0000 (12:37 +0200)]
Constness
John Darrington [Sun, 3 Oct 2010 10:25:00 +0000 (12:25 +0200)]
Fix memory leaks in ROC command
John Darrington [Sun, 3 Oct 2010 10:23:18 +0000 (12:23 +0200)]
Add comments informing the caller about side effects
John Darrington [Sun, 3 Oct 2010 08:41:36 +0000 (10:41 +0200)]
Consistently use the return value from case_ref.
This makes debugging easier.
Ben Pfaff [Sat, 2 Oct 2010 22:01:54 +0000 (15:01 -0700)]
NPAR TESTS: Convert BINOMAL tests to Autotest framework.
Ben Pfaff [Sat, 2 Oct 2010 21:32:14 +0000 (14:32 -0700)]
N OF CASES: Convert test to Autotest framework.
Ben Pfaff [Sat, 2 Oct 2010 21:29:37 +0000 (14:29 -0700)]
tests: Convert no_case_size.sh test to Autotest framework.
Ben Pfaff [Sat, 2 Oct 2010 20:51:44 +0000 (13:51 -0700)]
MISSING VALUES: Convert test to Autotest framework.
Ben Pfaff [Sat, 2 Oct 2010 20:42:33 +0000 (13:42 -0700)]
MATCH FILES: Convert tests to Autotest framework.
Ben Pfaff [Sat, 2 Oct 2010 20:03:28 +0000 (13:03 -0700)]
tests: Convert longvar.sh test to Autotest framework.
Ben Pfaff [Sat, 2 Oct 2010 19:01:50 +0000 (12:01 -0700)]
pspp: Avoid printing multiple messages for a single signal caused by a bug.
When I tested commit
38f3d1b22 "pspp: Make a signal that indicates a bug
re-raise that signal to exit" I didn't read the output carefully enough.
John Darrington pointed out the problem.
Ben Pfaff [Sat, 2 Oct 2010 17:50:32 +0000 (10:50 -0700)]
LOOP: Convert tests to Autotest framework.
Ben Pfaff [Sat, 2 Oct 2010 17:21:21 +0000 (10:21 -0700)]
pspp: Make a signal that indicates a bug re-raise that signal to exit.
John Darrington pointed out that exiting with EXIT_FAILURE isn't nearly
emphatic enough here.
John Darrington [Sat, 2 Oct 2010 14:29:25 +0000 (16:29 +0200)]
en_GB.po: translate quotes to UTF characters
John Darrington [Sat, 2 Oct 2010 13:59:11 +0000 (15:59 +0200)]
Use macros from cast.h instead of literal casts
John Darrington [Fri, 1 Oct 2010 18:17:06 +0000 (20:17 +0200)]
Fix memory leak in LIST command.
John Darrington [Thu, 30 Sep 2010 19:49:34 +0000 (21:49 +0200)]
Fix memory leak in casegrouper. Closes bug #30764
John Darrington [Thu, 30 Sep 2010 08:59:05 +0000 (10:59 +0200)]
Fix memory leak in sweep.c
John Darrington [Thu, 30 Sep 2010 08:51:49 +0000 (10:51 +0200)]
Fix memory leak in output rendering
Ben Pfaff [Thu, 30 Sep 2010 04:44:36 +0000 (21:44 -0700)]
tests: Remove PG_CONFIG from TESTS_ENVIRONMENT.
This is no longer needed now that the PostgreSQL tests have been converted
to use Autotest.
Ben Pfaff [Thu, 30 Sep 2010 04:39:34 +0000 (21:39 -0700)]
LIST: Convert tests to use Autotest.
Ben Pfaff [Thu, 30 Sep 2010 04:31:43 +0000 (21:31 -0700)]
casereader: Fix casereader_select() with BY argument greater than 1.
This fixes the /CASES=BY subcommand on LIST. The following commit will add
a test.
Ben Pfaff [Thu, 30 Sep 2010 03:34:28 +0000 (20:34 -0700)]
DATA LIST: Convert tests for line-ends compatibility to use Autotest.
Ben Pfaff [Thu, 30 Sep 2010 03:30:24 +0000 (20:30 -0700)]
LAG: Convert tests to use Autotest.
John Darrington [Wed, 29 Sep 2010 20:02:28 +0000 (22:02 +0200)]
Replace glm with a new implementation.
The code is still not ready for use. It's awaiting
a working type 3 sum of squares.
John Darrington [Sun, 26 Sep 2010 10:13:35 +0000 (12:13 +0200)]
Disconnect clip signal handlers when a syntax window is destroyed
Ben Pfaff [Wed, 29 Sep 2010 04:32:25 +0000 (21:32 -0700)]
tests: Merge the four GET DATA /TYPE=PSQL tests into a single one.
This saves about 30 seconds on my laptop, so it seems worth it, even though
it combines tests that might better be separated.
Ben Pfaff [Wed, 29 Sep 2010 04:31:07 +0000 (21:31 -0700)]
tests: Fix typo in GET DATA /TYPE=TXT test.
Not capitalizing the at_ in AT_BANNER apparently just kept the banner
from appearing and didn't seem to cause other problems.
Ben Pfaff [Wed, 29 Sep 2010 04:30:20 +0000 (21:30 -0700)]
INSERT: Convert tests to use Autotest.
Ben Pfaff [Wed, 29 Sep 2010 04:19:59 +0000 (21:19 -0700)]
syntax-file: Open syntax files immediately, instead of delaying.
Until now, syntax files have been opened only when the first line needs to
be read. This commit changes behavior to open syntax files as soon as the
syntax file source is created.
This fixes the behavior INSERT CD=YES when a relative file path is
specified. Without this commit, INSERT checks that the file exists, then
it creates the syntax file source, then it chdirs into the syntax file's
directory, and then the syntax file source tries to open the file, which
fails because the relative path is no longer correct. With this commit,
the file gets opened before the chdir, so it succeeds.
The following commit will add a test to prevent regression.
Ben Pfaff [Wed, 29 Sep 2010 03:30:56 +0000 (20:30 -0700)]
tests: Fix distribution, by adding tests/testsuite.in to EXTRA_DIST.
Ben Pfaff [Tue, 28 Sep 2010 05:06:45 +0000 (22:06 -0700)]
tests: Convert IMPORT and EXPORT test to use Autotest.
Ben Pfaff [Tue, 28 Sep 2010 05:01:38 +0000 (22:01 -0700)]
tests: Convert GET DATA /TYPE=PSQL tests to use Autotest.
Ben Pfaff [Tue, 28 Sep 2010 04:55:17 +0000 (21:55 -0700)]
tests: Break get-data.at up into get-data-gnm.at and get-data-txt.at
Ben Pfaff [Tue, 28 Sep 2010 01:56:15 +0000 (18:56 -0700)]
DO REPEAT: Add test for missing END REPEAT.
Bug #31016.
Ben Pfaff [Tue, 28 Sep 2010 01:51:22 +0000 (18:51 -0700)]
lexer: Properly initialize lexer->prog when lex_get_line_raw() fails.
lex_get_line(), the main caller of lex_get_line_raw(), set lexer->prog to
NULL when reading failed, but other callers need to do the same thing too,
otherwise e.g. DO REPEAT accesses invalid storage when there is a missing
END REPEAT.
Bug #31016.
Ben Pfaff [Tue, 28 Sep 2010 01:49:25 +0000 (18:49 -0700)]
DO REPEAT: Report an error when END REPEAT is missing.
Bug #31016.
Ben Pfaff [Sun, 26 Sep 2010 05:25:16 +0000 (22:25 -0700)]
tests: Convert GET DATA /TYPE=GNM tests to use Autotest.
Ben Pfaff [Sun, 26 Sep 2010 03:55:24 +0000 (20:55 -0700)]
tests: Convert GET DATA /TYPE=TXT tests to use Autotest.
Ben Pfaff [Sun, 26 Sep 2010 03:23:09 +0000 (20:23 -0700)]
tests: Convert FILTER tests to use Autotest.
Ben Pfaff [Sun, 26 Sep 2010 02:46:35 +0000 (19:46 -0700)]
tests: Convert FILE HANDLE tests to use Autotest.
Ben Pfaff [Sun, 26 Sep 2010 02:42:09 +0000 (19:42 -0700)]
tests: Convert FILE LABEL, DOCUMENT, ADD DOCUMENT tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 23:56:06 +0000 (16:56 -0700)]
tests: Convert EXAMINE tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 23:38:27 +0000 (16:38 -0700)]
tests: Convert erase.sh test to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 23:33:01 +0000 (16:33 -0700)]
tests: Convert do-repeat.sh test to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 23:26:49 +0000 (16:26 -0700)]
tests: Convert do-if.sh test to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 23:20:58 +0000 (16:20 -0700)]
tests: Convert correlation.sh test to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 23:13:04 +0000 (16:13 -0700)]
tests: Convert bignum.sh test to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 22:55:16 +0000 (15:55 -0700)]
tower: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 22:45:35 +0000 (15:45 -0700)]
stringi-set: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 22:41:39 +0000 (15:41 -0700)]
string-set: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 22:37:02 +0000 (15:37 -0700)]
stringi-map: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 22:33:43 +0000 (15:33 -0700)]
string-map: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 22:17:10 +0000 (15:17 -0700)]
str: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 21:46:13 +0000 (14:46 -0700)]
sparse-array: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 21:34:46 +0000 (14:34 -0700)]
range-set: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 21:31:48 +0000 (14:31 -0700)]
range-map: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 21:27:10 +0000 (14:27 -0700)]
llx: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 21:24:47 +0000 (14:24 -0700)]
ll: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 21:14:44 +0000 (14:14 -0700)]
hmapx: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 21:07:13 +0000 (14:07 -0700)]
hmap: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 19:38:29 +0000 (12:38 -0700)]
heap: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 19:32:39 +0000 (12:32 -0700)]
bt: Convert tests to use Autotest.
Ben Pfaff [Sat, 25 Sep 2010 04:42:02 +0000 (21:42 -0700)]
abt: Convert tests to use Autotest.
John Darrington [Sat, 25 Sep 2010 11:18:04 +0000 (13:18 +0200)]
Update to latest Gnulib
John Darrington [Sat, 25 Sep 2010 09:43:23 +0000 (11:43 +0200)]
Created an additional i18n test
John Darrington [Thu, 23 Sep 2010 19:20:59 +0000 (21:20 +0200)]
tests_check target depends upon check_PROGRAMS
Ben Pfaff [Fri, 24 Sep 2010 04:03:36 +0000 (21:03 -0700)]
data-in: Get rid of first_column, last_column arguments.
Most callers can't provide this arguments, and so in the interest of
making the data_in() interface simpler, it seems better to put the
callers in charge of dealing with error messages, since they better
know their own context.
Ben Pfaff [Mon, 20 Sep 2010 04:36:58 +0000 (21:36 -0700)]
data-in: Make data_in() parameters more uniform.
data_in() essentially takes an input encoding and an output encoding but
the parameters were in inconsistent order, inconsistently named, and had
inconsistent types. This commit changes all that to, I hope, be easier to
understand.