pspp
15 years agoFixed bug inserting cases in data sheet.
John Darrington [Tue, 9 Jun 2009 11:47:08 +0000 (19:47 +0800)]
Fixed bug inserting cases in data sheet.

Cases were not being inserted in the correct position.

15 years agoFix handling of #! at beginning of PSPP syntax file; add regression test.
Ben Pfaff [Mon, 8 Jun 2009 04:57:36 +0000 (21:57 -0700)]
Fix handling of #! at beginning of PSPP syntax file; add regression test.

Fixes bug #26518.

Thanks to John Darrington for testing.

15 years agoRemove spurious Makefile from src/output.
Ben Pfaff [Sun, 7 Jun 2009 20:14:23 +0000 (13:14 -0700)]
Remove spurious Makefile from src/output.

15 years agocrosstabs: Fix chi-square display and add regression test.
Ben Pfaff [Sun, 7 Jun 2009 04:04:21 +0000 (21:04 -0700)]
crosstabs: Fix chi-square display and add regression test.

Bug #26739.

15 years agocrosstab: Remove struct that was defined but never used.
Ben Pfaff [Sun, 7 Jun 2009 03:53:10 +0000 (20:53 -0700)]
crosstab: Remove struct that was defined but never used.

15 years agocrosstabs: Remove write-only variable.
Ben Pfaff [Sun, 7 Jun 2009 03:44:49 +0000 (20:44 -0700)]
crosstabs: Remove write-only variable.

15 years agocrosstabs: Fix segfault when chi-square was requested.
Ben Pfaff [Sun, 7 Jun 2009 03:30:14 +0000 (20:30 -0700)]
crosstabs: Fix segfault when chi-square was requested.

Bug #26739.

15 years agodatasheet-test: Add support for testing string backing store columns.
Ben Pfaff [Wed, 3 Jun 2009 05:21:01 +0000 (22:21 -0700)]
datasheet-test: Add support for testing string backing store columns.

15 years agocrosstabs: Trim unsightly spaces from titles in output.
Ben Pfaff [Wed, 3 Jun 2009 04:55:50 +0000 (21:55 -0700)]
crosstabs: Trim unsightly spaces from titles in output.

Unfortunately, none of the tests exercise this code, so it's hard to say
whether it is correct.

15 years agocrosstabs: Fix memory leaks.
Ben Pfaff [Wed, 3 Jun 2009 02:52:18 +0000 (19:52 -0700)]
crosstabs: Fix memory leaks.

15 years agoargv-parser: Add assertion to find likely bugs in client code.
Ben Pfaff [Sat, 30 May 2009 04:51:45 +0000 (21:51 -0700)]
argv-parser: Add assertion to find likely bugs in client code.

15 years agodatasheet: Fix bugs in datasheet_resize_column() found with new test.
Ben Pfaff [Sat, 30 May 2009 04:51:19 +0000 (21:51 -0700)]
datasheet: Fix bugs in datasheet_resize_column() found with new test.

15 years agodatasheet-test: Add test for datasheet_resize_column().
Ben Pfaff [Sat, 30 May 2009 04:46:24 +0000 (21:46 -0700)]
datasheet-test: Add test for datasheet_resize_column().

15 years agodatasheet-test: Fix printing of string values in error messages.
Ben Pfaff [Sat, 30 May 2009 04:43:33 +0000 (21:43 -0700)]
datasheet-test: Fix printing of string values in error messages.

15 years agodatasheet-test: Check duplicate states before discarding them.
Ben Pfaff [Sat, 30 May 2009 04:26:13 +0000 (21:26 -0700)]
datasheet-test: Check duplicate states before discarding them.

By failing to check states whose hashes already appeared in the model
checker table, the datasheet test was missing some bugs.  This commit
changes the datasheet test code to check the state before it checks for
the hash.

15 years agodatasheet-test: Make column widths to test configurable on command line.
Ben Pfaff [Thu, 28 May 2009 05:22:48 +0000 (22:22 -0700)]
datasheet-test: Make column widths to test configurable on command line.

15 years agodatasheet-test: Don't test null operations.
Ben Pfaff [Sat, 30 May 2009 04:45:28 +0000 (21:45 -0700)]
datasheet-test: Don't test null operations.

By not testing null operations (such as inserting or deleting 0 rows or
columns) the duration of the test is cut roughly in half, with little if
any reduction in test coverage.

15 years agosparse-xarray-test: Style and comment fixes.
Ben Pfaff [Sat, 30 May 2009 04:50:12 +0000 (21:50 -0700)]
sparse-xarray-test: Style and comment fixes.

15 years agovalue: New function value_swap.
Ben Pfaff [Wed, 27 May 2009 06:04:32 +0000 (23:04 -0700)]
value: New function value_swap.

15 years agoMove datasheet test out of PSPP into a separate binary.
Ben Pfaff [Wed, 27 May 2009 05:02:48 +0000 (22:02 -0700)]
Move datasheet test out of PSPP into a separate binary.

When it's not difficult to do so, it is better to put tests in separate
binaries instead of in the PSPP binaries, so that the binaries are not
burdened with code that is not of real interest to users and to make the
main PSPP binaries build faster.

15 years agoMake MAX_SHORT_STRING an implementation detail of the "value" code.
Ben Pfaff [Tue, 26 May 2009 03:24:07 +0000 (20:24 -0700)]
Make MAX_SHORT_STRING an implementation detail of the "value" code.

MAX_SHORT_STRING used to be important.  It was referenced all over the
source tree.  Now, there is little reason for code outside the "value"
code itself to use it.

15 years agoUse MAX_SHORT_STRING in place of MIN_LONG_STRING.
Ben Pfaff [Tue, 26 May 2009 03:22:01 +0000 (20:22 -0700)]
Use MAX_SHORT_STRING in place of MIN_LONG_STRING.

There is no good reason to have both of these constants, so replace all
uses of MAX_LONG_STRING by MAX_SHORT_STRING.

15 years agoFix portable file reader use of long strings.
Ben Pfaff [Tue, 26 May 2009 03:21:08 +0000 (20:21 -0700)]
Fix portable file reader use of long strings.

This code hadn't been converted to the new "union value" representation,
where a single "union value" always represents a whole data item.  This
commit fixes that.

15 years agoGet rid of uses of MAX_SHORT_STRING in Gnumeric and PostgreSQL readers.
Ben Pfaff [Tue, 26 May 2009 03:20:07 +0000 (20:20 -0700)]
Get rid of uses of MAX_SHORT_STRING in Gnumeric and PostgreSQL readers.

MAX_SHORT_STRING is now intended to be an implementation detail of the
value code.  There is no real reason that the Gnumeric or PostgreSQL
readers need to use it, so make them use their own constants instead.

15 years agoImplement missing values for long string variables.
Ben Pfaff [Tue, 26 May 2009 03:07:19 +0000 (20:07 -0700)]
Implement missing values for long string variables.

15 years agoFix test failure introduced along with parse_value().
Ben Pfaff [Mon, 25 May 2009 19:36:21 +0000 (12:36 -0700)]
Fix test failure introduced along with parse_value().

15 years agosys-file-reader: Fix memory leak.
Ben Pfaff [Mon, 25 May 2009 02:36:01 +0000 (19:36 -0700)]
sys-file-reader: Fix memory leak.

15 years agoAdd support for value labels on long string variables.
Ben Pfaff [Mon, 25 May 2009 02:35:40 +0000 (19:35 -0700)]
Add support for value labels on long string variables.

15 years agoNew function parse_value() for parsing a value of specified width.
Ben Pfaff [Sun, 24 May 2009 18:26:41 +0000 (11:26 -0700)]
New function parse_value() for parsing a value of specified width.

Occasionally a value of a given width needs to be parsed from syntax.
This commit adds a helper function for doing so and modifies a few pieces
of code to use it.  Probably there are other places where it would be
useful that could not easily be found with "grep".

This commit also renames the range-parser code to value-parser and puts
the new function in there, as a natural generalization.

Suggested by John Darrington.

15 years agoMake value_set_missing(), etc. tolerate values of width -1.
Ben Pfaff [Tue, 12 May 2009 03:08:19 +0000 (20:08 -0700)]
Make value_set_missing(), etc. tolerate values of width -1.

In some circumstances a value of width -1 crops up, e.g. when a case is
made from a dictionary that has had a variable deleted in the middle.
Such a value has no content at all.  In the long run it should be possible
to get rid of these values entirely--their presence is a wart--but for now
the case and value code needs to tolerate them.

This fixes a segfault in the GUI when inserting a new case when the
datasheet case has a column with width -1 (due to deletion of a variable),
which was caused by case_set_missing() calling value_set_missing() for
the -1 width variable, which in turn was writing through an invalid
pointer.

15 years agoPrevent invalid variable widths in variable sheet.
John Darrington [Mon, 11 May 2009 23:18:31 +0000 (07:18 +0800)]
Prevent invalid variable widths in variable sheet.

15 years agoRemove debug printfs that escaped from my local tree.
Ben Pfaff [Mon, 11 May 2009 13:33:35 +0000 (06:33 -0700)]
Remove debug printfs that escaped from my local tree.

15 years agogui: Fix segfault when pushing Del on a long string variable cell.
Ben Pfaff [Mon, 11 May 2009 13:33:15 +0000 (06:33 -0700)]
gui: Fix segfault when pushing Del on a long string variable cell.

Thanks to John Darrington for reporting the problem.

15 years agoChange "union value" to dynamically allocate long strings.
Ben Pfaff [Mon, 11 May 2009 05:23:00 +0000 (22:23 -0700)]
Change "union value" to dynamically allocate long strings.

Until now, a single "union value" could hold a numeric value or a short
string value.  A long string value (one longer than MAX_SHORT_STRING)
required a number of contiguous "union value"s.  This situation was
inconvenient sometimes, because any occasion where a long string value
might be required (even if it was unlikely) required using dynamic
memory allocation.

With this change, a value of any type, regardless of whether it is numeric
or short or long string, occupies a single "union value".  The internal
representation of short and long strings is now different, however: long
strings are now internally represented by a pointer to dynamically
allocated memory.  This means that "union value"s must now be initialized
and uninitialized properly, to ensure that memory is properly allocated
and freed behind the scenese.

This change thus has a ripple effect on PSPP code that works with values.
In particular, code that deals with cases is greatly changed, because a
case now needs to know the type of each value that it contains.  Thus, a
new concept called a "case prototype", which represents the type and
width of each value within a case, is introduced, and every place in PSPP
that creates a case must now create a corresponding prototype to go with
it.  This is why this commit is so big.

As part of writing up this commit, it became clear that some code was poor
enough that it needed to be rewritten entirely.  Therefore, CROSSTABS and
T-TEST are almost completely modified by this commit.

15 years agooutput: Add auxiliary data parameter to tab_dim.
Ben Pfaff [Thu, 7 May 2009 05:58:01 +0000 (22:58 -0700)]
output: Add auxiliary data parameter to tab_dim.

Until now, the tab_dim function has not provided any way to pass auxiliary
data to the table dimensioning function.  This commit adds this ability
and updates all the callers of tab_dim to do so.

15 years agoNew data structure sparse_xarray.
Ben Pfaff [Thu, 7 May 2009 05:47:51 +0000 (22:47 -0700)]
New data structure sparse_xarray.

15 years agoNew wrapper for access to temporary files.
Ben Pfaff [Thu, 7 May 2009 03:34:14 +0000 (20:34 -0700)]
New wrapper for access to temporary files.

15 years agomodel-checker: Add command-line parser for model checking options.
Ben Pfaff [Tue, 5 May 2009 12:42:23 +0000 (05:42 -0700)]
model-checker: Add command-line parser for model checking options.

This adds a parser for command-line options to configure a set of
mc_options for running the model checker.  It is used by an upcoming test
for the sparse_xarray.  It might also make sense to break the datasheet
tests out of PSPP into a separate program using this parser.

15 years agoImplement new command-line argument parser.
Ben Pfaff [Tue, 5 May 2009 12:39:03 +0000 (05:39 -0700)]
Implement new command-line argument parser.

glibc has two option parsers, but neither one of them feels quite
right:

  - getopt_long is simple, but not modular, in that there is no
    easy way to make it accept multiple collections of options
    supported by different modules.

  - argp is more sophisticated and more complete, and hence more
    complex.  It still lacks one important feature for
    modularity: there is no straightforward way for option groups
    that are implemented independently to have separate auxiliary
    data,

The parser implemented in this commit is meant to be simple and
modular.  It is based internally on getopt_long.

The initial use for this option parser is for an upcoming commit of a test
program that has some of its own options and some from the model checker,
but it should also be appropriate for PSPP and PSPPIRE if anyone wants to
adapt them to use it.

15 years agomodel-checker: Don't discard error states.
Ben Pfaff [Tue, 5 May 2009 05:30:02 +0000 (22:30 -0700)]
model-checker: Don't discard error states.

Even if a state with an error is a duplicate, we don't want to discard it,
because then we lose information about bugs.

15 years agomodel-checker: Revise advice on checking for duplicates.
Ben Pfaff [Tue, 5 May 2009 05:27:05 +0000 (22:27 -0700)]
model-checker: Revise advice on checking for duplicates.

Until now the documentation on the model checker has advised checking for
a duplicate state before checking for consistency, but in fact this can
cause bugs to be missed if only some paths to a given state yield
incorrect results.  So revise the advice to check for consistency before
checking for a duplicate state.

15 years agomodel-checker: Add more progress functions.
Ben Pfaff [Tue, 5 May 2009 05:20:42 +0000 (22:20 -0700)]
model-checker: Add more progress functions.

The model checker supports "progress functions" that report the current
status of the model checking run.  Until now the implementation only
exported a single progress function that printed a line of dots across
stderr.  This commit moves the "fancy" progress function that was
previously part of the PSPP language code into the model checker itself
and adds an even more verbose progress function as well.

15 years agomodel-checker: Move summary printing function into model checker.
Ben Pfaff [Tue, 5 May 2009 05:33:48 +0000 (22:33 -0700)]
model-checker: Move summary printing function into model checker.

There is no reason that the model checker itself should not be able to
print a summary of its results.  Until now, this code was buried in the
PSPP language code, but the model checker itself is a better place for it.

15 years agomodel-checker: Kill dependencies and move back to libpspp.
Ben Pfaff [Fri, 24 Apr 2009 04:09:12 +0000 (21:09 -0700)]
model-checker: Kill dependencies and move back to libpspp.

Commit 95b074ff3 "Moved the datasheet testing code out of
src/{libspp,data}" moved the model-checker implementation from libpspp
into language/tests because it depended on math/moments.h and
data/val-type.h, which violates the dependency structure of the PSPP
libraries.

However, now I want to use the model checker in a test that should not
need to use anything from language/tests, so this commit eliminates these
dependencies and moves the model checker back to src/libpspp.

15 years agosparse-array: Simplify code slightly.
Ben Pfaff [Tue, 5 May 2009 04:53:07 +0000 (21:53 -0700)]
sparse-array: Simplify code slightly.

Instead of checking whether the key is in range in each caller of
find_leaf_node, do it in find_leaf_node itself.  This also allows checking
the cache before checking whether the key is in range, which might be an
optimization.

15 years agosparse-array: Improve iteration interface.
Ben Pfaff [Thu, 7 May 2009 03:22:09 +0000 (20:22 -0700)]
sparse-array: Improve iteration interface.

The sparse_array_scan function only supports iteration in the forward
direction and its interface is somewhat awkward.  This commit replaces it
by four new functions that allow iteration in both forward and reverse
directions and have a more conventional interface.

15 years agosparse-array: Use __builtin_ctzl on GCC 4.0 or later, as an optimization.
Ben Pfaff [Tue, 5 May 2009 12:51:54 +0000 (05:51 -0700)]
sparse-array: Use __builtin_ctzl on GCC 4.0 or later, as an optimization.

This should be a worthwhile optimization in many cases, because
__builtin_ctzl compiles to a single machine instruction on x86, whereas
the generic implementation compiles to several.

15 years agorange-set: New functions range_set_last and range_set_prev.
Ben Pfaff [Tue, 5 May 2009 02:31:16 +0000 (19:31 -0700)]
range-set: New functions range_set_last and range_set_prev.

These are useful for iterating through a range set in reverse order.

15 years agorange-set: Add new function range_set_scan().
Ben Pfaff [Fri, 24 Apr 2009 03:27:54 +0000 (20:27 -0700)]
range-set: Add new function range_set_scan().

15 years agorange-set: Inline some simple functions.
Ben Pfaff [Fri, 24 Apr 2009 03:27:10 +0000 (20:27 -0700)]
range-set: Inline some simple functions.

Some of the range-set functions are very simple and worth inlining, so
move the definitions of those functions into range-set.h.  This required
moving the definition of struct range_set and struct range_set_node into
the header.  Some of the functions used internally by those functions had
to be moved too, and renamed as well since for internal use in range-set.c
their names did not respect the namespace.

15 years agorange-set: Add test coverage for range_set_destroy(NULL).
Ben Pfaff [Fri, 24 Apr 2009 03:14:52 +0000 (20:14 -0700)]
range-set: Add test coverage for range_set_destroy(NULL).

"gcov -b" showed that range_set_destroy() was never called with a NULL
argument.  There's no reason not to test that too (although of course it
is unlikely to be broken).

15 years agorange-set: New function range_set_allocate_fully.
Ben Pfaff [Tue, 5 May 2009 14:03:24 +0000 (07:03 -0700)]
range-set: New function range_set_allocate_fully.

15 years agoDelete CORRELATIONS skeletal parser.
Ben Pfaff [Wed, 1 Apr 2009 05:00:44 +0000 (22:00 -0700)]
Delete CORRELATIONS skeletal parser.

This code didn't do anything useful, it just parsed syntax.  We can
resurrect it when someone wants to implement CORRELATIONS later.

15 years agopool: New function pool_strdup0.
Ben Pfaff [Tue, 5 May 2009 14:03:02 +0000 (07:03 -0700)]
pool: New function pool_strdup0.

This function is the pool analogue of xmemdup0, except that it is only
appropriate for use with strings.

15 years agodatasheet: Drop false dependency on md4.h.
Ben Pfaff [Tue, 5 May 2009 12:46:01 +0000 (05:46 -0700)]
datasheet: Drop false dependency on md4.h.

datasheet-check.c doesn't use anything from md4.h, so there's no point in
including it.

15 years agoperl-module: Better document "make test" requirements.
Ben Pfaff [Thu, 16 Apr 2009 05:31:56 +0000 (22:31 -0700)]
perl-module: Better document "make test" requirements.

15 years agot-test: Move 'mode' variable from file scope into cmd_t_test().
Ben Pfaff [Fri, 16 Jan 2009 04:39:18 +0000 (20:39 -0800)]
t-test: Move 'mode' variable from file scope into cmd_t_test().

15 years agot-test: Move 'cmd' variable from file scope into cmd_t_test().
Ben Pfaff [Fri, 16 Jan 2009 04:37:32 +0000 (20:37 -0800)]
t-test: Move 'cmd' variable from file scope into cmd_t_test().

This variable was only used inside cmd_t_test() anyhow.

15 years agot-test: Remove write-only variable.
Ben Pfaff [Fri, 16 Jan 2009 04:34:43 +0000 (20:34 -0800)]
t-test: Remove write-only variable.

15 years agoMoved static is_origin from design_matrix.c to category.c: cat_is_origin.
Jason H Stover [Wed, 3 Jun 2009 19:54:19 +0000 (15:54 -0400)]
Moved static is_origin from design_matrix.c to category.c: cat_is_origin.

15 years agoFix incorrect word order
John Darrington [Sun, 17 May 2009 23:43:14 +0000 (07:43 +0800)]
Fix incorrect word order

15 years agoRemove whitespace before footnotes
John Darrington [Sun, 17 May 2009 23:42:31 +0000 (07:42 +0800)]
Remove whitespace before footnotes

15 years agoCorrect grammar
John Darrington [Sun, 17 May 2009 23:39:06 +0000 (07:39 +0800)]
Correct grammar

15 years agoChange examples using heights to be all in millimetres
John Darrington [Sun, 17 May 2009 07:29:54 +0000 (15:29 +0800)]
Change examples using heights to be all in millimetres

15 years agoDelete '*' from DATA LIST examples
John Darrington [Sun, 17 May 2009 07:20:23 +0000 (15:20 +0800)]
Delete '*' from DATA LIST examples

15 years agoMention that two juxtapose LIST keywords are intentional
John Darrington [Sun, 17 May 2009 07:16:23 +0000 (15:16 +0800)]
Mention that two juxtapose LIST keywords are intentional

15 years agoFix misaligned menu items
John Darrington [Sun, 17 May 2009 05:15:41 +0000 (13:15 +0800)]
Fix misaligned menu items

15 years agoAdded a tutorial chapter to the manual.
John Darrington [Sun, 17 May 2009 05:06:59 +0000 (13:06 +0800)]
Added a tutorial chapter to the manual.

15 years agoFix bug inserting rows and columns and rename state variable.
John Darrington [Sat, 16 May 2009 03:38:11 +0000 (11:38 +0800)]
Fix bug inserting rows and columns and rename state variable.

The code in psppire-data-editor was inspecting the variable
called "state" on the GtkWidget class whereas it should have
been looking at the PsppireSheet class.

To avoid any future confusion, PsppireSheet's "state" variable
has been renamed to select_status.

15 years agoRemove unused code
John Darrington [Sat, 16 May 2009 02:16:57 +0000 (10:16 +0800)]
Remove unused code

15 years agoUpdated dutch translation. Thanks to unkonwn-1
John Darrington [Fri, 15 May 2009 23:18:01 +0000 (07:18 +0800)]
Updated dutch translation.  Thanks to unkonwn-1

Also regenerated en_GB.po

15 years agoCorrect typo in command line argument string.
John Darrington [Fri, 15 May 2009 22:55:52 +0000 (06:55 +0800)]
Correct typo in command line argument string.

Thanks to Michel Boaventura for reporting this.

15 years agoRemove gratuitous call to change_active_cell.
John Darrington [Thu, 14 May 2009 08:19:09 +0000 (16:19 +0800)]
Remove gratuitous call to change_active_cell.

This caused data from the previous cell to
be transfered to the new cell.  Fixes bug #26568

15 years agoRemove unneeded object members
John Darrington [Thu, 14 May 2009 07:48:14 +0000 (15:48 +0800)]
Remove unneeded object members

15 years agoEnsure that windows opens the right file for output.
John Darrington [Wed, 13 May 2009 22:54:56 +0000 (06:54 +0800)]
Ensure that windows opens the right file for output.

Thanks to Michel Boaventura for reporting this problem.
Fixes bug #26542

15 years agoCorrect default_output_path function on Windows.
John Darrington [Wed, 13 May 2009 22:48:17 +0000 (06:48 +0800)]
Correct default_output_path function on Windows.

15 years agoDon't create histograms for string variables.
John Darrington [Tue, 12 May 2009 23:29:38 +0000 (07:29 +0800)]
Don't create histograms for string variables.

Closes bug #26536

15 years agoRelocate the locale directory.
John Darrington [Tue, 12 May 2009 23:22:20 +0000 (07:22 +0800)]
Relocate the locale directory.

Thanks to Michel Boaventura for reporting this and
for providing the patch.  Closes bug #26543

15 years agoMerge commit 'origin/stable'
John Darrington [Sat, 9 May 2009 07:07:51 +0000 (15:07 +0800)]
Merge commit 'origin/stable'

15 years agoFor consistency, use gnulib's memory allocation functions in the gui.
John Darrington [Sat, 9 May 2009 07:04:48 +0000 (15:04 +0800)]
For consistency, use gnulib's memory allocation functions in the gui.

15 years agoEnsure that NUMERIC's format (if any) is a valid output format.
John Darrington [Sat, 9 May 2009 00:43:35 +0000 (08:43 +0800)]
Ensure that NUMERIC's format (if any) is a valid output format.

Thanks to Pascal Barbedor for reporting this problem.

15 years agoFixed crash calculating trimmed mean with missing values.
John Darrington [Fri, 8 May 2009 10:56:36 +0000 (18:56 +0800)]
Fixed crash calculating trimmed mean with missing values.

Closes bug  #26404

15 years agoRemove call to var_set_width
Jason H Stover [Mon, 4 May 2009 16:06:50 +0000 (12:06 -0400)]
Remove call to var_set_width

15 years agoAllocate adequate space for permutation
Jason H Stover [Fri, 1 May 2009 17:59:06 +0000 (13:59 -0400)]
Allocate adequate space for permutation

15 years agoMoved is_origin and get_exact_subscript to design-matrix.[ch]
Jason H Stover [Wed, 29 Apr 2009 21:23:17 +0000 (17:23 -0400)]
Moved is_origin and get_exact_subscript to design-matrix.[ch]

15 years agocovariance-matrix.c: (is_covariance_contributor) Removed unnecessary recursion.
Jason H Stover [Wed, 29 Apr 2009 16:27:59 +0000 (12:27 -0400)]
covariance-matrix.c: (is_covariance_contributor) Removed unnecessary recursion.

covariance-matrix.c (is_origin): Do not count a numeric variable as
the origin. Call is_origin only for categorical variables.

covariance-matrix.c (ordered_match_nodes): New function.

covariance-matrix.c (match_nodes): Use bitwise operators and
ordered_match_nodes for hashing instead of so many ifs.

covariance-matrix.c (hash_numeric_alpha): Use hash_value_short to hash
combinations of numeric and categorical variables.

covariance-matrix.c (get_value_from_subscript): New function to match
values and columns in a design matrix.

covariance-matrix.c: Removed unused design matrix struct sums from
struct covariance matrix. To get the means, use struct moments
instead.

covariance-matrix.c (covariance_accumulator_to_matrix): Use
design_matrix_set_element instead of covariance_matrix_insert. Drop
unused function covariance_matrix_insert.

covariance-matrix.c (covariance_accumulator_hash): Use hash_bytes instead of hsh_hash_bytes.

15 years agoFix compilation error on Cygwin.
John Darrington [Tue, 28 Apr 2009 23:42:04 +0000 (07:42 +0800)]
Fix compilation error on Cygwin.

Fixes bug #26379

15 years agoAdded Dutch translation. Thanks to unknown-1
John Darrington [Thu, 23 Apr 2009 23:13:21 +0000 (07:13 +0800)]
Added Dutch translation. Thanks to unknown-1

15 years agoFix bug where data sometimes got erroneously copied between cells
John Darrington [Thu, 23 Apr 2009 12:46:33 +0000 (20:46 +0800)]
Fix bug where data sometimes got erroneously copied between cells

15 years agoRemove unused code
John Darrington [Thu, 23 Apr 2009 06:18:44 +0000 (14:18 +0800)]
Remove unused code

15 years agoFix GUI bug risizing columns.
John Darrington [Thu, 23 Apr 2009 05:41:21 +0000 (13:41 +0800)]
Fix GUI bug risizing columns.

Remove the clip rectangle after showing the cell border so
that it doesn't interfere with other operations.

15 years agoCompensate cell border for gridline thickness
John Darrington [Wed, 22 Apr 2009 09:26:46 +0000 (17:26 +0800)]
Compensate cell border for gridline thickness

15 years agoMerge commit 'origin/stable'
John Darrington [Wed, 22 Apr 2009 09:15:41 +0000 (17:15 +0800)]
Merge commit 'origin/stable'

Conflicts:

src/ui/gui/output-viewer.c

15 years agoReplace BORDER_WIDTH macro with appropriate cell_padding parameters
John Darrington [Wed, 22 Apr 2009 09:07:36 +0000 (17:07 +0800)]
Replace BORDER_WIDTH macro with appropriate cell_padding parameters

15 years agoRevert "Made psppire-conf thread safer"
John Darrington [Mon, 20 Apr 2009 12:59:29 +0000 (20:59 +0800)]
Revert "Made psppire-conf thread safer"

This reverts commit 2d983f3e5bd2d5f531cbcbdcebe078034ddb8955.

15 years agoRevert "Make psppire-axis thread safer"
John Darrington [Mon, 20 Apr 2009 12:58:52 +0000 (20:58 +0800)]
Revert "Make psppire-axis thread safer"

This reverts commit 18aa57536d6eac0b0562f31d9a7a01605c3d51ad.

15 years agoMade psppire-conf thread safer
John Darrington [Sun, 19 Apr 2009 11:07:23 +0000 (19:07 +0800)]
Made psppire-conf thread safer

15 years agoMake psppire-axis thread safer
John Darrington [Sun, 19 Apr 2009 10:59:34 +0000 (18:59 +0800)]
Make psppire-axis thread safer

15 years agoSeparate the execute_syntax function into its own file.
John Darrington [Sun, 19 Apr 2009 10:05:48 +0000 (18:05 +0800)]
Separate the execute_syntax function into its own file.

15 years agoWhitespace changes only.
John Darrington [Sun, 19 Apr 2009 09:29:45 +0000 (17:29 +0800)]
Whitespace changes only.

Make this file appear sane when viewed under emacs.