John Darrington [Mon, 7 Dec 2015 17:25:29 +0000 (18:25 +0100)]
Fix bug rendering margin in output viewer.
commit 7b1373b8bded55eedc2328c1afd3eece6d259c34 tried to add an
offset to the output viewer rendering. However the implementation
was somewhat naive. The result was that the desired rendering was
not observed until an expose or resize event occured. This change
improves the implementation.
John Darrington [Mon, 7 Dec 2015 15:14:11 +0000 (16:14 +0100)]
Remove destroy signal handler for dialogs.
Now (since the dialog persistance feature) dialog boxes survive their associated datasets,
it is no longer necessary or desireable for the destroy callback to remove the notification
callback.
John Darrington [Fri, 4 Dec 2015 09:37:48 +0000 (10:37 +0100)]
Fix bug in two sample non-parametric dialog.
Commit fc6620099bbc53762095569d5356b67a81a85402 changed all dialog
boxes such that the previous (existing) dialog widget and all
children are re-used each time the dialog is summoned, instead of
creating a new one each time.
The two sample non-parametric test, however has some special code
on activation to populate the dialog, and this had not been moved
to the conditional case - hence the pertinent widgets were getting
added each time. This resulted in the dialog being overpopulated.
John Darrington [Tue, 1 Dec 2015 17:35:50 +0000 (18:35 +0100)]
Vertically reflect the table borders for RTL locales
When rendering in a right to left locale, the terminals where a horizontal table
border line meets a vertical border needs to be a mirror image of what is normal
in a left to right locale. This change does that.
Reported by: Mohammad Haghighat <hosseinhg@hotmail.com>
John Darrington [Tue, 1 Dec 2015 13:30:09 +0000 (14:30 +0100)]
Output renderer: Reverse the order of table columns when in RTL locale
When operating in a RTL locale, the last column of a table should be rendered
"first" (ie. leftmost). This change achieves that. In order to determine if
the locale is a RTL locale, a new translatable string is introduced. This
string must be localised by the translator of the .po file for RTL locales. LTR
locales can leave it untranslated.
Reported by: Mohammad Haghighat <hosseinhg@hotmail.com>
osx: Test 605 (QUICK CLUSTER with pairwise missing) failed on Mac OS
The uses head -n -3 to check the top number of lines of two files. On osx
negative line numbers are not allowed with head. I changed this to the
respective number of positive line numbers.
osx: Test 172 (decrypt an encrypted syntax file) failed in regression
Test 172 decrypts a file which produces some problematic CRLF characters.
The characters are removed with sed to check vs. reference data, but the sed
does not work the same way on osx as on linux. I changed this to tr which
works on both systems.
Smake clean target removed po/ChangeLog and po/Makefile.in (both are in git)
make -f Smake clean
removed po/ChangeLog and po/Makefile.in which are under git control. This
fix leaves those two files untouched. Without the fix, the make -f Smake
step after a clean ends with an error because po/Makefile.in is missing.
John Darrington [Sat, 28 Nov 2015 06:55:01 +0000 (07:55 +0100)]
Persist dialog box widget settings.
Arrange for the status of widgets within dialog boxes to persist
between calls when called for the same dataset. Some users
have requested this to make repeated operations easier.
John Darrington [Wed, 18 Nov 2015 17:52:24 +0000 (18:52 +0100)]
Make fn_open and fn_close take a struct file_handle instead of char *
This change alters the signature of the fn_open and fn_close functions,
and changes all callers appropriately. The purpose of such a change is
so that the encoding of the filename is passed to fn_open from wherever
it was created.
It also changes the implementation of fn_open on windows systems to call
_wfopen instead of fopen. This should fix the problem of windows builds
not being able to open files whose pathnames included non-ascii characters.
As a bonus, we no longer require the rather contrived function
local_to_filename_encoding.
Some related issues (what about the pspprc file?) remain.
John Darrington [Fri, 13 Nov 2015 12:57:38 +0000 (13:57 +0100)]
QUICK CLUSTER: Remove sqrt from Euclidean distance calculations
The Euclidean distance is used only for comparison with other Euclidean
distances. Since it is invariant that (sqrt(x) < sqrt(y)) === (x < y)
for all non-negative x,y it is a waste of effort calculating the sqrt.
projects / pspp / log