Ben Pfaff [Sat, 23 Sep 2017 17:40:37 +0000 (10:40 -0700)]
PRINT: Remove unused function.
Reported by Clang.
Ben Pfaff [Sat, 23 Sep 2017 17:40:10 +0000 (10:40 -0700)]
pc+-file-reader, sys-file-reader: Fix misuses of zero as null pointer.
Found by Clang.
Reported by Friedrich Beckmann.
Bug #52045.
Ben Pfaff [Sat, 23 Sep 2017 17:38:30 +0000 (10:38 -0700)]
float-format: Remove unused functions.
Reported by Clang.
Ben Pfaff [Sat, 23 Sep 2017 17:37:35 +0000 (10:37 -0700)]
compiler: Fix test for "optimize" attribute.
This was introduced with GCC 4.4. This fixes build warnings compiling with
Clang, which pretends to be GCC 4.3 and does not support the "optimize"
attribute.
Ben Pfaff [Fri, 22 Sep 2017 20:48:16 +0000 (13:48 -0700)]
po: Update translations from translationproject.org.
John Darrington [Fri, 22 Sep 2017 11:55:43 +0000 (13:55 +0200)]
PsppireDataStore (myreversefunc): Insert variables if attempting to access variable beyond the last
John Darrington [Mon, 18 Sep 2017 08:55:46 +0000 (10:55 +0200)]
uint -> guint
Friedrich Beckmann [Sun, 17 Sep 2017 07:16:23 +0000 (09:16 +0200)]
changed abs to labs function to avoid warning
During compilation on MacOS with clang I saw a warning about
a type mismatch for the abs function. I adapted the function
from abs to labs.
Friedrich Beckmann [Sat, 16 Sep 2017 09:25:13 +0000 (11:25 +0200)]
removed duplicate const declaration
During clang compilation the following warning
duplicate 'const' declaration specifier [-Wduplicate-decl-specifier]
extern const char const examples_dir[];
^
is shown. I removed the duplicate const declaration to avoid the
warning.
John Darrington [Sat, 16 Sep 2017 14:44:29 +0000 (16:44 +0200)]
Disable drag and drop on sheet axes for which there is no connected signal
John Darrington [Thu, 14 Sep 2017 06:58:05 +0000 (08:58 +0200)]
Set the "editable" properties of the sheets to TRUE
John Darrington [Wed, 13 Sep 2017 08:22:51 +0000 (10:22 +0200)]
Fix some compiler warnings
John Darrington [Wed, 13 Sep 2017 07:56:32 +0000 (09:56 +0200)]
PsppireImportAssistant.c: Remove unused function
John Darrington [Tue, 12 Sep 2017 04:57:08 +0000 (06:57 +0200)]
PsppireDataSheet.c: Indicate filtered out cases in the row headers
John Darrington [Sun, 10 Sep 2017 18:11:13 +0000 (20:11 +0200)]
Merge remote-tracking branch 'origin/sheet'
John Darrington [Sat, 9 Sep 2017 18:44:44 +0000 (20:44 +0200)]
src/output/cairo.c (xr_chart_renderer): Set the chart size to 0.8 of the smallest page dimension
John Darrington [Sat, 9 Sep 2017 17:46:58 +0000 (19:46 +0200)]
src/output/cairo.c (xr_chart_render): New variable chart_height
Ben Pfaff [Sun, 10 Sep 2017 17:31:59 +0000 (10:31 -0700)]
pspp.appdata.xml: Update and upgrade.
I added a number of elements suggested by Richard Hughes way back in
August 2016, plus some automatically added by "appstream-util upgrade".
It looks like the whole file changed because appstream-util reindented it,
but if you view ignoring white space changes you can see that the actual
changes are much smaller.
Friedrich Beckmann [Sun, 10 Sep 2017 12:12:18 +0000 (14:12 +0200)]
Revert "Revert "Revert "added a description how to update linux distributions"""
This reverts commit
d7e52c8488b7cc4b7352f2057922c779b6ee25b1.
Friedrich Beckmann [Sun, 10 Sep 2017 12:11:45 +0000 (14:11 +0200)]
Revert "GNU/Linux installation/update - Use GNU/Linux wording - Remove Ubuntu"
This reverts commit
3d183ce2adfc32a104c91baa3ab5909d6f7afaa1.
Ben Pfaff [Thu, 7 Sep 2017 14:55:04 +0000 (07:55 -0700)]
Update translations from translationproject.org.
Friedrich Beckmann [Thu, 7 Sep 2017 14:43:53 +0000 (16:43 +0200)]
GNU/Linux installation/update - Use GNU/Linux wording - Remove Ubuntu
I changed the wording to GNU/Linux throughout the text and removed
the reference to Ubuntu.
Friedrich Beckmann [Thu, 7 Sep 2017 14:26:05 +0000 (16:26 +0200)]
Revert "Revert "added a description how to update linux distributions""
This reverts commit
ad4f9604cc877272fe504234e8b9078a7ce76e17.
John Darrington [Wed, 6 Sep 2017 09:27:59 +0000 (11:27 +0200)]
Focus the sheet when the user hits enter in the datum entry
John Darrington [Wed, 6 Sep 2017 09:27:21 +0000 (11:27 +0200)]
PsppireValueEntry: New signal - edit-done
John Darrington [Wed, 6 Sep 2017 09:23:45 +0000 (11:23 +0200)]
Whitespace changes
John Darrington [Wed, 6 Sep 2017 06:53:54 +0000 (08:53 +0200)]
PsppireDataEditor: focus the datum entry widget when F2 is pressed
John Darrington [Tue, 5 Sep 2017 06:04:45 +0000 (08:04 +0200)]
Emit the "items-changed" signal upon data_store_set_value
John Darrington [Tue, 5 Sep 2017 06:01:39 +0000 (08:01 +0200)]
Fix memory leak
Ben Pfaff [Mon, 4 Sep 2017 17:04:09 +0000 (10:04 -0700)]
Correct URL in documentation.
Ben Pfaff [Mon, 4 Sep 2017 16:57:39 +0000 (09:57 -0700)]
Improve bug reporting documentation, and mention pspp-security list.
John Darrington [Mon, 4 Sep 2017 16:40:02 +0000 (18:40 +0200)]
Set the cell value when the reference entry changes
John Darrington [Mon, 4 Sep 2017 06:51:28 +0000 (08:51 +0200)]
Whitespace changes only
John Darrington [Mon, 4 Sep 2017 06:45:07 +0000 (08:45 +0200)]
Make the default view the variable view instead of the data view
John Darrington [Sun, 3 Sep 2017 08:04:41 +0000 (10:04 +0200)]
examples/physiology.sav: Set the display width of the 'sex' variable.
John Darrington [Sun, 3 Sep 2017 08:42:00 +0000 (10:42 +0200)]
Revert "added a description how to update linux distributions"
This reverts commit
0ec7c606844768cfc501d6213ffa17ebdfda1bab.
John Darrington [Sun, 3 Sep 2017 08:03:02 +0000 (10:03 +0200)]
PsppireDict: Add a quarter of a unit to the displayed width.
This avoids the text appearing cramped.
John Darrington [Sun, 3 Sep 2017 07:51:27 +0000 (09:51 +0200)]
Whitespace changes only
John Darrington [Sat, 2 Sep 2017 20:29:15 +0000 (22:29 +0200)]
Recent the dependency on spread-sheet-widget
John Darrington [Sat, 2 Sep 2017 19:22:38 +0000 (21:22 +0200)]
Honour the display width variable property
John Darrington [Sat, 2 Sep 2017 18:42:53 +0000 (20:42 +0200)]
Cope with changes to ssw_axis_model (upstream)
Friedrich Beckmann [Sat, 2 Sep 2017 08:51:47 +0000 (10:51 +0200)]
added a description how to update linux distributions
The usual way to obtain pspp in linux distributions is to
use the pspp version which is part of the distribution. I
described ways to update the pspp version by using backports,
a ppa or creating a new binary package from a source package.
John Darrington [Thu, 31 Aug 2017 06:41:38 +0000 (08:41 +0200)]
Merge remote-tracking branch 'origin/master' into sheet
Ben Pfaff [Mon, 28 Aug 2017 15:38:07 +0000 (08:38 -0700)]
tests: Add pspp-convert.at to Git.
This was accidentally omitted from the repository.
Ben Pfaff [Sun, 27 Aug 2017 19:48:58 +0000 (12:48 -0700)]
Release version 1.0.1.
Ben Pfaff [Sun, 27 Aug 2017 19:42:09 +0000 (12:42 -0700)]
po: Update translations from translationproject.org.
Ben Pfaff [Sun, 27 Aug 2017 19:31:05 +0000 (12:31 -0700)]
sys-file-reader: Avoid assert-fail for duplicate attribute names.
CVE-2017-12961.
See also https://bugzilla.redhat.com/show_bug.cgi?id=
1482436.
See also http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-12961.
See also http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-12961.
Found by team OWL337, using the collAFL fuzzer.
Ben Pfaff [Sun, 27 Aug 2017 19:30:50 +0000 (12:30 -0700)]
sys-file-reader: Better handle duplicate names without long names.
The reader did not properly handle the case where variable short names
had duplicates and the system file did not include long names. In this
case, the reader still tried to use the (duplicate) short names as the
long names, which could in some cases cause a secondary name collision in
the no-long-names case in parse_long_var_names(), and assert-failed.
This commit first fixes the handling of duplicate short names: it sets
the long name to the unique chosen short name, instead of the original
duplicate short name. Then as an additional measure it refactors the code
a little to always handle duplicates in rename_var_and_save_short_names().
I am not sure that that is necessary but it's a little bit of a code
cleanup anyhow.
CVE-2017-12960.
See also https://bugzilla.redhat.com/show_bug.cgi?id=
1482433.
See also http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-12960.
See also http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-12960.
Found by team OWL337, using the collAFL fuzzer.
Ben Pfaff [Sun, 27 Aug 2017 19:30:30 +0000 (12:30 -0700)]
sys-file-reader: Fully verify multiple response set names.
Until now, the code only checked the first character of the name, which
made it possible to assert-fail when the mrset was actually added.
CVE-2017-12959.
See also https://bugzilla.redhat.com/show_bug.cgi?id=
1482432.
See also http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-12959.
See also http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-12959.
Found by team OWL337, using the collAFL fuzzer.
Ben Pfaff [Sun, 27 Aug 2017 19:32:50 +0000 (12:32 -0700)]
data-out: Pass correct width to value_str() in output_AHEX().
AHEX16 is short enough to work as a short string, but output_AHEX() was
treating it as a long string, which caused string data to be dereferenced
as a pointer.
CVE-2017-12958.
See also https://bugzilla.redhat.com/show_bug.cgi?id=
1482429.
See also http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-12958.
See also http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-12958.
Found by team OWL337, using the collAFL fuzzer.
Ben Pfaff [Sat, 26 Aug 2017 23:33:01 +0000 (16:33 -0700)]
pspp-convert: Fix crash when the output file cannot be created.
Stefan Weil [Sun, 20 Aug 2017 18:39:15 +0000 (20:39 +0200)]
Fix some typos (found by codespell)
Most of them were in documentation and comments.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
John Darrington [Sun, 20 Aug 2017 17:11:48 +0000 (19:11 +0200)]
Remove PSEAL macro. It is no longer useful.
Ben Pfaff [Sun, 20 Aug 2017 16:12:38 +0000 (09:12 -0700)]
Increase version number to 1.0.0.
It's time.
Ben Pfaff [Sun, 20 Aug 2017 15:22:18 +0000 (08:22 -0700)]
Update translations from translationproject.org.
Ben Pfaff [Sun, 20 Aug 2017 15:19:06 +0000 (08:19 -0700)]
po: Use "rsync" instead of "wget" for po-update target.
This is much faster.
Ben Pfaff [Sat, 12 Aug 2017 18:20:40 +0000 (11:20 -0700)]
Release PSPP version 0.11.0.
Ben Pfaff [Sat, 12 Aug 2017 18:02:32 +0000 (11:02 -0700)]
Ignore all files under src/ui/gui/icons except a few actual source files.
Ben Pfaff [Sat, 12 Aug 2017 17:48:10 +0000 (10:48 -0700)]
doc: Ignore generated documentation files.
John Darrington [Fri, 11 Aug 2017 16:23:38 +0000 (18:23 +0200)]
Update German and Dutch translations from translationproject.org
John Darrington [Sat, 5 Aug 2017 10:01:59 +0000 (12:01 +0200)]
NEWS: Move the mention of the new sheet to the next release
John Darrington [Fri, 4 Aug 2017 06:06:13 +0000 (08:06 +0200)]
Update translations from translationproject.org
John Darrington [Thu, 3 Aug 2017 05:37:27 +0000 (07:37 +0200)]
Merge remote-tracking branch 'origin/master' into sheet
Ben Pfaff [Mon, 31 Jul 2017 13:52:53 +0000 (06:52 -0700)]
system-file-format: More string fields with null bytes spotted.
Manoharan <s.manoharan@auckland.ac.nz> reported that he has also seen
system files that contain string fields with compressed null bytes, so
reword the description to make this sound less exotic.
Ben Pfaff [Sun, 30 Jul 2017 21:39:56 +0000 (14:39 -0700)]
Update version number to 0.10.5-pre3.
This pre-release is primarily to get the CVE-2017-10791 and CVE-2017-10792
fixes into a tarball for folks who find tarballs easier to work with.
Ben Pfaff [Sun, 30 Jul 2017 00:18:51 +0000 (17:18 -0700)]
linreg: Comment out unused function to avoid compiler warning.
Ben Pfaff [Sun, 30 Jul 2017 00:13:28 +0000 (17:13 -0700)]
sys-file-reader: Ignore duplicate value labels written by ReadStat.
The ReadStat software writes duplicate value labels due to a
misunderstanding of string widths. This change make PSPP ignore these
duplicates.
Ben Pfaff [Sat, 29 Jul 2017 23:16:30 +0000 (16:16 -0700)]
sys-file-reader: Tolerate nominal case size of 0 without warning.
The software at https://github.com/WizardMac/ReadStat seems to always write
0, so there's not much value in warning.
Ben Pfaff [Sat, 29 Jul 2017 23:06:24 +0000 (16:06 -0700)]
sys-file-reader: Accept document records with no document lines.
This allows PSPP to accept system files that appear to be produced by the
ReadStat software at https://github.com/WizardMac/ReadStat.
Thanks to ftr for reporting this bug via pspp-users at:
http://lists.gnu.org/archive/html/pspp-users/2017-07/msg00002.html
John Darrington [Sat, 29 Jul 2017 05:30:50 +0000 (07:30 +0200)]
Linreg.c: Remove QR decomposition optimisation.
Fixes bug #51373.
John Darrington [Sat, 29 Jul 2017 05:11:06 +0000 (07:11 +0200)]
linreg.c: Fix typo
John Darrington [Wed, 26 Jul 2017 19:49:42 +0000 (21:49 +0200)]
doc/expressions.texi: Correct documentation of MISSING and SYSMIS functions.
Ben Pfaff [Mon, 17 Jul 2017 22:12:39 +0000 (15:12 -0700)]
spv-file-format: Improve description of file format.
Ben Pfaff [Mon, 17 Jul 2017 04:08:12 +0000 (21:08 -0700)]
doc: Mark SPSS Viewer format chapter properly as an appendix.
Otherwise some of the output looked a little confused when it went through
TeX.
Ben Pfaff [Mon, 17 Jul 2017 04:07:33 +0000 (21:07 -0700)]
doc: Keep copyright and license comments from showing up in TeX output.
The "\input texinfo" line is what changes the comment syntax from TeX
syntax to Texinfo syntax, so it has to go before the @c comments or else
those comments show up in output produced by TeX.
Ben Pfaff [Sun, 16 Jul 2017 18:21:02 +0000 (11:21 -0700)]
spv-file-format: Improve description of structure member format.
Ben Pfaff [Sun, 16 Jul 2017 03:11:06 +0000 (20:11 -0700)]
tests: Use path search for zip-test instead of full path.
This allows "check-valgrind" to work properly since it relies on putting
wrappers early in $PATH.
Ben Pfaff [Sat, 15 Jul 2017 22:10:38 +0000 (15:10 -0700)]
Update to newest Gnulib.
Harry Thijssen reported an issue with the previous version on Windows.
John Darrington suggested an update, since the Gnulib developers have been
working through related problems.
John Darrington [Sat, 15 Jul 2017 04:11:28 +0000 (06:11 +0200)]
doc/statistics.texi: Add comma after @xref.
Apparently older versions of makeinfo insist on this.
Reported-by: Harry Thijssen
Fix-by: Ben Pfaff
Ben Pfaff [Thu, 13 Jul 2017 03:48:16 +0000 (20:48 -0700)]
tests: Avoid failure based on encoding name differences.
glibc and Mac OS X call the ASCII encoding by different names, which caused
differing output and a test failure. This fixes the problem.
Reported by Jeremy Lavergne.
Ben Pfaff [Thu, 13 Jul 2017 00:48:26 +0000 (17:48 -0700)]
spv-file-format: Add much more detail.
Ben Pfaff [Mon, 10 Jul 2017 20:49:13 +0000 (13:49 -0700)]
zip-reader: Use xstrdup() instead of strdup().
John Darrington [Sat, 8 Jul 2017 20:26:29 +0000 (22:26 +0200)]
Move XML declarations to the start of .ui files.
Apparently xgettext complains if comments start the file.
John Darrington [Sat, 8 Jul 2017 04:29:43 +0000 (06:29 +0200)]
Fix erroneous subsitute by previous commit.
Commit
691a034d7f2139076fa012739dffd40ef5db4a9b inadvertenntly
commented out the first line of every .at file. This commit
fixes that.
John Darrington [Wed, 5 Jul 2017 19:02:56 +0000 (21:02 +0200)]
Add copyright and licence notices to files which lack them.
The savannah hackers have been recently complaining about lack of copyright/licence notices.
Ben Pfaff [Tue, 4 Jul 2017 17:13:15 +0000 (13:13 -0400)]
tests: Add tests against regression for two previously fixed bugs.
Ben Pfaff [Tue, 4 Jul 2017 16:58:55 +0000 (12:58 -0400)]
sys-file-reader: Fix integer overflows in parse_long_string_missing_values().
Crafted system files caused integer overflow errors that in turn caused
aborts. This fixes the problem.
CVE-2017-10791.
See also https://bugzilla.redhat.com/show_bug.cgi?id=
1467004.
See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866890.
See also https://security-tracker.debian.org/tracker/CVE-2017-10791.
Found by team OWL337, using the collAFL fuzzer.
Ben Pfaff [Tue, 4 Jul 2017 16:54:47 +0000 (12:54 -0400)]
sys-file-reader: Avoid null dereference skipping bad extension record 18.
read_record() assumed that read_extension_record() never set its output
argument to NULL when it returned true, but this is possible in an error
case.
CVE-2017-10792.
See also https://bugzilla.redhat.com/show_bug.cgi?id=
1467005.
See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=866890.
See also https://security-tracker.debian.org/tracker/CVE-2017-10792.
Reported by team OWL337, with fuzzer collAFL.
Ben Pfaff [Tue, 27 Jun 2017 22:10:00 +0000 (18:10 -0400)]
Update version number to 0.10.5-pre2.
This prerelease is to update the Gnulib version, to fix the GCC 7 problems.
Ben Pfaff [Tue, 27 Jun 2017 21:54:42 +0000 (17:54 -0400)]
README.Git: Recommend newer Gnulib, to avoid GCC 7 segfaults.
Reported by Matthias Klose <doko@debian.org>
at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853623.
Bug #51318.
Ben Pfaff [Tue, 27 Jun 2017 21:52:40 +0000 (17:52 -0400)]
perl-module: Avoid VERSION redefinition warning from compiler.
If the PSPP version includes a suffix like "-pre1", then Perl will strip
that suffix from the version it passes to the compiler using -DVERSION=...,
and <config.h> will re-define it with the full version string. This causes
a warning.
This change avoids the warning. I am not yet aware of a new problem that
it causes.
John Darrington [Fri, 23 Jun 2017 10:06:57 +0000 (12:06 +0200)]
Enable the show value labels feature
John Darrington [Mon, 19 Jun 2017 10:44:16 +0000 (12:44 +0200)]
FACTOR: Improve calculation of Kaiser-Meyer-Olkin and add a test
John Darrington [Sun, 18 Jun 2017 19:34:47 +0000 (21:34 +0200)]
FACTOR: Add Anti-image matrix output
John Darrington [Sat, 17 Jun 2017 04:49:55 +0000 (06:49 +0200)]
Updated German translation from translationproject.org
John Darrington [Sat, 17 Jun 2017 04:48:28 +0000 (06:48 +0200)]
Add documentation for MATRIX DATA /N
John Darrington [Fri, 16 Jun 2017 09:34:27 +0000 (11:34 +0200)]
MATRIX DATA: Add /N subcommand
John Darrington [Thu, 15 Jun 2017 14:48:19 +0000 (16:48 +0200)]
Allow dialog boxes to be cancelled by hitting the Escape key.
Closes bug #51225
Friedrich Beckmann [Sun, 11 Jun 2017 18:56:35 +0000 (20:56 +0200)]
Fixed perl regression problem due to Version name - Fixes Bug #51218
The regression failed in some perl tests due to an incompatible
pspp version number. I changed to a version number that includes
a "-". The problem is described in acinclude.m4. See
The PSPP autobuilder appends a build number to the PSPP version number,
e.g. "0.7.2-build40". But Perl won't parse version numbers that contain
anything other than digits and periods, so "-build" causes an error. So we
define $(VERSION_FOR_PERL) that drops everything from the hyphen onward.
VERSION_FOR_PERL=`echo "$VERSION" | sed 's/-.*//'`
AC_SUBST([VERSION_FOR_PERL])
The version name was 0.10.5pre1 without a "-". Therefore the version name
for perl results in a problem.
John Darrington [Thu, 8 Jun 2017 05:14:04 +0000 (07:14 +0200)]
Change the return type of psppire_delimited_text_new.
... and deal with the consequences.