openvswitch
16 years agoSupport pre-Linux 2.6.20 genetlink, which didn't have "done" functions for dumps.
Ben Pfaff [Mon, 5 May 2008 18:41:48 +0000 (11:41 -0700)]
Support pre-Linux 2.6.20 genetlink, which didn't have "done" functions for dumps.

16 years agoCompile fix for Linux 2.6.26-rc1: don't use the removed list_for_each_safe_rcu macro.
Ben Pfaff [Mon, 5 May 2008 18:14:02 +0000 (11:14 -0700)]
Compile fix for Linux 2.6.26-rc1: don't use the removed list_for_each_safe_rcu macro.

There is no need for a "safe" version of the RCU list iteration macros,
because the ordinary version of the macros is "safe".  Linux 2.6.26-rc1
removed these "safe" versions, so this change modifies OpenFlow's uses
of these macros to use the ordinary versions.  This also simplifies the
code because we don't need to use the list_entry macros any longer.

16 years agoCheck whether kernel has been configured by "version.h" instead of "utsrelease.h...
Justin Pettit [Mon, 5 May 2008 18:36:15 +0000 (11:36 -0700)]
Check whether kernel has been configured by "version.h" instead of "utsrelease.h", since that convention wasn't introduced until 2.6.18.

16 years agoOfficially designate the v0.8.0 release.
Justin Pettit [Mon, 5 May 2008 18:27:39 +0000 (11:27 -0700)]
Officially designate the v0.8.0 release.

16 years agoGet rid of compiler warning under gcc 4.2.
Justin Pettit [Mon, 5 May 2008 05:29:48 +0000 (22:29 -0700)]
Get rid of compiler warning under gcc 4.2.

16 years agoFix problem introduced by kernel threads when building for 2.4.20.
Justin Pettit [Mon, 5 May 2008 04:07:24 +0000 (21:07 -0700)]
Fix problem introduced by kernel threads when building for 2.4.20.

16 years agoClean-up OpenFlow main header a bit.
Justin Pettit [Mon, 5 May 2008 04:05:51 +0000 (21:05 -0700)]
Clean-up OpenFlow main header a bit.

16 years agoFix typo in comment.
Justin Pettit [Sat, 3 May 2008 04:53:15 +0000 (21:53 -0700)]
Fix typo in comment.

16 years agoFinishing touches on v0.8.0 release candidate.
Justin Pettit [Sat, 3 May 2008 04:51:02 +0000 (21:51 -0700)]
Finishing touches on v0.8.0 release candidate.

16 years ago- Update man pages to reflect recent spat of changes.
Justin Pettit [Sat, 3 May 2008 04:46:39 +0000 (21:46 -0700)]
- Update man pages to reflect recent spat of changes.
- Clean-up man pages.

16 years agoSend the features request before the set config to be OpenFlow-compliant.
Justin Pettit [Sat, 3 May 2008 00:43:16 +0000 (17:43 -0700)]
Send the features request before the set config to be OpenFlow-compliant.

16 years agoAdd build directory to include path.
Ben Pfaff [Sat, 3 May 2008 00:32:39 +0000 (17:32 -0700)]
Add build directory to include path.

Otherwise generated headers (forward_t.h) will not be found at build
time.

16 years agoSuppress Automake warnings about GNU make extensions in Modules.mk files.
Ben Pfaff [Sat, 3 May 2008 00:10:12 +0000 (17:10 -0700)]
Suppress Automake warnings about GNU make extensions in Modules.mk files.

16 years agoImplement aggregate flow statistics in kernel and userspace switches.
Ben Pfaff [Fri, 2 May 2008 23:57:54 +0000 (16:57 -0700)]
Implement aggregate flow statistics in kernel and userspace switches.

16 years agoReduce spurious recompilations for Linux 2.4 datapath.
Ben Pfaff [Fri, 2 May 2008 22:51:08 +0000 (15:51 -0700)]
Reduce spurious recompilations for Linux 2.4 datapath.

We need object files to depend on the build directories, so that the
build directories get created before we try to output files into them.
But making them depend directly on the build directories means that
whenever a build directory changes (including any change to the set of
files inside it) all the source files get recompiled.  So, instead, make
them depend on dummy files inside the directories, which will only get
modified if someone does it intentionally.

16 years agoRemove MAX_ACTIONS (which was 16) as a limit on the number of actions in a flow table...
Ben Pfaff [Fri, 2 May 2008 18:37:04 +0000 (11:37 -0700)]
Remove MAX_ACTIONS (which was 16) as a limit on the number of actions in a flow table entry.

Now the number of actions is limited, as a practical matter, to the size
of the buffer that the kernel provides for Netlink dumps, which is usually
4096 bytes.  A flow statistics entry must fit in a single one of these
buffers.  Actions are 8 bytes each, so this is about 500 actions
considering overhead.

16 years agoSend actions as part of flow statistics messages.
Ben Pfaff [Fri, 2 May 2008 17:52:53 +0000 (10:52 -0700)]
Send actions as part of flow statistics messages.

16 years agoAdd max_idle field to flow stats messages.
Ben Pfaff [Fri, 2 May 2008 01:26:21 +0000 (18:26 -0700)]
Add max_idle field to flow stats messages.

16 years ago- Add priority to flow expiration messages.
Justin Pettit [Fri, 2 May 2008 00:10:20 +0000 (17:10 -0700)]
- Add priority to flow expiration messages.
- Clear contents of "pad" field port status messages.

16 years agoConvert tabs to spaces to fix indentation issues.
Ben Pfaff [Fri, 2 May 2008 00:01:25 +0000 (17:01 -0700)]
Convert tabs to spaces to fix indentation issues.

16 years agoImplement new statistics format in kernel and userspace switches.
Ben Pfaff [Fri, 2 May 2008 00:02:13 +0000 (17:02 -0700)]
Implement new statistics format in kernel and userspace switches.

This change really cuts the muster!

16 years agoDrop prototype for function that does not exist.
Ben Pfaff [Wed, 30 Apr 2008 21:16:35 +0000 (14:16 -0700)]
Drop prototype for function that does not exist.

16 years agoClear padding bytes in fill_flow_stats(), to avoid state leakage.
Ben Pfaff [Wed, 30 Apr 2008 23:26:33 +0000 (16:26 -0700)]
Clear padding bytes in fill_flow_stats(), to avoid state leakage.

Found by valgrind.

16 years agoInitialize n_flows member in table-hash.
Ben Pfaff [Wed, 30 Apr 2008 22:33:21 +0000 (15:33 -0700)]
Initialize n_flows member in table-hash.

Found by valgrind.

16 years agoInitialize rconn "connected" member.
Ben Pfaff [Wed, 30 Apr 2008 22:12:05 +0000 (15:12 -0700)]
Initialize rconn "connected" member.

Found by valgrind.

16 years agoNew utility function xmemdup().
Ben Pfaff [Wed, 30 Apr 2008 22:11:40 +0000 (15:11 -0700)]
New utility function xmemdup().

16 years agoAdd support for OFPP_TABLE virtual port to user-space switch.
Justin Pettit [Thu, 1 May 2008 23:30:09 +0000 (16:30 -0700)]
Add support for OFPP_TABLE virtual port to user-space switch.

16 years ago- Add support for OpenFlow error message type.
Justin Pettit [Thu, 1 May 2008 00:38:03 +0000 (17:38 -0700)]
- Add support for OpenFlow error message type.
- Ensure OpenFlow messages fit in 16-bit length field.

16 years agoRevamp OpenFlow kernel module build system.
Ben Pfaff [Mon, 28 Apr 2008 20:28:31 +0000 (13:28 -0700)]
Revamp OpenFlow kernel module build system.

The new build system supports using a build tree separate from the
source tree, which makes it easier to build for multiple targets
using a single source tree.  It also factors out the means for specifying
the modules to be built and the source files that comprise those
modules into simple files named Modules.mk.  This is intended to
make it easier to add support for separate hardware table modules in
an upcoming commit.

16 years agoFix problem displaying duration when printing flow stats.
Justin Pettit [Tue, 29 Apr 2008 22:55:45 +0000 (15:55 -0700)]
Fix problem displaying duration when printing flow stats.

16 years ago- On flow entries with wildcards, match priority field when doing a "strict" delete.
Justin Pettit [Tue, 29 Apr 2008 22:00:28 +0000 (15:00 -0700)]
- On flow entries with wildcards, match priority field when doing a "strict" delete.
- Remove group_id from flow entries.
- Show priority when print flow mod messages.

16 years agoFix openflow.h compilation with GCC 2.95.
Ben Pfaff [Sat, 26 Apr 2008 18:03:54 +0000 (11:03 -0700)]
Fix openflow.h compilation with GCC 2.95.

Necessary because older Linux 2.4 releases will only compile with GCC 2.95.

16 years agoRename variables with duplicate names, so as to be less confusing.
Ben Pfaff [Tue, 29 Apr 2008 17:18:45 +0000 (10:18 -0700)]
Rename variables with duplicate names, so as to be less confusing.

Suggestion from Justin.

16 years agoGet rid of union in struct sw_flow, because only one member is ever used any longer.
Ben Pfaff [Tue, 29 Apr 2008 16:52:06 +0000 (09:52 -0700)]
Get rid of union in struct sw_flow, because only one member is ever used any longer.

16 years agoMake dumping large numbers of flows possible.
Ben Pfaff [Tue, 29 Apr 2008 01:16:05 +0000 (18:16 -0700)]
Make dumping large numbers of flows possible.

This changes the kernel switch implementation to use the kernel Netlink
"dump" interface to allow flow stats that don't fit in the socket buffer
to be dumped gradually as the caller drains the socket buffer.

One of the changes here is a bug fix for nla_unreserve.  Because Netlink
attributes' lengths are rounded up to a multiple of 4 bytes, reducing
the length of the payload by N bytes doesn't necessarily reduce the
length of the skb by N bytes.  Instead, we need to know the original
length and final length of the attribute.  This means that using 'len'
as a difference in bytes doesn't really make sense, so this changes
'len' to be the new length of the attribute payload and renames the
function to nla_shrink to (IMO) better reflect what it is now doing.

Since we have to release the RCU read lock between calls to the dump
function, we need table iterators that persist across RCU epochs.  One
way to do this would be to add new "iterator_save" and "iterator_restore"
functions, but this seemed like overkill since there would then be a
total of 5 iterator functions that have only one user (flow stats dumping).
Instead, this patch refactors table iteration into a single "iterate"
function that takes a callback.  This simplifies the table iteration code
significantly.

This change also modifies dpctl to understand the new format of flow
stats.

16 years agoBUG #6
Justin Pettit [Mon, 28 Apr 2008 21:33:02 +0000 (14:33 -0700)]
BUG #6

Fix problem with "dpctl monitor" not working.

** Fix by Ben. **

16 years agoAdd missing NLM_F flags constants (oops).
Ben Pfaff [Mon, 28 Apr 2008 21:16:57 +0000 (14:16 -0700)]
Add missing NLM_F flags constants (oops).

16 years agoEnable the netlink library to dump more verbose debug output.
Ben Pfaff [Tue, 22 Apr 2008 18:08:12 +0000 (11:08 -0700)]
Enable the netlink library to dump more verbose debug output.

16 years agoMake nl_sock_sendv properly implement 'wait' option.
Ben Pfaff [Mon, 21 Apr 2008 17:36:49 +0000 (10:36 -0700)]
Make nl_sock_sendv properly implement 'wait' option.

16 years agoFix typo in comment.
Ben Pfaff [Fri, 18 Apr 2008 21:49:45 +0000 (14:49 -0700)]
Fix typo in comment.

16 years agoClean-up related to supporting priorities...mostly suggestions from Ben.
Justin Pettit [Sat, 26 Apr 2008 21:27:32 +0000 (14:27 -0700)]
Clean-up related to supporting priorities...mostly suggestions from Ben.

16 years agoBUG #5
Justin Pettit [Sat, 26 Apr 2008 00:28:50 +0000 (17:28 -0700)]
BUG #5

Fixes crash when a non-existent command is given to dpctl.

16 years agoPrint the configuration of the switch in addition to the features when "dpctl show...
Justin Pettit [Fri, 25 Apr 2008 22:18:08 +0000 (15:18 -0700)]
Print the configuration of the switch in addition to the features when "dpctl show" is run.

16 years agoAdd support for deleting flow entries with "del-flows" command in "dpctl".
Justin Pettit [Fri, 25 Apr 2008 21:21:51 +0000 (14:21 -0700)]
Add support for deleting flow entries with "del-flows" command in "dpctl".

16 years ago- Add support for flow entry priorities.
Justin Pettit [Fri, 25 Apr 2008 21:00:15 +0000 (14:00 -0700)]
- Add support for flow entry priorities.
- Fix "flow-add" action for dpctl.

16 years agoFix problem where the add_flow command is reading an unitialized array.
Justin Pettit [Tue, 22 Apr 2008 06:49:17 +0000 (23:49 -0700)]
Fix problem where the add_flow command is reading an unitialized array.

16 years agoImprove list traversal macros.
Ben Pfaff [Sat, 26 Apr 2008 01:28:03 +0000 (18:28 -0700)]
Improve list traversal macros.

Make LIST_FOR_EACH[_SAFE] variable take logically correct value upon loop termination.

Also, add regression tests for linked list routines, to ensure that this
change does not break code.

Also, add new macro LIST_FOR_EACH_REVERSE.

16 years agoAdd missing header to Makefile.am.
Ben Pfaff [Sat, 26 Apr 2008 16:10:41 +0000 (09:10 -0700)]
Add missing header to Makefile.am.

16 years agoDrop stray debug messages.
Ben Pfaff [Fri, 25 Apr 2008 02:07:54 +0000 (19:07 -0700)]
Drop stray debug messages.

16 years agoGet rid of build dependency on netlink-related headers from Linux 2.6.
Ben Pfaff [Thu, 24 Apr 2008 23:29:53 +0000 (16:29 -0700)]
Get rid of build dependency on netlink-related headers from Linux 2.6.

This fixes userspace program build problems on top of systems with
Linux 2.4 headers.

16 years agoFix problem in sending netlink messages on non-32-bit platforms.
root [Thu, 24 Apr 2008 18:37:54 +0000 (11:37 -0700)]
Fix problem in sending netlink messages on non-32-bit platforms.

** Fix provided by Ben. **

16 years agoCHECKSUM_COMPLETE and CHECKSUM_PARTIAL were added Linux 2.6.19, so update the compati...
root [Wed, 23 Apr 2008 22:48:56 +0000 (15:48 -0700)]
CHECKSUM_COMPLETE and CHECKSUM_PARTIAL were added Linux 2.6.19, so update the compatiblity layer to reflect this.

16 years agoTolerate ENOBUFS from kernel netlink code in second call to recvmsg.
root [Wed, 23 Apr 2008 22:20:58 +0000 (15:20 -0700)]
Tolerate ENOBUFS from kernel netlink code in second call to recvmsg.

The Linux kernel returns ENOBUFS to userspace code to indicate that
a netlink message that the kernel wanted to send could not be due to
a lack of buffer space.  We checked for this and dealt with it in
one recvmsg call but not in another.  This change tolerates it in
both places.

Should fix a problem encountered on the OF6k under "hping3 --flood".

** This fix was done by Ben. **

16 years agoSupport NETLINK_ADD_MEMBERSHIP even when compiled with old kernel headers.
Ben Pfaff [Wed, 23 Apr 2008 21:25:27 +0000 (14:25 -0700)]
Support NETLINK_ADD_MEMBERSHIP even when compiled with old kernel headers.

Commit 0a9024a2d7, "Changes based on feedback from GigaFin," added support
for compiling on a system that lacked up-to-date Linux kernel headers, by
dropping support for a feature only in newer kernels on such a system.
But the code already supported such a system properly; only the lack of
a macro definition kept it from compiling.  So define the macro ourselves
instead of disabling the feature.

To elaborate, there are two issues here.

The first is kernel support for NETLINK_ADD_MEMBERSHIP.  Older
kernels don't support this.  But NETLINK_ADD_MEMBERSHIP was added
at the same time as support for more than 32 netlink multicast
groups.  Netlink multicast groups numbered less than 32 can be
subscribed using a different mechanism, and in fact we do that
for such groups.  Thus, attempting to use NETLINK_ADD_MEMBERSHIP
on an older kernel basically can't happen, and if it did it would
be a bug in the OpenFlow kernel module for telling userspace to
subscribe to a multicast group that cannot exist on that kernel.

The second is the kernel headers that the userspace programs are
compiled with.  Without the change quoted below, the userspace
programs will silently fail if they are compiled with 2.4.x
headers and then run on a 2.6.x kernel and given a multicast
group numbered above 32, because they will not even try to
subscribe to that group.  With the change, the userspace programs
will work properly when run on 2.4.x or 2.6.x kernels regardless
of the multicast group number and regardless of whether the
headers they were compiled against were from 2.4.x or 2.6.x.

16 years agoHandle memory allocation failure in dp_output_control().
Ben Pfaff [Wed, 23 Apr 2008 19:24:32 +0000 (12:24 -0700)]
Handle memory allocation failure in dp_output_control().

Possible fix for bug observed on OF6k.

16 years agoMark functions not meant to be exported as static.
Ben Pfaff [Wed, 23 Apr 2008 00:48:22 +0000 (17:48 -0700)]
Mark functions not meant to be exported as static.

16 years agoAdd priority field to flow_mod...code to support this forthcoming.
Justin Pettit [Tue, 22 Apr 2008 01:13:42 +0000 (18:13 -0700)]
Add priority field to flow_mod...code to support this forthcoming.

16 years agoFix tab/space issue.
Justin Pettit [Tue, 22 Apr 2008 00:59:44 +0000 (17:59 -0700)]
Fix tab/space issue.

16 years agoBUG #4.
Justin Pettit [Tue, 22 Apr 2008 00:56:12 +0000 (17:56 -0700)]
BUG #4.

Don't use kmalloc with GFP_KERNEL within an rcu_read_lock().

16 years agoMark structures as packed that cause alignment problems on architectures like ARM.
Justin Pettit [Mon, 21 Apr 2008 20:46:36 +0000 (13:46 -0700)]
Mark structures as packed that cause alignment problems on architectures like ARM.

16 years agoFix a problem with not allocating enough room for netlink messages.
Justin Pettit [Thu, 17 Apr 2008 01:26:47 +0000 (18:26 -0700)]
Fix a problem with not allocating enough room for netlink messages.

16 years agoFix call from vfprintf to fprintf, which could cause seg faults.
Justin Pettit [Wed, 16 Apr 2008 23:49:42 +0000 (16:49 -0700)]
Fix call from vfprintf to fprintf, which could cause seg faults.

16 years agoSwitch from "stat" to "stats" everywhere.
Justin Pettit [Wed, 16 Apr 2008 22:38:25 +0000 (15:38 -0700)]
Switch from "stat" to "stats" everywhere.

16 years ago- Keep datapath config in host-byte order (and fix a couple of bugs related to this).
Justin Pettit [Wed, 16 Apr 2008 21:09:27 +0000 (14:09 -0700)]
- Keep datapath config in host-byte order (and fix a couple of bugs related to this).
- Fix type for "get config" replies.

16 years agoUpdated version references to OFP_VERSION
Natasha Gude [Wed, 16 Apr 2008 18:30:55 +0000 (11:30 -0700)]
Updated version references to OFP_VERSION

16 years agoUse new OpenFlow protocol versioning scheme.
Justin Pettit [Wed, 16 Apr 2008 17:39:21 +0000 (10:39 -0700)]
Use new OpenFlow protocol versioning scheme.

16 years agoFinish removing references to the MAC table.
Justin Pettit [Tue, 15 Apr 2008 20:42:35 +0000 (13:42 -0700)]
Finish removing references to the MAC table.

16 years agoMerge remote branch 'repo/master' into stats
Ben Pfaff [Tue, 15 Apr 2008 16:57:38 +0000 (09:57 -0700)]
Merge remote branch 'repo/master' into stats

Conflicts:

datapath/table-mac.c

16 years agoExpand tabs to spaces in dp_send_flow_stats.
Ben Pfaff [Tue, 15 Apr 2008 16:53:37 +0000 (09:53 -0700)]
Expand tabs to spaces in dp_send_flow_stats.

Suggested by Justin.

16 years agoMake table_id in OpenFlow messages 8 bits, since 255 should be enough.
Ben Pfaff [Tue, 15 Apr 2008 16:33:07 +0000 (09:33 -0700)]
Make table_id in OpenFlow messages 8 bits, since 255 should be enough.

Suggested by Justin.

16 years agoMake duration in ofp_flow_stats a 32-bit quantity (instead of 16).
Ben Pfaff [Tue, 15 Apr 2008 03:20:20 +0000 (20:20 -0700)]
Make duration in ofp_flow_stats a 32-bit quantity (instead of 16).

Otherwise duration is capped at under 24 hours.

Suggested by Justin.

16 years agoAdd missing calls to htons/ntohs in accesses to miss_send_len.
Ben Pfaff [Tue, 15 Apr 2008 03:08:14 +0000 (20:08 -0700)]
Add missing calls to htons/ntohs in accesses to miss_send_len.

Thanks to Justin for pointing out the problem.

16 years agoMIPS fixes based on suggestions from Jiang.
Justin Pettit [Mon, 14 Apr 2008 07:10:48 +0000 (00:10 -0700)]
MIPS fixes based on suggestions from Jiang.

16 years agoAdd support for OFPP_TABLE virtual port.
Justin Pettit [Sat, 12 Apr 2008 00:40:05 +0000 (17:40 -0700)]
Add support for OFPP_TABLE virtual port.

16 years agoFix compilation error in 2.4.20 kernels.
Justin Pettit [Fri, 11 Apr 2008 21:40:29 +0000 (14:40 -0700)]
Fix compilation error in 2.4.20 kernels.

16 years agoRemove MAC table support.
Justin Pettit [Fri, 11 Apr 2008 01:31:44 +0000 (18:31 -0700)]
Remove MAC table support.

16 years agoFixes to configure script based on suggestions from GigaFin.
Justin Pettit [Thu, 10 Apr 2008 23:51:46 +0000 (16:51 -0700)]
Fixes to configure script based on suggestions from GigaFin.

16 years agoChanges based on feedback from GigaFin.
Justin Pettit [Thu, 10 Apr 2008 22:50:25 +0000 (15:50 -0700)]
Changes based on feedback from GigaFin.

16 years agoFixed minor tab/spaces issue.
Justin Pettit [Tue, 8 Apr 2008 07:10:08 +0000 (00:10 -0700)]
Fixed minor tab/spaces issue.

16 years agoDon't read info->attrs[DP_GENL_A_OPENFLOW] twice, unnecessarily.
Ben Pfaff [Mon, 7 Apr 2008 20:55:47 +0000 (13:55 -0700)]
Don't read info->attrs[DP_GENL_A_OPENFLOW] twice, unnecessarily.

16 years agoImplement OpenFlow statistics in switches and in dpctl.
Ben Pfaff [Fri, 4 Apr 2008 23:17:46 +0000 (16:17 -0700)]
Implement OpenFlow statistics in switches and in dpctl.

This has two notable omissions.  First, only at most 4k of flow statistics
are reported.  Second, aggregate statistics are not yet supported.  Both
of these are fairly easily fixable, just not fixed yet.

16 years agoSend replies to OpenFlow requests only to the sender.
Ben Pfaff [Thu, 3 Apr 2008 22:15:44 +0000 (15:15 -0700)]
Send replies to OpenFlow requests only to the sender.

16 years agoFactor out parsing vconn-ssl options.
Ben Pfaff [Fri, 4 Apr 2008 00:02:07 +0000 (17:02 -0700)]
Factor out parsing vconn-ssl options.

16 years agoFactor out printing the list of available vconns.
Ben Pfaff [Thu, 3 Apr 2008 19:52:19 +0000 (12:52 -0700)]
Factor out printing the list of available vconns.

16 years agoBreak data_hello and control_hello messages into multiple messages.
Ben Pfaff [Thu, 3 Apr 2008 18:40:16 +0000 (11:40 -0700)]
Break data_hello and control_hello messages into multiple messages.

We want to allow multiple OpenFlow connections to a switch, so that
dpctl and other management tools can also connect to a switch that
is connecte to the controller.  These tools will want to fetch the
information in the data_hello message, but currently this can only
be done by sending a control_hello message, which changes the
switch configuration state.  So breaking the hello messages up into
multiple different messages, only some of which affect configuration
state, cures the problem.

Also, clean up the kernel datapath a bit, by adding helper functions
for allocating and resizing Generic Netlink messages that encapsulate
OpenFlow messages.

16 years agoAllow secchan to listen for management connections also.
Ben Pfaff [Fri, 4 Apr 2008 23:20:28 +0000 (16:20 -0700)]
Allow secchan to listen for management connections also.

This is needed in the userspace switch code also.  That
change is implemented in later change "Send replies to
OpenFlow requests only to the sender".  Really that part
of the change should be moved into this one, but intervening
changes are intertwined enough with the same code to
make that difficult.

16 years agoRename controller_connection to rconn and use it in secchan also.
Ben Pfaff [Wed, 2 Apr 2008 17:55:17 +0000 (10:55 -0700)]
Rename controller_connection to rconn and use it in secchan also.

Also, clean up code and add comments.

16 years agoMake vconn-tcp log an error when the connection drops mid-packet.
Ben Pfaff [Thu, 3 Apr 2008 16:28:13 +0000 (09:28 -0700)]
Make vconn-tcp log an error when the connection drops mid-packet.

16 years agoMake vconn log all incoming and outgoing OpenFlow packets at debug level.
Ben Pfaff [Thu, 3 Apr 2008 16:27:40 +0000 (09:27 -0700)]
Make vconn log all incoming and outgoing OpenFlow packets at debug level.

16 years agoAdd new functions for pretty-printing an OpenFlow message to a string.
Ben Pfaff [Thu, 3 Apr 2008 00:10:16 +0000 (17:10 -0700)]
Add new functions for pretty-printing an OpenFlow message to a string.

This makes it possible to send pretty-printed versions of OpenFlow
messages to vlog.

16 years agoAdd vlog functions and macros for testing whether a module and level are enabled.
Ben Pfaff [Thu, 3 Apr 2008 15:28:04 +0000 (08:28 -0700)]
Add vlog functions and macros for testing whether a module and level are enabled.

16 years agoFix bug in vconn-tcp, vconn-ssl that prevented minimum-length OpenFlow packets from...
Ben Pfaff [Fri, 4 Apr 2008 23:02:46 +0000 (16:02 -0700)]
Fix bug in vconn-tcp, vconn-ssl that prevented minimum-length OpenFlow packets from being received correctly.

16 years agoFix logic bug in userspace switch that could cause reading invalid memory.
Ben Pfaff [Thu, 3 Apr 2008 16:57:08 +0000 (09:57 -0700)]
Fix logic bug in userspace switch that could cause reading invalid memory.

Also, fix comment.

16 years agoBy more liberal (egads!) about allocating space for netlink messages.
Justin Pettit [Wed, 2 Apr 2008 23:45:28 +0000 (16:45 -0700)]
By more liberal (egads!) about allocating space for netlink messages.

16 years agoAllow timeout implementations to block, by using a kernel thread instead of a timer.
Ben Pfaff [Tue, 1 Apr 2008 16:41:21 +0000 (09:41 -0700)]
Allow timeout implementations to block, by using a kernel thread instead of a timer.

This is required on the Quanta platform, which needs to down a semaphore
inside the timeout implementation.

Also, add a 2.4 compatibility implementation of kthread so that both
2.4 and 2.6 can use the kthread API.

16 years agoFix typo in comment.
Ben Pfaff [Mon, 31 Mar 2008 22:23:53 +0000 (15:23 -0700)]
Fix typo in comment.

16 years agoAdd clarifying comment.
Ben Pfaff [Tue, 1 Apr 2008 17:00:40 +0000 (10:00 -0700)]
Add clarifying comment.

16 years agoGet rid of tables' dependency on the datapath.
Ben Pfaff [Mon, 31 Mar 2008 20:49:28 +0000 (13:49 -0700)]
Get rid of tables' dependency on the datapath.

16 years agoMake the datapath responsible for the controller connection also.
Ben Pfaff [Mon, 31 Mar 2008 16:59:32 +0000 (09:59 -0700)]
Make the datapath responsible for the controller connection also.

16 years agoMerge datapath.[ch] with forward.[ch].
Ben Pfaff [Mon, 31 Mar 2008 16:58:13 +0000 (09:58 -0700)]
Merge datapath.[ch] with forward.[ch].