Eric Blake [Wed, 2 Dec 2009 22:48:08 +0000 (15:48 -0700)]
test-getopt: test stderr behavior
Portions of this commit are commented out because they tickle
glibc bugs. For a real-life example of the bug:
$ env -ua -:
env: invalid option -- :
Try `env --help' for more information.
$ env -:
env: invalid option -- :
Try `env --help' for more information.
$ env -+
env: invalid option -- +
Try `env --help' for more information.
$ env -ua -+
Try `env --help' for more information.
Notice that when -+ is not given as the first argument, the
error message is mistakenly suppressed.
* modules/getopt-posix-tests (Depends-on): Add dup2.
* tests/test-getopt.c (ASSERT): Avoid stderr.
(main): Move stderr to a temporary file.
* tests/test-getopt.h (getopt_loop): No longer manipulate opterr.
Instead, add parameter to inform caller if output occurred.
(test_getopt): Adjust all tests to expect silence, and add new
tests of leading ":".
* doc/glibc-functions/getopt_long.texi (getopt_long): Document
glibc shortcomings with leading "-:" or "+:" in optstring.
* doc/glibc-functions/getopt_long_only.texi (getopt_long_only):
Likewise.
* doc/posix-functions/getopt.texi (getopt): Likewise.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Wed, 2 Dec 2009 00:21:34 +0000 (17:21 -0700)]
test-getopt: enhance test
Add coverage of optind==0 for getopt_long, since coreutils
depends on it. Also test an optstring containing "W;", since
that tends to expose corner-case bugs (even in glibc, so the
test is weaker than it could be).
* m4/getopt.m4 (gl_GETOPT_CHECK_HEADERS): Require that getopt_long
supports optind=0.
* tests/test-getopt.c (OPTIND_MIN): Move...
* tests/test-getopt.h (OPTIND_MIN): ...here.
* tests/test-getopt_long.h (test_getopt_long): Add more coverage.
Require that optind=0 works, since modern BSD supports it in
addition to optreset, and since coreutils expects it.
(test_getopt_long_only): New test.
* doc/glibc-functions/getopt_long.texi (getopt_long): Document
glibc shortcomings with 'W;', and enforcement of optind=0.
* doc/glibc-functions/getopt_long_only.texi (getopt_long_only):
Likewise.
Bruno Haible [Tue, 22 Dec 2009 00:58:14 +0000 (01:58 +0100)]
Tweak last commit.
Bruno Haible [Tue, 22 Dec 2009 00:35:04 +0000 (01:35 +0100)]
localename: Improvements for MacOS X and Cygwin.
Bruno Haible [Tue, 22 Dec 2009 00:08:25 +0000 (01:08 +0100)]
localename: Update list of Win32 locale ids.
Eric Blake [Mon, 21 Dec 2009 14:00:13 +0000 (07:00 -0700)]
test-utimens: avoid spurious failure
Fixes a spurious failure on ext3, with one-second resolution,
now that ctime effects are being tested for inequality.
* tests/test-chown.h (nap): Factor...
* tests/nap.h: ...into new file.
* tests/test-lchown.h (nap): Avoid duplication.
* tests/test-utimens-common.h (nap): Use shared implementation,
necessary on file systems with 1-second resolution.
* modules/chown-tests (Files): Include new file.
* modules/fdutimensat-tests (Files): Likewise.
* modules/futimens-tests (Files): Likewise.
* modules/lchown-tests (Files): Likewise.
* modules/openat-tests (Files): Likewise.
* modules/utimens-tests (Files): Likewise.
* modules/utimensat-tests (Files): Likewise.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Thu, 17 Dec 2009 14:32:00 +0000 (07:32 -0700)]
futimens, utimensat: work around Linux bug
futimens is trivial - let fdutimens do the work. utimensat
is tougher: we don't want to call into local_utimensat,
because that can cause unnecessary chdir. So we have to
repeat the logic from utimens.c.
* m4/futimens.m4 (gl_FUNC_FUTIMENS): Detect ctime bug.
* m4/utimensat.m4 (gl_FUNC_UTIMENSAT): Likewise.
* lib/utimensat.c (rpl_utimensat): Work around it.
* lib/futimens.c (rpl_futimens): Adjust comment.
Eric Blake [Thu, 17 Dec 2009 23:57:37 +0000 (16:57 -0700)]
utimens: work around Linux ctime bug
Force a ctime update by using stat() before any utimensat call
with mtime of UTIME_OMIT. But avoid extra stat()s in later
calls, by doing extra work on the first instance in order to
cache whether the bug is actually present.
* lib/utimens.c (detect_ctime_bug): New helper function.
(update_timespec): Differentiate between workaround needed for
this bug vs. what is needed for systems that lack utimensat.
(fdutimens, lutimens): Work around bug.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Thu, 17 Dec 2009 19:30:47 +0000 (12:30 -0700)]
utimens: check for ctime update
futimens/utimensat on Linux fails to bump ctime if mtime is
UTIME_OMIT and atime is specified.
* tests/test-utimens-common.h (check_ctime): Define.
* tests/test-utimens.h (test_utimens): Expose the Linux bug.
* tests/test-futimens.h (test_futimens): Likewise.
* tests/test-lutimens.h (test_lutimens): Likewise.
* doc/posix-functions/futimens.texi (futimens): Document the bug.
* doc/posix-functions/utimensat.texi (utimensat): Likewise.
Signed-off-by: Eric Blake <ebb9@byu.net>
Bruno Haible [Sat, 19 Dec 2009 21:44:53 +0000 (22:44 +0100)]
Correct position of 'Applicability' section.
Bruno Haible [Sat, 19 Dec 2009 21:17:02 +0000 (22:17 +0100)]
dprintf-posix: Check against memory leak fixed on 2009-12-15.
Bruno Haible [Sat, 19 Dec 2009 21:15:32 +0000 (22:15 +0100)]
fprintf-posix: Check against memory leak fixed on 2009-12-15.
Eric Blake [Sat, 19 Dec 2009 18:49:32 +0000 (11:49 -0700)]
dirfd: fix prototype
Fix prototype to match POSIX.
* lib/dirent.in.h (dirfd): Argument is not const, per POSIX.
* lib/dirfd.c (dirfd): Likewise.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Sat, 19 Dec 2009 16:28:36 +0000 (09:28 -0700)]
canonicalize: reduce memory usage
canonicalize was returning a 4k buffer for everything, even though
the majority of canonical path names are much shorter. This
resulted in a lot of unused memory, which in turn made tar run
out of memory when tracking a lot of files:
http://lists.gnu.org/archive/html/bug-tar/2009-12/msg00011.html
* lib/canonicalize.c (canonicalize_filename_mode): Trim the
allocation to size.
Reported by Solar Designer <solar@openwall.com>.
Signed-off-by: Eric Blake <ebb9@byu.net>
Bruno Haible [Sat, 19 Dec 2009 14:27:58 +0000 (15:27 +0100)]
New module attribute 'Applicability'.
Bruno Haible [Sat, 19 Dec 2009 11:30:24 +0000 (12:30 +0100)]
fflush: tweak
José E. Marchesi [Sat, 19 Dec 2009 10:06:10 +0000 (11:06 +0100)]
Fix typo in comment.
Eric Blake [Wed, 16 Dec 2009 17:07:13 +0000 (10:07 -0700)]
fcntl: use to simplify other modules
Let fcntl do the work, instead of copying code into other modules.
* modules/cloexec (Depends-on): Add fcntl.
* modules/fchdir (Depends-on): Likewise.
* modules/fd-safer-flag (Depends-on): Likewise.
* modules/unistd-safer (Depends-on): Likewise.
* modules/dup3 (configure.ac): Set module indicator.
* m4/fchdir.m4 (gl_FUNC_FCHDIR): Replace fcntl if fchdir is
missing.
* lib/fchdir.c (_gl_register_dup): Fix comment.
* lib/cloexec.c (dup_cloexec): Simplify, by relying on fcntl.
* lib/dup-safer.c (dup_safer): Likewise.
* lib/dup-safer-flag.c (dup_safer_flag): Likewise.
* lib/dup3.c (dup3): Likewise.
* tests/test-fchdir.c (main): Enhance test.
Fixes a dup_cloexec bug reported by Ondřej Vašík.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Wed, 16 Dec 2009 16:11:32 +0000 (09:11 -0700)]
fcntl: port portions of fcntl to mingw
Borrow ideas from dup_cloexec and dup3 to implement F_DUPFD and
F_DUPFD_CLOEXEC. Support querying the inheritance status via
F_GETFD, but for now, no support for changing with F_SETFD.
The remaining portions of fcntl fail with EINVAL.
* m4/fcntl.m4 (gl_FUNC_FCNTL): Also build fcntl.c on mingw.
* lib/fcntl.c (fcntl) <F_DUPFD, F_DUPFD_CLOEXEC, F_GETFD>: Provide
replacement for mingw.
* modules/fcntl (Description): Update.
(Depends-on): Add dup2.
* m4/fcntl_h.m4 (gl_FCNTL_H_DEFAULTS): Add witness.
* modules/fcntl-h (Makefile.am): Substitute it.
* lib/fcntl.in.h (fcntl): Update declaration.
(F_DUPFD, F_GETFD): New macros, when needed.
* doc/posix-headers/fcntl.texi (fcntl.h): Update documentation.
* doc/posix-functions/fcntl.texi (fcntl): Likewise.
* tests/test-fcntl.c (check_flags, main): Enhance test for items
we now guarantee.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Tue, 8 Dec 2009 19:10:52 +0000 (12:10 -0700)]
fcntl: work around cygwin bug in F_DUPFD
fcntl(0,F_DUPFD,
10000000) mistakenly failed with EMFILE
instead of EINVAL, and fcntl(0,F_DUPFD,-1) mistakenly passed.
* m4/fcntl.m4 (gl_REPLACE_FCNTL): New macro.
(gl_FUNC_FCNTL): Use it. Test for F_DUPFD bug.
* lib/fcntl.c (rpl_fcntl) <F_DUPFD>: Work around it.
<F_DUPFD_CLOEXEC>: Reduce calls to _gl_register_dup.
* doc/posix-functions/fcntl.texi (fcntl): Document it.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Mon, 7 Dec 2009 18:50:59 +0000 (11:50 -0700)]
fcntl: support F_DUPFD_CLOEXEC on systems with fcntl
Implement F_DUPFD_CLOEXEC. The unit test still fails on systems
with other fcntl bugs (such as cygwin 1.5 mishandling F_DUPFD,
or mingw lacking fcntl altogether). Passes on Linux, both with
and without kernel support, and on cygwin 1.7.
* modules/fcntl (Files): List new files.
(configure.ac): Run a test.
* m4/fcntl.m4 (gl_FUNC_FCNTL): New file.
* lib/fcntl.c (rpl_fcntl): Likewise.
* m4/fcntl_h.m4 (gl_FCNTL_H_DEFAULTS): Add witness defaults.
(gl_FCNTL_H): Always replace fcntl.h.
* modules/fcntl-h (Makefile.am): Substitute witnesses.
* lib/fcntl.in.h (fcntl): Declare replacement.
(F_DUPFD_CLOEXEC, GNULIB_defined_F_DUPFD_CLOEXEC): New macro when
needed, plus a witness.
* doc/posix-functions/fcntl.texi (fcntl): Document this.
* doc/posix-headers/fcntl.texi (fcntl.h): Likewise.
* tests/test-fcntl.c: New file.
* modules/fcntl-tests: Likewise.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Wed, 16 Dec 2009 16:24:23 +0000 (09:24 -0700)]
binary-io: avoid potential compilation warning
* lib/binary-io.h [__DJGPP__]: Avoid null preprocessor
directives.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Mon, 14 Dec 2009 22:42:13 +0000 (15:42 -0700)]
fflush: avoid compilation error on NetBSD
On NetBSD, the system <stdio.h> header contains:
|#if (!defined(_ANSI_SOURCE) && !defined(__STRICT_ANSI__)) || defined(_LIBC)
|typedef __off_t fpos_t;
|#else
|typedef struct __sfpos {
| __off_t _pos;
|} fpos_t;
|#endif
Thus, based on compiler flags (such as using 'gcc -ansi' or the
Intel compiler), it is an error to directly set fpos_t=off_t.
* lib/fflush.c (update_fpos_cache): Use a union to safely convert
between off_t and fpos_t, since the latter is sometimes a struct.
* lib/fseeko.c (rpl_fseeko): Likewise.
Reported by Alexander Nasonov <alnsn@yandex.ru>.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Tue, 15 Dec 2009 13:51:24 +0000 (06:51 -0700)]
fcntl-h, stdio, sys_ioctl: fix declarations
We cannot use a function-like macro to provide a link-time warning
of a variadic function during GNULIB_POSIXCHECK; at least, not
without assuming C99 variadic macros. We can, however,
use an object-like macro (as was already done for printf).
On the other hand, this patch is only a stop-gap measure to fix
an obvious bug; a more complete patch that switches from a
link-time warning (specific to GNU ld, gcc, and ELF image) to
a compile-time attribute is in the works.
* lib/stdio.in.h (dprintf): Use of link warning on a variadic
function must not take arguments.
* lib/sys_ioctl.in.h (ioctl): Likewise.
* lib/fcntl.in.h (openat): Likewise. Declare extern.
(open): Add a link warning.
Signed-off-by: Eric Blake <ebb9@byu.net>
Jim Meyering [Tue, 15 Dec 2009 09:28:04 +0000 (10:28 +0100)]
areadlink, areadlink-with-size: relax license to LGPLv2+
* modules/areadlink (License): Relax to LGPLv2+.
* modules/areadlink-with-size (License): Likewise.
Joel E. Denny [Tue, 15 Dec 2009 09:07:39 +0000 (10:07 +0100)]
*printf: Fix memory leak.
Eric Blake [Tue, 15 Dec 2009 05:11:50 +0000 (22:11 -0700)]
accept4: adjust module dependencies
* modules/accept4 (Depends-on): Use fcntl-h, not fcntl.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Tue, 15 Dec 2009 05:07:15 +0000 (22:07 -0700)]
utimens: one more try at avoiding compiler warning
* lib/utimens.c (lutimens): Lower scope of result.
Signed-off-by: Eric Blake <ebb9@byu.net>
Karl Berry [Mon, 14 Dec 2009 15:04:35 +0000 (07:04 -0800)]
autoupdate
Bruno Haible [Sun, 13 Dec 2009 23:24:41 +0000 (00:24 +0100)]
Move the malloc checking from module 'list' to new module 'xlist'.
Bruno Haible [Sun, 13 Dec 2009 19:27:44 +0000 (20:27 +0100)]
Move the malloc checking from module 'oset' to new module 'xoset'.
Alfred M. Szmidt [Sun, 13 Dec 2009 14:11:14 +0000 (15:11 +0100)]
maint.mk: allow a project to override release-prep commands
* top/maint.mk (alpha, beta, stable): Move release-preparatory
commands into a new rule.
(release-prep): New rule.
(release-prep-hook): New overridable variable.
Bruno Haible [Sun, 13 Dec 2009 11:07:21 +0000 (12:07 +0100)]
localcharset: Fix comment.
Jim Meyering [Sun, 13 Dec 2009 09:14:25 +0000 (10:14 +0100)]
maint.mk (null_AM_MAKEFLAGS, built_programs): remove unused definitions
* top/maint.mk (null_AM_MAKEFLAGS, built_programs): Remove definitions.
Bruno Haible [Sat, 12 Dec 2009 17:27:59 +0000 (18:27 +0100)]
duplocale: Tweak.
Karl Berry [Sat, 12 Dec 2009 16:46:42 +0000 (08:46 -0800)]
autoupdate
Karl Berry [Sat, 12 Dec 2009 16:44:50 +0000 (08:44 -0800)]
tab changes -> no sync for strtoll.c
Bruno Haible [Sat, 12 Dec 2009 14:33:49 +0000 (15:33 +0100)]
Tweak whitespace.
Bruno Haible [Sat, 12 Dec 2009 14:31:09 +0000 (15:31 +0100)]
Undo incorrect untabification.
Bruno Haible [Sat, 12 Dec 2009 14:13:35 +0000 (15:13 +0100)]
c-strtod, c-strtold: Use the multithread-safe implementation on MacOS X.
Bruno Haible [Sat, 12 Dec 2009 13:46:27 +0000 (14:46 +0100)]
localcharset: Add comment.
Eric Blake [Thu, 10 Dec 2009 19:18:31 +0000 (12:18 -0700)]
setenv: relax requirement in light of POSIX ruling
Requiring that {un,}setenv gracefully reject NULL is just a waste
of processing power; POSIX agreed to this argument in
http://austingroupbugs.net/view.php?id=185
so we no longer worry whether a native implementation handles NULL.
* m4/setenv.m4 (gl_FUNC_SETENV_SEPARATE): Test handling of "" but
not NULL.
* tests/test-setenv.c (main): Relax test.
* tests/test-unsetenv.c (main): Likewise.
* doc/posix-functions/setenv.texi (setenv): Document this.
* doc/posix-functions/unsetenv.texi (unsetenv): Likewise.
Signed-off-by: Eric Blake <ebb9@byu.net>
Bruno Haible [Fri, 11 Dec 2009 19:59:01 +0000 (20:59 +0100)]
New module 'fd-safer-flag'.
Bruno Haible [Fri, 11 Dec 2009 19:11:22 +0000 (20:11 +0100)]
Tests for module 'nl_langinfo'.
Bruno Haible [Fri, 11 Dec 2009 19:09:02 +0000 (20:09 +0100)]
New module 'nl_langinfo'.
Bruno Haible [Fri, 11 Dec 2009 18:59:02 +0000 (19:59 +0100)]
Tests for module 'langinfo'.
Bruno Haible [Fri, 11 Dec 2009 18:57:37 +0000 (19:57 +0100)]
New module 'langinfo'.
Bruno Haible [Fri, 11 Dec 2009 16:55:51 +0000 (17:55 +0100)]
Untabify.
Eric Blake [Fri, 11 Dec 2009 16:33:55 +0000 (09:33 -0700)]
ChangeLog: remove spurious byte
Bruno Haible [Fri, 11 Dec 2009 16:24:22 +0000 (17:24 +0100)]
unistd-safer: Remove unused indicator macro.
Bruno Haible [Fri, 11 Dec 2009 14:28:11 +0000 (15:28 +0100)]
Move pipe2-safer code to its own file.
Bruno Haible [Fri, 11 Dec 2009 00:31:21 +0000 (01:31 +0100)]
recvfrom: Allow NULL argument.
Bruno Haible [Fri, 11 Dec 2009 00:15:28 +0000 (01:15 +0100)]
New module 'arg-nonnull'. Declare which arguments expect non-NULL values.
Bruno Haible [Thu, 10 Dec 2009 19:28:30 +0000 (20:28 +0100)]
Use spaces for indentation, not tabs.
Bruno Haible [Thu, 10 Dec 2009 18:15:51 +0000 (19:15 +0100)]
pty test: Fix link error.
Simon Josefsson [Thu, 10 Dec 2009 13:14:13 +0000 (14:14 +0100)]
Add pty module for forkpty and openpty.
Bruno Haible [Thu, 10 Dec 2009 13:08:47 +0000 (14:08 +0100)]
stdio: Avoid syntax error in C++ mode.
Bruno Haible [Thu, 10 Dec 2009 11:22:41 +0000 (12:22 +0100)]
Use sed with option -e.
Jim Meyering [Thu, 10 Dec 2009 11:17:19 +0000 (12:17 +0100)]
mgetgroups: do not write bytes beyond end of malloc'd buffer
* lib/mgetgroups.c: Fix an off-by-one error. When we have no
username, we call getgroups with a one-element-shorter buffer,
but still told it the length was original, max_n_groups.
Eric Blake [Thu, 10 Dec 2009 00:14:12 +0000 (17:14 -0700)]
cloexec: relax license
cloexec is a thin wrapper around fcntl, which is a glibc function
and therefore reasonable for LGPL. Jim Meyering and Bruno Haible
agreed to the change.
* modules/cloexec (Maintainer): Add myself.
(License): Use LGPL, not GPL.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Wed, 9 Dec 2009 23:11:27 +0000 (16:11 -0700)]
link-warning: optimize generation
Avoid a useless use of cat.
* modules/link-warning (Makefile.am): Reduce process usage.
Signed-off-by: Eric Blake <ebb9@byu.net>
Bruno Haible [Wed, 9 Dec 2009 21:04:36 +0000 (22:04 +0100)]
unsetenv: Document last workaround.
Jim Meyering [Wed, 9 Dec 2009 16:34:02 +0000 (17:34 +0100)]
link-warning: Allow extra lines at the top of build-aux/link-warning.h.
Bruno Haible [Wed, 9 Dec 2009 13:13:08 +0000 (14:13 +0100)]
mgetgroups: Avoid undefined behaviour when ng == 0.
Bruno Haible [Wed, 9 Dec 2009 11:41:19 +0000 (12:41 +0100)]
link-warning: Add copyright notice.
Bruno Haible [Wed, 9 Dec 2009 11:11:36 +0000 (12:11 +0100)]
fchdir: Optimize away rpl_fstat when possible.
Bruno Haible [Wed, 9 Dec 2009 10:49:30 +0000 (11:49 +0100)]
fchdir: Update comment.
Bruno Haible [Wed, 9 Dec 2009 10:37:17 +0000 (11:37 +0100)]
Fix a recent ChangeLog entry.
Bruno Haible [Wed, 9 Dec 2009 10:21:35 +0000 (11:21 +0100)]
cloexec: Clarify code.
Eric Blake [Tue, 8 Dec 2009 17:23:27 +0000 (10:23 -0700)]
fchdir: avoid memory leak on re-registration.
Some code paths (such as dup3) could overwrite one registered
directory fd with another, and must not leak the old name.
* lib/fchdir.c (ensure_dirs_slot): Avoid memory leak.
Signed-off-by: Eric Blake <ebb9@byu.net>
Jim Meyering [Tue, 8 Dec 2009 19:37:50 +0000 (20:37 +0100)]
init.sh: avoid Solaris 10 /bin/sh portability problem
Solaris 10's /bin/sh does not pass '.' arguments 2..N to the
sourced script:
$ printf 'echo "$@"\n' > f; /bin/sh -c '. ./f bar'
$ printf 'echo "$@"\n' > f; bash -c '. ./f bar'
bar
tests/init.sh relied on that, accepting a --set-path=DIR argument,
and two tests used that idiom.
* tests/init.sh: Update suggested usage comments.
(path_prepend_): New function, to be used in place of
the --src-path=DIR option.
Disallow empty strings and strings containing ":".
(setup_): Move PATH-prepending code into path_prepend_.
* tests/test-pread.sh: Adapt to new usage.
* tests/test-xalloc-die.sh: Likewise.
Simon Josefsson [Tue, 8 Dec 2009 16:44:19 +0000 (17:44 +0100)]
Document pty.h functions.
Eric Blake [Tue, 8 Dec 2009 13:13:05 +0000 (06:13 -0700)]
fchdir: fix logic bugs
Configuring with ac_cv_func_fchdir=no on a system that has fchdir
and where open handles directories, just to test out the replacement
capabilities, uncovered an m4 test bug and a link failure on rpl_fstat.
* m4/fchdir.m4 (gl_FUNC_FCHDIR): Fix logic bug.
* tests/test-fchdir.c (main): Enhance test.
* lib/fchdir.c (rpl_fstat): Always provide if fchdir replacement
is in use.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Tue, 8 Dec 2009 04:08:17 +0000 (21:08 -0700)]
dup2: fix logic bugs
If the platform has dup2, don't register with fchdir if the
destination was -1.
If the platform lacks dup2 (are there any these days?), then don't
close the destination unless the source is valid, make sure errno
is correct, and only register with fchdir on fcntl (since dup is
already overridden to do a registration).
* lib/dup2.c (dup2): Fix logic bugs. Use HAVE_DUP2 rather than
REPLACE_DUP2 to decide when rpl_dup2 is needed.
* m4/dup2.m4 (gl_REPLACE_DUP2): Only define REPLACE_DUP2 when dup2
exists.
(gl_FUNC_DUP2): Drop unneeded AC_SUBST.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Tue, 8 Dec 2009 00:15:07 +0000 (17:15 -0700)]
unlink: fix m4 detection
The m4 test failed under -Werror due to implicit declaration.
* m4/unlink.m4 (gl_FUNC_UNLINK): Include correct header.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Mon, 7 Dec 2009 17:17:07 +0000 (10:17 -0700)]
unistd-safer: add unit test
Add more unit tests. Meanwhile, fix compilation error on mingw when
testing unistd-safer and fchdir together; and avoid gcc warning on
platforms without setmode.
* modules/unistd-safer-tests: New file.
* tests/test-dup-safer.c: Likewise.
* tests/test-cloexec.c (setmode): Avoid compiler warning.
* tests/test-dup2.c (setmode): Likewise.
* lib/cloexec.c (dup_cloexec): Fix mingw compile error.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Mon, 7 Dec 2009 13:53:59 +0000 (06:53 -0700)]
cloexec: preserve text vs. binary across dup_cloexec
On mingw, dup_cloexec mistakenly converted a text fd into a
binary fd. Cygwin copied the source mode. Most other platforms
don't distinguish between modes.
* lib/cloexec.c (dup_cloexec) [W32]: Query and use translation
mode.
* modules/dup2-tests (Depends-on): Add binary-io.
* modules/cloexec-tests (Depends-on): Likewise.
* tests/test-dup2.c (setmode, is_mode): New helpers.
(main): Add tests that translation mode is preserved.
* tests/test-cloexec.c (setmode, is_mode, main): Likewise.
Reported by Bruno Haible.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Fri, 4 Dec 2009 21:07:58 +0000 (14:07 -0700)]
mgetgroups: reduce duplicate listings
POSIX doesn't guarantee whether the effective gid is included in
the list of supplementary groups returned by getgroups. On the
other hand, some platforms include the effective gid twice in
the list. Meanwhile, mgetgroups can independently add a duplicate.
Rather than spend a full-blown O(n log n) cleanup, we just remove
the most common forms of duplicate groups with an O(n) pass.
* lib/mgetgroups.c (mgetgroups): Reduce duplicates from the
resulting array.
* tests/test-chown.h (test_chown): Simplify client.
* tests/test-lchown.h (test_lchown): Likewise.
Signed-off-by: Eric Blake <ebb9@byu.net>
Bruno Haible [Mon, 7 Dec 2009 00:02:50 +0000 (01:02 +0100)]
cloexec: Fix possible compilation error.
Bruno Haible [Sun, 6 Dec 2009 22:19:49 +0000 (23:19 +0100)]
prognam: Add diagnostic.
Eric Blake [Sat, 5 Dec 2009 13:39:09 +0000 (06:39 -0700)]
pipe2-safer: new module
pipe2 deserves a *_safer variant. It also makes the code in
pipe.c look simpler.
* modules/pipe2-safer: New file.
* lib/unistd-safer.h (pipe2_safer): New prototype.
* lib/unistd--.h (pipe2): New wrapper.
* lib/pipe-safer.c (pipe2_safer): New function.
* modules/pipe (Depends-on): Add pipe2-safer.
* lib/pipe.c (create_pipe) [WIN32]: Let pipe2_safer do the work.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Mon, 16 Nov 2009 23:09:42 +0000 (16:09 -0700)]
stdlib-safer: preserve cloexec flag for mkostemp[s]
mkostemp_safer(templ,O_CLOEXEC) did not always guarantee cloexec.
* lib/mkstemp-safer.c (mkostemp_safer, mkostemps_safer): Use new
fd_safer_flag.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Sat, 5 Dec 2009 13:36:33 +0000 (06:36 -0700)]
unistd-safer: allow preservation of cloexec status via flag
If cloexec is in use, allow the ability to preserve cloexec
flag across *_safer functions.
* lib/unistd-safer.h (dup_safer_flag, fd_safer_flag): New
prototypes.
* lib/dup-safer.c (dup_safer_flag): New function.
* lib/fd-safer.c (fd_safer_flag): Likewise.
* modules/cloexec (configure.ac): Set witness.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Sat, 5 Dec 2009 13:19:01 +0000 (06:19 -0700)]
test-dup2: enhance test
Ensure that dup2(cloexec_fd, target) returns an inheritable fd.
* modules/dup2-tests (Depends-on): Add cloexec.
* tests/test-dup2.c (main): Enhance test.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Sat, 5 Dec 2009 05:10:44 +0000 (22:10 -0700)]
cloexec: add dup_cloexec
This is needed to enforce correct semantics of mkostemp_safer.
Meanwhile, it is one step closer to providing O_CLOEXEC support
to open, as well as implementing portions of fcntl for mingw.
* lib/cloexec.h (dup_cloexec): New prototype. Add copyright
header and comments.
* lib/cloexec.c (set_cloexec_flag): Add comments.
(dup_cloexec): New function, with mingw implementation borrowed
from...
* lib/w32spawn.h (dup_noinherit): ...here.
* modules/execute (Depends-on): Add cloexec.
* modules/pipe (Depends-on): Likewise.
* modules/cloexec (Depends-on): Add dup2.
* modules/cloexec-tests (Files): New file.
* tests/test-cloexec.c: Likewise.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Sat, 5 Dec 2009 16:24:54 +0000 (09:24 -0700)]
test-xalloc-die: fix test for mingw
When cross-compiling on mingw to target mingw, argv[0] still includes
a .exe suffix. Rather than worry about ${EXEEXT}, just add a sed
post-process. Also, simplify the script by using tests/init.sh.
* modules/xalloc-die-tests (Files): Add tests/init.sh.
* tests/test-xalloc-die.sh: Rewrite to use init.sh. Strip
directory and .exe suffix off argv[0] output.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Sat, 5 Dec 2009 16:07:28 +0000 (09:07 -0700)]
test-fseeko: fix test for mingw
Undefining fseek made test-fseeko.sh fail when testing on pipes.
* tests/test-fseeko.c (fseek): Redefine GL_LINK_WARNING, rather
than undefining fseek, so test will pass on mingw.
Signed-off-by: Eric Blake <ebb9@byu.net>
Karl Berry [Sat, 5 Dec 2009 13:36:19 +0000 (05:36 -0800)]
autoupdate
Bruno Haible [Sat, 5 Dec 2009 11:14:04 +0000 (12:14 +0100)]
progname: Clarify specification.
Jim Meyering [Sat, 5 Dec 2009 09:02:01 +0000 (10:02 +0100)]
maint.mk: backslash-escape parens in default regexp
* top/maint.mk (news-check-regexp): Now that we're using grep -E,
backslash-escape the literal parentheses.
Jim Meyering [Sat, 5 Dec 2009 08:35:28 +0000 (09:35 +0100)]
maint.mk: news-check: use grep -E
* top/maint.mk (today): Define a Make variable, not a...
(news-date-check): ...shell variable.
(news-check-regexp): Use the Make variable.
Use grep's -E option. Change the failing diagnostic to mention
the variable, $(news-check-regexp).
(news-check): Rename target from news-date-check. Update sole use.
Alfred M. Szmidt [Sat, 5 Dec 2009 04:27:40 +0000 (21:27 -0700)]
maintainer-makefile: allow customization of NEWS entry format
* top/maint.mk (news-date-regexp): New overridable variable.
(news-date-check): Use it.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Fri, 4 Dec 2009 15:26:23 +0000 (08:26 -0700)]
mgetgroups: add xgetgroups, and avoid ENOSYS failures
ENOSYS implies that there are no supplemental groups, so we can
treat it the same as a return of 0 from getgroups rather than
exposing failure to the user. This in turn fixes a crash in
coreutils' id, which freed an uninitialized pointer.
* lib/mgetgroups.h (xgetgroups): New prototype.
* lib/mgetgroups.c (xgetgroups): New wrapper.
(mgetgroups): Handle ENOSYS.
* modules/mgetgroups (Depends-on): Add realloc.
Reported by Scott Harrison <scott.gnu.2009@scottrix.co.uk>.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Fri, 4 Dec 2009 21:37:32 +0000 (14:37 -0700)]
mgetgroups: avoid argument promotion issues with -1
On platforms where gid_t is equivalent to uint16_t, argument
promotion states that -1 != (gid_t) -1.
* lib/mgetgroups.c (mgetgroups): A cast is required when checking
for invalid gid_t.
* tests/test-chown.h (getegid, test_chown): Likewise.
* tests/test-lchown.h (getegid, test_lchown): Likewise.
Signed-off-by: Eric Blake <ebb9@byu.net>
Paolo Bonzini [Thu, 3 Dec 2009 17:39:47 +0000 (18:39 +0100)]
exclude: Fix header file problems.
* lib/exclude.h: Add multiple inclusion guards and include stdbool.h.
Karl Berry [Tue, 1 Dec 2009 14:38:45 +0000 (06:38 -0800)]
autoupdate
Jim Meyering [Tue, 1 Dec 2009 11:06:34 +0000 (12:06 +0100)]
fts: fts_open: do not let an empty string cause immediate failure
This is required in support of GNU rm, for which the command
"rm A '' B" must process and remove both A and B, in spite of
the empty string argument.
* lib/fts.c (fts_open): Do not let the presence of an empty string
cause fts_open to fail immediately. Most fts-using tools must be
able to process all arguments, in order, and can be expected to
diagnose such arguments themselves.
Also, move declaration of local, "len", "down" to initialization.
Eric Blake [Mon, 30 Nov 2009 13:45:42 +0000 (06:45 -0700)]
utimens: fix compilation error
Fixes a regression from 2009-11-25.
* lib/utimens.c (lutimens) [!HAVE_UTIMENSAT && HAVE_LUTIMES]:
Declare variable at right scope.
Signed-off-by: Eric Blake <ebb9@byu.net>
Pádraig Brady [Mon, 30 Nov 2009 12:29:03 +0000 (12:29 +0000)]
bootstrap: fix handling of various perl --version formats
* build-aux/bootstrap (get_version): Don't use perl's $] special
variable, as that requires updating all bootstrap.conf files to
use perl's x.yyyzzz version format. Instead make the regular
expression more general to support version formats from older
perl-5.005_002 (5.5.2) and perl-5.11 which has other numbers
in the version line.
Jim Meyering [Sun, 29 Nov 2009 12:57:05 +0000 (13:57 +0100)]
bootstrap: handle perl-5.11's changed --version output
* build-aux/bootstrap (get_version): Handle perl separately,
since perl-5.11's --version output is different.
projects / pspp / log