John Darrington [Mon, 18 Feb 2013 18:22:28 +0000 (19:22 +0100)]
Made it crash a little less often
John Darrington [Mon, 18 Feb 2013 15:05:12 +0000 (16:05 +0100)]
Avoided a number of other problems
John Darrington [Mon, 18 Feb 2013 12:46:41 +0000 (13:46 +0100)]
Fix buffer overflow
John Darrington [Sun, 17 Feb 2013 19:58:13 +0000 (20:58 +0100)]
Fixed some incorrect range imputation
John Darrington [Sun, 17 Feb 2013 17:30:14 +0000 (18:30 +0100)]
Got the ODS reader model (sort of) working.
John Darrington [Sun, 17 Feb 2013 11:09:29 +0000 (12:09 +0100)]
Merge two option structs
John Darrington [Sun, 17 Feb 2013 10:28:52 +0000 (11:28 +0100)]
Added a warning if gnumeric files are not UTF8. Then blidly assume that they are.
John Darrington [Sun, 17 Feb 2013 08:17:23 +0000 (09:17 +0100)]
Fixed some more warnings
John Darrington [Sun, 17 Feb 2013 08:14:51 +0000 (09:14 +0100)]
Make opts const
and remove the feature where it was filled in by the reader
John Darrington [Sun, 17 Feb 2013 07:21:48 +0000 (08:21 +0100)]
Add prototypes for syntax generation functions
John Darrington [Mon, 18 Feb 2013 08:35:53 +0000 (09:35 +0100)]
Zip Reader: Take members from the index if they exist.
This allows readers to be iterated more than once.
John Darrington [Sat, 16 Feb 2013 15:54:57 +0000 (16:54 +0100)]
Got the text file import working again
John Darrington [Sat, 16 Feb 2013 14:09:35 +0000 (15:09 +0100)]
Show errors on reading badly formed gnumeric files
John Darrington [Sat, 16 Feb 2013 10:48:00 +0000 (11:48 +0100)]
Made the text import dialogs sort of work again
John Darrington [Sat, 16 Feb 2013 06:59:29 +0000 (07:59 +0100)]
Return NULL if not a gnumeric file
John Darrington [Fri, 15 Feb 2013 12:22:29 +0000 (13:22 +0100)]
Actually use the combobox setting
John Darrington [Fri, 15 Feb 2013 11:08:21 +0000 (12:08 +0100)]
Fixed many warnings
John Darrington [Fri, 15 Feb 2013 08:46:30 +0000 (09:46 +0100)]
Gnumeric reader cope with multiple passes, and empty cell elements
John Darrington [Fri, 15 Feb 2013 07:05:18 +0000 (08:05 +0100)]
Rename sheet_index to current sheet
John Darrington [Thu, 14 Feb 2013 19:36:31 +0000 (20:36 +0100)]
Rename sheets to n_sheets
John Darrington [Thu, 14 Feb 2013 18:37:56 +0000 (19:37 +0100)]
Enable the syntax generation
John Darrington [Thu, 14 Feb 2013 18:02:49 +0000 (19:02 +0100)]
Make the data visible
John Darrington [Thu, 14 Feb 2013 13:35:45 +0000 (14:35 +0100)]
Updated the test widget thing a bit
John Darrington [Thu, 14 Feb 2013 10:23:13 +0000 (11:23 +0100)]
Use the gnumeric_reopen function
John Darrington [Thu, 14 Feb 2013 09:51:46 +0000 (10:51 +0100)]
Added a reopen capability
John Darrington [Tue, 29 Jan 2013 19:04:59 +0000 (20:04 +0100)]
Dont show range if it is null
John Darrington [Tue, 29 Jan 2013 18:26:23 +0000 (19:26 +0100)]
Added a proper function to convert spreadsheet column refs
John Darrington [Sun, 27 Jan 2013 19:41:07 +0000 (20:41 +0100)]
Added a callback to set the range entry on change
John Darrington [Sun, 27 Jan 2013 19:09:21 +0000 (20:09 +0100)]
Make both work at the same time
John Darrington [Sun, 27 Jan 2013 18:36:18 +0000 (19:36 +0100)]
Fix memory leak
John Darrington [Sun, 27 Jan 2013 18:17:41 +0000 (19:17 +0100)]
Added the range column to the model
John Darrington [Sun, 27 Jan 2013 10:38:18 +0000 (11:38 +0100)]
Added a maxcol state
John Darrington [Sun, 27 Jan 2013 09:03:35 +0000 (10:03 +0100)]
Tidied up a bit more. Eliminated some warnings
John Darrington [Sun, 27 Jan 2013 08:50:03 +0000 (09:50 +0100)]
Tidied up a bit
John Darrington [Sat, 26 Jan 2013 20:01:46 +0000 (21:01 +0100)]
sort of got the assistant working with the combo model
John Darrington [Sat, 26 Jan 2013 17:35:05 +0000 (18:35 +0100)]
Basically working model
John Darrington [Sat, 26 Jan 2013 11:46:50 +0000 (12:46 +0100)]
Added property for the backend
John Darrington [Sat, 26 Jan 2013 11:17:27 +0000 (12:17 +0100)]
Basic model
John Darrington [Sat, 26 Jan 2013 09:54:39 +0000 (10:54 +0100)]
Basic Framework for test program
John Darrington [Sat, 26 Jan 2013 09:04:02 +0000 (10:04 +0100)]
Added a test program for the spread interface
John Darrington [Thu, 24 Jan 2013 19:10:53 +0000 (20:10 +0100)]
Only one spreadsheet
John Darrington [Thu, 24 Jan 2013 18:58:51 +0000 (19:58 +0100)]
formats page: Construction is initialisation
John Darrington [Thu, 24 Jan 2013 18:33:59 +0000 (19:33 +0100)]
First line page construction is initialisation
John Darrington [Thu, 24 Jan 2013 18:09:47 +0000 (19:09 +0100)]
separators construction is initialisation
John Darrington [Thu, 24 Jan 2013 17:58:30 +0000 (18:58 +0100)]
Move column count from seperators into assist
John Darrington [Wed, 23 Jan 2013 20:35:03 +0000 (21:35 +0100)]
Make sheet spec page opaque
John Darrington [Wed, 23 Jan 2013 18:08:36 +0000 (19:08 +0100)]
Move all intro related stuff to the intro file
John Darrington [Tue, 22 Jan 2013 19:04:44 +0000 (20:04 +0100)]
Intro page: contruction is initialisation
John Darrington [Mon, 14 Jan 2013 17:42:47 +0000 (18:42 +0100)]
Move file_name member from sri to spreadsheet struct
John Darrington [Sun, 13 Jan 2013 18:43:04 +0000 (19:43 +0100)]
Put the pages as pointers
John Darrington [Sun, 13 Jan 2013 15:01:45 +0000 (16:01 +0100)]
Started polymorphism of ODS
John Darrington [Sun, 13 Jan 2013 12:08:58 +0000 (13:08 +0100)]
Started polymorphism of Gnumeric
John Darrington [Sun, 13 Jan 2013 09:27:28 +0000 (10:27 +0100)]
Made a start at canonicalising the interface
John Darrington [Sat, 12 Jan 2013 14:36:29 +0000 (15:36 +0100)]
Use convert cell range instead of doing it ourselves
John Darrington [Sat, 12 Jan 2013 12:08:58 +0000 (13:08 +0100)]
Enable specification of the cell range
John Darrington [Sat, 12 Jan 2013 11:15:59 +0000 (12:15 +0100)]
Replace _Import with I_mport in GtkBuilder file.
This means that there is only one _I in the File menu.
John Darrington [Tue, 8 Jan 2013 21:13:05 +0000 (22:13 +0100)]
Added a bit more to the gui
John Darrington [Sun, 6 Jan 2013 18:27:04 +0000 (19:27 +0100)]
fix compile issues
John Darrington [Sun, 6 Jan 2013 13:35:45 +0000 (14:35 +0100)]
Fix syntax generation
John Darrington [Sun, 6 Jan 2013 13:10:22 +0000 (14:10 +0100)]
Try to load the correct sheet
John Darrington [Sun, 6 Jan 2013 09:35:46 +0000 (10:35 +0100)]
data import gui: update user interface
John Darrington [Sun, 6 Jan 2013 08:01:20 +0000 (09:01 +0100)]
Change label from "import text" to "import".
Because it is not only used for text now.
John Darrington [Sun, 6 Jan 2013 07:48:24 +0000 (08:48 +0100)]
Spreadsheet readers: Seperate the mandatory from the optional arguments.
John Darrington [Sat, 5 Jan 2013 19:35:23 +0000 (20:35 +0100)]
Basic working spreadsheet import dialog (sort of)
John Darrington [Sat, 5 Jan 2013 13:21:56 +0000 (14:21 +0100)]
Added file chooser filters for spreadsheet file types
John Darrington [Sat, 5 Jan 2013 12:35:19 +0000 (13:35 +0100)]
Seperate test-data-import-dialog into different files
John Darrington [Sat, 16 Feb 2013 13:44:31 +0000 (14:44 +0100)]
Fixed a bug reading gnumeric files.
Importing gnumeric spreadsheets would assert-fail if there were empty columns at the start of the sheet.
John Darrington [Wed, 13 Feb 2013 12:03:00 +0000 (13:03 +0100)]
Examine vs. Boxplots: Avoid labels overlapping one another
One factored boxplots remove the name of the factor variables, since
these can be inferred from the chart title. Also trim off any
leading whitespace from the values. This reduces the chances of the
labels clashing with one another when many boxplots appear on the
same chart.
Closes bug #38132
John Darrington [Tue, 12 Feb 2013 14:07:11 +0000 (15:07 +0100)]
Output Viewer Export: Automatically append filename suffix
When exporting the output viewer using the file chooser, automatically append
a . and a three letter suffix indicating the format of the export.
Closes bug #38133
John Darrington [Sat, 9 Feb 2013 16:19:58 +0000 (17:19 +0100)]
REGRESSION: Added mention of the dependent variable to table titles.
Closes #34732
John Darrington [Tue, 5 Feb 2013 17:39:46 +0000 (18:39 +0100)]
Fixed compiler warning placement-parser.c
Ben Pfaff [Sat, 2 Feb 2013 16:52:54 +0000 (08:52 -0800)]
casereader: Remove casereader_split() function.
It no longer has any users.
Reported by John Darrington.
Ben Pfaff [Fri, 1 Feb 2013 06:02:08 +0000 (22:02 -0800)]
RANK: Add support for temporary transformations.
Bug #37999.
Reported by Zoltan Fabian.
Ben Pfaff [Thu, 31 Jan 2013 07:03:29 +0000 (23:03 -0800)]
RANK: Adopt a new ranking implementation.
Before this commit, the implementation of RANK made multiple passes
through the active file, opening and closing it (with proc_open()
and proc_commit()) as many times as there were input variables.
This worked in simple cases, but it could never work with
TEMPORARY since the second proc_open() will see a different set
of data from the first one.
This commit rewrites RANK to open and read the active file only
once. It does not make RANK properly work with TEMPORARY, but
it brings it much closer. It may also be faster in some cases
because, although it makes the same number of passes through
the input data (necessarily), each pass discards all the input
columns except the ones that are really need for that pass.
Ben Pfaff [Thu, 31 Jan 2013 06:51:02 +0000 (22:51 -0800)]
RANK: Create all variables together, in order.
An upcoming commit will rewrite the RANK implementation so that the
new variables are not created until after a pass through the data.
(This makes sense because their values cannot actually be determined
until that pass is complete, so there is no point in allocating space
for them in cases.) To do that, it is necessary to figure out the
variable names (and that they will be valid variable names) in
advance. This commit switches to that approach in advance.
This approach has another small advantage: the order of the variables
added by RANK to the dictionary does not depend on whether the
variables are named by the user or by generating a name. (This
is why the rank.at test case changes.)
Ben Pfaff [Thu, 31 Jan 2013 05:19:53 +0000 (21:19 -0800)]
RANK: Simplify rank_sorted_file() with new function sum_weights().
This makes the code easier to read and possibly even faster.
Ben Pfaff [Thu, 24 Jan 2013 06:55:24 +0000 (22:55 -0800)]
RANK: Simplify fraction_name() function.
The caller only needs a constant string so we might as well just return
one directly rather than through a static buffer.
Ben Pfaff [Thu, 24 Jan 2013 06:54:22 +0000 (22:54 -0800)]
RANK: Put #include directives into typical order.
Ben Pfaff [Thu, 24 Jan 2013 06:52:10 +0000 (22:52 -0800)]
RANK: Remove write-only struct member 'ascending'.
Ben Pfaff [Mon, 21 Jan 2013 23:45:58 +0000 (15:45 -0800)]
RANK: Lowercase the name of "enum RANK_FUNC".
It is fairly unusual to give a type an all-uppercase name. The name looks
more natural to me in lowercase.
Ben Pfaff [Tue, 29 Jan 2013 06:54:18 +0000 (22:54 -0800)]
transformations: Relax the rules for transformation finalizing.
The trns_chain data structure has a barely useful concept called
"finalization". In practice this is used to make sure that control
structures (e.g. DO IF) that are opened get closed (e.g. END IF). There
are currently some restrictions on finalizing: namely, transformations
can't be added after a chain is finalized. Since finalizers are barely
used, we can relax this restriction, which this commit does. This will be
used in an upcoming commit where the ability to add a transformation to a
finalized change becomes useful for a corner case.
Ben Pfaff [Fri, 25 Jan 2013 07:16:44 +0000 (23:16 -0800)]
subcase: New function subcase_add_vars_always().
This function will be used in an upcoming commit.
Ben Pfaff [Tue, 22 Jan 2013 03:28:57 +0000 (19:28 -0800)]
casegrouper: Add comments.
John Darrington [Mon, 28 Jan 2013 18:00:29 +0000 (19:00 +0100)]
Ensure that RELIABILITY is always fully constructed.
Commit
e94a39ff572a51907545497c26faccdf4b2c5ada added a 'no crash' test
checking that RELIABILITY's destructor didn't cause any problems when
the procedure was presented with invalid syntax. Unfortunately the
associated fix was only half done. The scale_name variable was being
destroyed when it hadn't been initialised. This change fixes that.
Reported-by: Jeremy Lavergne
John Darrington [Fri, 25 Jan 2013 11:34:31 +0000 (12:34 +0100)]
Reliability: Fix crash on invalid syntax
John Darrington [Sun, 20 Jan 2013 13:16:19 +0000 (14:16 +0100)]
Improve the printing size on Windows.
There were reports that on Windoze the printed output was tiny. I
think this commit might improve things a little.
John Darrington [Sun, 20 Jan 2013 11:49:54 +0000 (12:49 +0100)]
Fix xr to point unit conversion in cairo output driver.
The conversion between points (1/72") and xr units was wrong.
This meant that some things were slightly the wrong size.
Reviewed-by: Ben Pfaff
John Darrington [Sun, 20 Jan 2013 13:53:41 +0000 (14:53 +0100)]
Output window: properly handle the dispose/finalisation
Ben Pfaff [Thu, 17 Jan 2013 07:32:26 +0000 (23:32 -0800)]
Document and implement "precision record" in portable file format.
John Darrington [Tue, 15 Jan 2013 18:04:53 +0000 (19:04 +0100)]
Remove configure flag --enable-anachronistic-dependencies
This flag was a kludge and is not used anymore anyway.
Ben Pfaff [Sat, 12 Jan 2013 20:01:16 +0000 (12:01 -0800)]
lexer: Generalize lex_match_phrase() to handle any syntax.
This makes lex_match_phrase() slightly more useful. It also eliminates
the ASCII-only requirement.
Ben Pfaff [Sat, 12 Jan 2013 19:10:08 +0000 (11:10 -0800)]
scan: Introduce string_lexer for simple tokenizing of a string.
The following commit will introduce a user outside of the tests.
Ben Pfaff [Mon, 7 Jan 2013 06:42:53 +0000 (22:42 -0800)]
segment: Don't require the input to end in a new-line.
Ben Pfaff [Mon, 7 Jan 2013 06:41:17 +0000 (22:41 -0800)]
segment: Separate SEG_N_TYPES from enum segment_type.
With SEG_N_TYPES not actually a member of enum segment_type, GCC doesn't
complain if it's missing from a switch statement on that type.
Ben Pfaff [Sun, 6 Jan 2013 23:20:32 +0000 (15:20 -0800)]
identifier: Make lex_id_get_length() handle Unicode.
This function's only caller is documented only to handle ASCII, so this
commit does not fix any bug, but it seems better to generalize our code.
Ben Pfaff [Sat, 12 Jan 2013 17:43:18 +0000 (09:43 -0800)]
cairo: Include command name in error messages.
Commit
ddb7b52128d8 (output: Make errors, warnings, and notes into a new
"message_item".) changed command name tracking to a responsibility of
individual output drivers, and converted the output drivers to do it.
However, the conversion of the cairo driver was incomplete. This commit
fixes that problem.
Reported by John Darrington.
John Darrington [Sat, 12 Jan 2013 13:25:51 +0000 (14:25 +0100)]
Gnumeric Reader: Set dictionary to NULL on error
John Darrington [Fri, 11 Jan 2013 14:26:58 +0000 (15:26 +0100)]
Simplify creation of pango layout in xr driver.
Create the layouts with pango_cairo_create_layout instead of
pango_layout_new. This seems simpler and avoids a kludge.
Reviewed-By: Ben Pfaff
Ben Pfaff [Thu, 10 Jan 2013 05:52:37 +0000 (21:52 -0800)]
doc: Better describe the meaning of THRU in the RECODE command.
pohaku <pg@hawaii.edu> reported that the description was ambiguous.
Ben Pfaff [Thu, 10 Jan 2013 05:51:43 +0000 (21:51 -0800)]
doc: Improve formatting of RECODE command description.