From: John Darrington Date: Thu, 9 May 2013 09:40:03 +0000 (+0200) Subject: Revert "Work-around bug in GCC 4.4.5" X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fbuilds%2F20130510010502%2Fpspp;p=pspp Revert "Work-around bug in GCC 4.4.5" This reverts commit c7711e39f523f206a74f5d0f52480ad10267e0ca. The claim of a bug in GCC proved to be unfounded. The problem which this change tried to work-around has in fact been fixed in commit 19bf192a093527bf10b1de95fbe8798ba156f960 --- diff --git a/src/data/casereader.c b/src/data/casereader.c index adb6b6a909..c8050c6cde 100644 --- a/src/data/casereader.c +++ b/src/data/casereader.c @@ -242,19 +242,6 @@ casereader_count_cases__ (const struct casereader *reader, struct casereader *clone; casenumber n_cases; - /* This seems to avoid a bug in Gcc 4.4.5 where, upon - return from this function, the stack appeared corrupt, - and the program returned to the wrong address. Oddly - the problem only manifested itself when used in conjunction - with the ODS reader, in code such as: - - GET DATA /TYPE=ODS .... - LIST. - */ -#if (__GNUC__ == 4 ) && (__GNUC_MINOR__ == 4) - volatile int x = 1; x++; -#endif - clone = casereader_clone (reader); n_cases = casereader_advance (clone, max_cases); casereader_destroy (clone);