From: Ben Pfaff <blp@nicira.com>
Date: Thu, 13 Nov 2008 18:25:06 +0000 (-0800)
Subject: Never free an skb that has been passed to genlmsg_reply().
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fba83e40339148ab8515d4ee06f6b173462ad444;p=openvswitch

Never free an skb that has been passed to genlmsg_reply().

genlmsg_reply() always consumes its argument, not just in the success case.
---

diff --git a/datapath/datapath.c b/datapath/datapath.c
index 07fa92d0..2a8e5a96 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -1176,8 +1176,7 @@ static int dp_genl_query(struct sk_buff *skb, struct genl_info *info)
 
 		genlmsg_end(ans_skb, data);
 		err = genlmsg_reply(ans_skb, info);
-		if (!err)
-			ans_skb = NULL;
+		ans_skb = NULL;
 	}
 err:
 nla_put_failure: