From: Justin Pettit <jpettit@nicira.com>
Date: Tue, 17 Nov 2009 00:36:21 +0000 (-0800)
Subject: ovs-appctl: Fix shadow variable that could cause segfault
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=fb344b867b96a6d6b9ec32e277cae6db68f2f236;p=openvswitch

ovs-appctl: Fix shadow variable that could cause segfault

The variable "socket_name" contains the name of the unix domain socket
to be used for communicating with the OVS process.  If the target does
not begin with a "/", the socket name is determined based on a pidfile.
A shadow copy of "socket_name" was kept in the block that looks at the
pidfile, which would cause the function-level one to not be set.  This
removes that shadow copy.
---

diff --git a/utilities/ovs-appctl.c b/utilities/ovs-appctl.c
index 060e8e28..1302bf2e 100644
--- a/utilities/ovs-appctl.c
+++ b/utilities/ovs-appctl.c
@@ -170,7 +170,6 @@ connect_to_target(const char *target)
 
     if (target[0] != '/') {
         char *pidfile_name;
-        char *socket_name;
         pid_t pid;
 
         pidfile_name = xasprintf("%s/%s.pid", ovs_rundir, target);