From: Ben Pfaff Date: Fri, 15 Jul 2011 18:25:14 +0000 (-0700) Subject: ovsdb: Log when remote connections are deconfigured. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f97ffebfb8e66d7ce0ed78517dff322aa4825aea;p=openvswitch ovsdb: Log when remote connections are deconfigured. Recently I helped debug a scenario where ovsdb-server connected to a remote manager, then ovs-vsctl deleted the remote manager and soon after re-added it. The log was difficult to interpret because it showed two successful connection attempts to the same remote without showing a reason why the connection was dropped in the first place. Adding this log message would make it clear that the configuration changed to remove that remote connection in the meantime. --- diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c index 1da15785..e999adaf 100644 --- a/ovsdb/jsonrpc-server.c +++ b/ovsdb/jsonrpc-server.c @@ -141,6 +141,7 @@ ovsdb_jsonrpc_server_set_remotes(struct ovsdb_jsonrpc_server *svr, SHASH_FOR_EACH_SAFE (node, next, &svr->remotes) { if (!shash_find(new_remotes, node->name)) { + VLOG_INFO("%s: remote deconfigured", node->name); ovsdb_jsonrpc_server_del_remote(node); } }