From: Ben Pfaff <blp@nicira.com>
Date: Wed, 10 Feb 2010 19:13:09 +0000 (-0800)
Subject: vswitch: Fix uninitialized variable.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=f446d59b369ec2c5df79ee3589c50eb22f949a63;p=openvswitch

vswitch: Fix uninitialized variable.

The 'ip' variable in this inner "if" statement shadows a variable with
the same name in the enclosing block.  The variable in the inner block
is never initialized.

Found by Clang (http://clang-analyzer.llvm.org).
---

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 05ace798..53b20e32 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1472,7 +1472,7 @@ bridge_reconfigure_controller(const struct ovsrec_open_vswitch *ovs_cfg,
             local_iface = bridge_get_local_iface(br);
             if (local_iface && c->local_ip && inet_aton(c->local_ip, &ip)) {
                 struct netdev *netdev = local_iface->netdev;
-                struct in_addr ip, mask, gateway;
+                struct in_addr mask, gateway;
 
                 if (!c->local_netmask || !inet_aton(c->local_netmask, &mask)) {
                     mask.s_addr = 0;