From: Ben Pfaff <blp@gnu.org>
Date: Sun, 7 May 2006 05:46:26 +0000 (+0000)
Subject: Simplify multipass_procedure().
X-Git-Tag: v0.6.0~879
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e83ae31468417739c11aa52c993e80347bbb82e4;p=pspp-builds.git

Simplify multipass_procedure().
Fix memory leak.
---

diff --git a/src/data/ChangeLog b/src/data/ChangeLog
index c3b44971..e323b22d 100644
--- a/src/data/ChangeLog
+++ b/src/data/ChangeLog
@@ -1,3 +1,18 @@
+Sat May  6 22:45:55 2006  Ben Pfaff  <blp@gnu.org>
+
+	* procedure.c (proc_done): Destroy default_dict, to fix memory
+	leak.
+
+Sat May  6 22:44:44 2006  Ben Pfaff  <blp@gnu.org>
+
+	Simplify procedure_with_splits().
+	
+	* procedure.c (struct split_aux_data): Removed case_count member.
+	(procedure_with_splits) Don't initialize case_count.
+	(split_procedure_case_func) Check whether prev_case is null
+	instead of case_count.
+	(split_procedure_end_func) Ditto.
+
 Sat May  6 22:42:23 2006  Ben Pfaff  <blp@gnu.org>
 
 	* case.c (case_move): Do nothing if dst and src are the same
diff --git a/src/data/procedure.c b/src/data/procedure.c
index 1b1e628b..a2ca8b23 100644
--- a/src/data/procedure.c
+++ b/src/data/procedure.c
@@ -458,7 +458,6 @@ lagged_case (int n_before)
 /* Represents auxiliary data for handling SPLIT FILE. */
 struct split_aux_data 
   {
-    size_t case_count;          /* Number of cases so far. */
     struct ccase prev_case;     /* Data in previous case. */
 
     /* Callback functions. */
@@ -498,7 +497,6 @@ procedure_with_splits (void (*begin_func) (const struct ccase *, void *aux),
   struct split_aux_data split_aux;
   bool ok;
 
-  split_aux.case_count = 0;
   case_nullify (&split_aux.prev_case);
   split_aux.begin_func = begin_func;
   split_aux.proc_func = proc_func;
@@ -520,10 +518,10 @@ split_procedure_case_func (const struct ccase *c, void *split_aux_)
   struct split_aux_data *split_aux = split_aux_;
 
   /* Start a new series if needed. */
-  if (split_aux->case_count == 0
+  if (case_is_null (&split_aux->prev_case)
       || !equal_splits (c, &split_aux->prev_case))
     {
-      if (split_aux->case_count > 0 && split_aux->end_func != NULL)
+      if (!case_is_null (&split_aux->prev_case) && split_aux->end_func != NULL)
         split_aux->end_func (split_aux->func_aux);
 
       case_destroy (&split_aux->prev_case);
@@ -533,7 +531,6 @@ split_procedure_case_func (const struct ccase *c, void *split_aux_)
 	split_aux->begin_func (&split_aux->prev_case, split_aux->func_aux);
     }
 
-  split_aux->case_count++;
   return (split_aux->proc_func == NULL
           || split_aux->proc_func (c, split_aux->func_aux));
 }
@@ -544,7 +541,7 @@ split_procedure_end_func (void *split_aux_)
 {
   struct split_aux_data *split_aux = split_aux_;
 
-  if (split_aux->case_count > 0 && split_aux->end_func != NULL)
+  if (!case_is_null (&split_aux->prev_case) && split_aux->end_func != NULL)
     split_aux->end_func (split_aux->func_aux);
   return true;
 }
@@ -802,6 +799,7 @@ void
 proc_done (void)
 {
   discard_variables ();
+  dict_destroy (default_dict);
 }
 
 /* Sets SINK as the destination for procedure output from the