From: Justin Pettit <jpettit@nicira.com>
Date: Tue, 14 Jul 2009 07:25:44 +0000 (-0700)
Subject: Fix unitialized variable in coverage_log()
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e775da1437a9532765046baffdbc22d5252c0cc7;p=openvswitch

Fix unitialized variable in coverage_log()

When providing the ability to force coverage printouts to occur, some
code was moved around that allowed the "hash" variable to be used
unitialized.  This fixes that.

Thanks to Ben for pointing out the problem.

Bug #1577
---

diff --git a/lib/coverage.c b/lib/coverage.c
index 6f805e9e..ba5d68d8 100644
--- a/lib/coverage.c
+++ b/lib/coverage.c
@@ -134,8 +134,8 @@ coverage_log(enum vlog_level level, bool suppress_dups)
         return;
     }
 
+    hash = coverage_hash();
     if (suppress_dups) {
-        hash = coverage_hash();
         if (coverage_hit(hash)) {
             VLOG(level, "Skipping details of duplicate event coverage for "
                  "hash=%08"PRIx32" in epoch %u", hash, epoch);