From: Ben Pfaff <blp@cs.stanford.edu>
Date: Tue, 10 Jul 2012 04:36:31 +0000 (-0700)
Subject: psppire-data-window: Avoid reference leak to PsppireDict.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e4285da27e87ed3f0fb662783e2ac6611cf467f3;p=pspp

psppire-data-window: Avoid reference leak to PsppireDict.

psppire_var_store_new() takes its own reference to PsppireDict so
the original reference owned by psppire_data_window_finish_init()
wasn't getting tracked anywhere.
---

diff --git a/src/ui/gui/psppire-data-window.c b/src/ui/gui/psppire-data-window.c
index 2149a89dbd..a465ff8e21 100644
--- a/src/ui/gui/psppire-data-window.c
+++ b/src/ui/gui/psppire-data-window.c
@@ -951,6 +951,7 @@ psppire_data_window_finish_init (PsppireDataWindow *de,
   de->dataset = ds;
   dict = psppire_dict_new_from_dict (dataset_dict (ds));
   de->var_store = psppire_var_store_new (dict);
+  g_object_unref (dict);
   de->data_store = psppire_data_store_new (dict);
   psppire_data_store_set_reader (de->data_store, NULL);
 
diff --git a/src/ui/gui/psppire-var-store.c b/src/ui/gui/psppire-var-store.c
index 91706fae57..27072c1adf 100644
--- a/src/ui/gui/psppire-var-store.c
+++ b/src/ui/gui/psppire-var-store.c
@@ -381,8 +381,8 @@ psppire_var_store_sheet_model_init (PsppireSheetModelIface *iface)
 
 /**
  * psppire_var_store_new:
- * @dict: The dictionary for this var_store.
- *
+ * @dict: The dictionary for this var_store.  The caller retains its reference
+ * to @dict.
  *
  * Return value: a new #PsppireVarStore
  **/