From: John Darrington <john@darrington.wattle.id.au>
Date: Sat, 5 Sep 2020 03:08:12 +0000 (+0200)
Subject: Remove the --enable-debug configure option.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=db574d2c888401a4463a2c6b4923a335dd367642;p=pspp

Remove the --enable-debug configure option.

In practice, it is faster and simpler to make local modifications
to the respective files which debugging rather than reconfiguring
with --enable-debug.   Furthermore this is just another configure
option which confuses users and serves little purpose.
---

diff --git a/configure.ac b/configure.ac
index 93395f1809..61d5ae7857 100644
--- a/configure.ac
+++ b/configure.ac
@@ -286,14 +286,6 @@ AC_CHECK_FUNCS([__setfpucw fork execl isinf isnan finite getpid feholdexcept fps
 
 AC_PROG_LN_S
 
-AC_ARG_ENABLE(
-  debug,
-  [AS_HELP_STRING([--enable-debug],
-                  [Turn on diagnostic features in the program])])
-if test x"$enable_debug" = x"yes"  ; then
-  AC_DEFINE(DEBUGGING, 1, [Define to 1 if debugging is enabled.])
-fi
-
 # iconv is required
 AM_ICONV
 if test "$am_cv_func_iconv" != "yes"; then
diff --git a/src/libpspp/pool.h b/src/libpspp/pool.h
index da95f4ec7c..ebc00c5f0f 100644
--- a/src/libpspp/pool.h
+++ b/src/libpspp/pool.h
@@ -102,8 +102,4 @@ bool pool_unregister (struct pool *, void *);
 void pool_mark (struct pool *, struct pool_mark *);
 void pool_release (struct pool *, const struct pool_mark *);
 
-#if DEBUGGING
-void pool_dump (const struct pool *, const char *title);
-#endif
-
 #endif /* pool.h */
diff --git a/src/ui/gui/psppire-dict.c b/src/ui/gui/psppire-dict.c
index acf73af7a7..5487853fac 100644
--- a/src/ui/gui/psppire-dict.c
+++ b/src/ui/gui/psppire-dict.c
@@ -911,29 +911,6 @@ psppire_dict_get_weight_variable (const PsppireDict *dict)
   return dict_get_weight (dict->dict);
 }
 
-
-
-#if DEBUGGING
-void
-psppire_dict_dump (const PsppireDict *dict)
-{
-  gint i;
-  const struct dictionary *d = dict->dict;
-
-  for (i = 0; i < dict_get_var_cnt (d); ++i)
-    {
-      const struct variable *v = psppire_dict_get_variable (dict, i);
-      int di = var_get_dict_index (v);
-      g_print ("`%s' idx=%d, fv=%d\n",
-	       var_get_name(v),
-	       di,
-	       var_get_case_index(v));
-
-    }
-}
-#endif
-
-
 const gchar *
 psppire_dict_encoding (const PsppireDict *dict)
 {
diff --git a/src/ui/gui/psppire-dict.h b/src/ui/gui/psppire-dict.h
index c3674b1330..2ea7e0c1a6 100644
--- a/src/ui/gui/psppire-dict.h
+++ b/src/ui/gui/psppire-dict.h
@@ -121,10 +121,6 @@ void psppire_dict_replace_dictionary (PsppireDict *, struct dictionary *);
 
 struct variable * psppire_dict_get_weight_variable (const PsppireDict *);
 
-#if DEBUGGING
-void psppire_dict_dump (const PsppireDict *);
-#endif
-
 const gchar *psppire_dict_encoding (const PsppireDict *);
 
 G_END_DECLS