From: Ethan Jackson <ethan@nicira.com>
Date: Sat, 7 May 2011 00:02:02 +0000 (-0700)
Subject: bridge: Don't configure QoS without Queues.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=daa8bd2bf878640556195016df8c5ea2f812f9cc;p=openvswitch

bridge: Don't configure QoS without Queues.

It doesn't make sense to create a QoS object without any queues.
Before this patch, OVS would configure the QoS object and as a
result drop all traffic going through the affected interface.  With
this patch, OVS will simply clear QoS configuration on the
interface.

Bug #5583.
---

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index d883596d..56943f67 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -3534,7 +3534,7 @@ iface_delete_queues(unsigned int queue_id,
 static void
 iface_update_qos(struct iface *iface, const struct ovsrec_qos *qos)
 {
-    if (!qos || qos->type[0] == '\0') {
+    if (!qos || qos->type[0] == '\0' || qos->n_queues < 1) {
         netdev_set_qos(iface->netdev, NULL, NULL);
     } else {
         struct iface_delete_queues_cbdata cbdata;