From: Ben Pfaff <blp@cs.stanford.edu>
Date: Tue, 17 Jul 2012 05:20:42 +0000 (-0700)
Subject: var-type-dialog: Avoid string copy setting up currency treeview.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d0d20d580fb1fd4bb4d7a2af9233b876effdd448;p=pspp

var-type-dialog: Avoid string copy setting up currency treeview.

The return value of fmt_name() is perfectly suitable here.
---

diff --git a/src/ui/gui/var-type-dialog.c b/src/ui/gui/var-type-dialog.c
index 21d49669de..786b0c4217 100644
--- a/src/ui/gui/var-type-dialog.c
+++ b/src/ui/gui/var-type-dialog.c
@@ -502,11 +502,9 @@ var_type_dialog_create (GtkWindow *toplevel)
   for ( i = 0 ; i < 5 ; ++i )
     {
       enum fmt_type cc_fmts[5] = {FMT_CCA, FMT_CCB, FMT_CCC, FMT_CCD, FMT_CCE};
-      gchar text[4];
-      g_snprintf (text, 4, "%s", fmt_name (cc_fmts[i]));
       gtk_list_store_append (list_store, &iter);
       gtk_list_store_set (list_store, &iter,
-                          0, text,
+                          0, fmt_name (cc_fmts[i]),
 			  1, &cc_format[i],
 			  -1);
     }