From: Ben Pfaff <blp@cs.stanford.edu>
Date: Mon, 9 Jul 2012 06:27:52 +0000 (-0700)
Subject: psppire-data-editor: Unref old data_window upon change.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c70fe01eeffe530040004eae26c655dd1682f1bf;p=pspp

psppire-data-editor: Unref old data_window upon change.

Otherwise there's a reference leak.

Found by inspection; I haven't looked for clients that actually
change the data window after setting it.
---

diff --git a/src/ui/gui/psppire-data-editor.c b/src/ui/gui/psppire-data-editor.c
index 16b1393df3..aae43698ac 100644
--- a/src/ui/gui/psppire-data-editor.c
+++ b/src/ui/gui/psppire-data-editor.c
@@ -385,6 +385,8 @@ psppire_data_editor_set_property (GObject         *object,
       psppire_data_editor_split_window (de, g_value_get_boolean (value));
       break;
     case PROP_DATA_WINDOW:
+      if (de->data_window)
+        g_object_unref (de->data_window);
       de->data_window = g_value_get_pointer (value);
       g_object_ref (de->data_window);
       break;