From: Ben Pfaff Date: Tue, 3 Aug 2010 21:37:22 +0000 (-0700) Subject: tag: Use existing macro instead of constant. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c393047875e2c9dc76b2f19092fff6bbf69ec4f9;p=openvswitch tag: Use existing macro instead of constant. N_TAG_BITS is always 32, currently, because tag_type is a typedef for uint32_t, so this does not fix an actual bug. --- diff --git a/lib/tag.c b/lib/tag.c index 955cf30e..0430224c 100644 --- a/lib/tag.c +++ b/lib/tag.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009 Nicira Networks. + * Copyright (c) 2008, 2009, 2010 Nicira Networks. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -49,7 +49,7 @@ tag_type tag_create_deterministic(uint32_t seed) { int x = seed & (N_TAG_BITS - 1); - int y = (seed >> LOG2_N_TAG_BITS) % 31; + int y = (seed >> LOG2_N_TAG_BITS) % (N_TAG_BITS - 1); y += y >= x; return (1u << x) | (1u << y); }