From: Jesse Gross <jesse@nicira.com>
Date: Fri, 2 Oct 2009 17:31:20 +0000 (-0700)
Subject: netdev-linux: Return correct error codes on receive.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c0e5f6cabeeb8153144fead66c1f37a5014d9060;p=openvswitch

netdev-linux: Return correct error codes on receive.

netdev_linux_receive was returning positive error codes while the
interface specifies that it should be returning negative errors.
This difference causes a huge increase in (non-existant) packet
processing with the userspace datapath.
---

diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 50a0d2da..c71bdd49 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -370,7 +370,7 @@ netdev_linux_recv(struct netdev *netdev_, void *data, size_t size)
 
     if (netdev->tap_fd < 0) {
         /* Device was opened with NETDEV_ETH_TYPE_NONE. */
-        return EAGAIN;
+        return -EAGAIN;
     }
 
     for (;;) {
@@ -382,7 +382,7 @@ netdev_linux_recv(struct netdev *netdev_, void *data, size_t size)
                 VLOG_WARN_RL(&rl, "error receiving Ethernet packet on %s: %s",
                              strerror(errno), netdev_get_name(netdev_));
             }
-            return errno;
+            return -errno;
         }
     }
 }