From: Ben Pfaff <blp@gnu.org>
Date: Sat, 16 Dec 2006 20:57:15 +0000 (+0000)
Subject: Allow RANK grouping variables to be strings.  Fixes bug #18533.
X-Git-Tag: v0.6.0~635
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c03a42996cfd422728e85631682ed13a8c298f2a;p=pspp-builds.git

Allow RANK grouping variables to be strings.  Fixes bug #18533.
Thanks to John Darrington for review.
---

diff --git a/src/language/stats/ChangeLog b/src/language/stats/ChangeLog
index 95e24640..c082e42a 100644
--- a/src/language/stats/ChangeLog
+++ b/src/language/stats/ChangeLog
@@ -1,3 +1,8 @@
+Sat Dec 16 12:54:27 2006  Ben Pfaff  <blp@gnu.org>
+
+	* rank.q (rank_custom_variables): Allow grouping variables to be
+	strings.  Fixes bug #18533.  Thanks to John Darrington for review.
+
 Sat Dec  9 18:47:51 2006  Ben Pfaff  <blp@gnu.org>
 
 	* regression.q (is_depvar): Compare variable pointers instead of
diff --git a/src/language/stats/rank.q b/src/language/stats/rank.q
index 10ad7715..882d04eb 100644
--- a/src/language/stats/rank.q
+++ b/src/language/stats/rank.q
@@ -952,7 +952,7 @@ rank_custom_variables (struct lexer *lexer, struct dataset *ds, struct cmd_rank
 
       if (!parse_variables (lexer, dataset_dict (ds), 
 			    &group_vars, &n_group_vars,
-			    PV_NO_DUPLICATE | PV_NUMERIC | PV_NO_SCRATCH) )
+			    PV_NO_DUPLICATE | PV_NO_SCRATCH) )
 	{
 	  free (group_vars);
 	  return 0;