From: Ben Pfaff <blp@nicira.com>
Date: Thu, 16 Jun 2011 21:05:17 +0000 (-0700)
Subject: bridge: Avoid duplicate logging when netdev_get_etheraddr() fails.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ba489aa7a52e129bc3939ac91f8127fc0c1bb385;p=openvswitch

bridge: Avoid duplicate logging when netdev_get_etheraddr() fails.

get_etheraddr() in netdev-linux.c logs when the Ethernet address cannot be
obtained so there is no need to log again in the caller.

Bug #5844.
---

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 9868ef5b..3a9cfa9d 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1023,9 +1023,6 @@ bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
             /* Grab MAC. */
             error = netdev_get_etheraddr(iface->netdev, iface_ea);
             if (error) {
-                static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
-                VLOG_ERR_RL(&rl, "failed to obtain Ethernet address of %s: %s",
-                            iface->name, strerror(error));
                 continue;
             }
         }