From: Justin Pettit <jpettit@nicira.com>
Date: Sat, 25 Oct 2008 20:29:17 +0000 (-0700)
Subject: Fix leaking of flows when output action validation fails.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b969b51164f028a728efded35550a02926b5aa20;p=openvswitch

Fix leaking of flows when output action validation fails.

Thanks to Brandon Heller for catching this.
---

diff --git a/switch/datapath.c b/switch/datapath.c
index fb61d0ae..8fdc9d3a 100644
--- a/switch/datapath.c
+++ b/switch/datapath.c
@@ -992,7 +992,7 @@ add_flow(struct datapath *dp, const struct sender *sender,
     if (v_code != ACT_VALIDATION_OK) {
         dp_send_error_msg(dp, sender, OFPET_BAD_ACTION, v_code,
                   ofm, ntohs(ofm->header.length));
-        goto error;
+        goto error_free_flow;
     }
 
     /* Fill out flow. */