From: Ben Pfaff Date: Thu, 11 Oct 2012 17:56:12 +0000 (-0700) Subject: nicira-ext: Correct and improve nx_flow_update_abbrev comment. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b10a4760be32849e33a2b85084491b7ab058efcd;p=openvswitch nicira-ext: Correct and improve nx_flow_update_abbrev comment. Notifications always precede a barrier that follows a given flow_mod, not a barrier that precedes a flow_mod as the text here previously claimed. Also, the text about abbreviated notifications is equally applicable to normal, unabbreviated notifications, so say that explicitly. Reported-by: Jean Tourrilhes Acked-by: Jean Tourrilhes Signed-off-by: Ben Pfaff --- diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h index 75bf6db3..7e49550f 100644 --- a/include/openflow/nicira-ext.h +++ b/include/openflow/nicira-ext.h @@ -2173,10 +2173,10 @@ OFP_ASSERT(sizeof(struct nx_flow_update_full) == 24); * change in future versions of Open vSwitch. * * OVS will always send the notifications for a given flow table change before - * the reply to a OFPT_BARRIER_REQUEST request that precedes the flow table - * change. Thus, if the controller does not receive an abbreviated - * notification for a flow_mod before the next OFPT_BARRIER_REPLY, it will - * never receive one. */ + * the reply to a OFPT_BARRIER_REQUEST request that follows the flow table + * change. Thus, if the controller does not receive an abbreviated (or + * unabbreviated) notification for a flow_mod before the next + * OFPT_BARRIER_REPLY, it will never receive one. */ struct nx_flow_update_abbrev { ovs_be16 length; /* Length is 8. */ ovs_be16 event; /* NXFME_ABBREV. */